Uh oh!
There was an error while loading. Please reload this page.
Type checker: recover function type unification in method checking - #19036
Closed
auduchinok wants to merge 4 commits into
Closed
Type checker: recover function type unification in method checking#19036auduchinok wants to merge 4 commits into
auduchinok wants to merge 4 commits into
Conversation
# Conflicts: # tests/FSharp.Compiler.Service.Tests/TypeChecker/TypeCheckerRecoveryTests.fs
Contributor
❗ Release notes required
|
abonie
approved these changes
Oct 29, 2025
auduchinok
commented
Oct 29, 2025
MemberAuthor
This is ready 🙂 |
edgarfgp
approved these changes
Oct 31, 2025
T-Gro
enabled auto-merge (squash)
November 11, 2025 12:49
abonie
approved these changes
Aug 18, 2026
abonie
commented
Aug 18, 2026
Member
@auduchinok if you could resolve conflicts on this one maybe we can merge it (or see what the build errors were) |
auduchinok
commented
Aug 19, 2026
MemberAuthor
auto-merge was automatically disabled
August 19, 2026 12:15
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds recovery when it's not possible to unify the method type with the expected type:
The error would lead to the method symbol not being reported, so features like 'Go to Declaration' or getting the tooltip would not work.