Skip to content

Bugfix :: Coloring for case testers and with - #19311

Merged
T-Gro merged 7 commits into
mainfrom
bugfix-coloring-recordWith-iscasetester
Feb 19, 2026
Merged

Bugfix :: Coloring for case testers and with#19311
T-Gro merged 7 commits into
mainfrom
bugfix-coloring-recordWith-iscasetester

Conversation

@T-Gro

@T-GroT-Gro commented Feb 17, 2026•
edited
Loading

Copy link
Copy Markdown
Member

Coloring issues identified at #19252 (comment) and
#19252 (comment)

@github-actions

github-actionsBot commented Feb 17, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

❗ Release notes required

✅ Found changes and release notes in following paths:

Change pathRelease notes pathDescription
src/Compilerdocs/release-notes/.FSharp.Compiler.Service/10.0.300.md

@T-Gro
T-Groforce-pushed the bugfix-coloring-recordWith-iscasetester branch from fff6aa7 to 6103fcaCompareFebruary 17, 2026 12:47
@T-Gro

T-Gro commented Feb 17, 2026

Copy link
Copy Markdown
MemberAuthor

@kerams :

Another thing which fell out of the implementation is that we can decide to color the union case accessor the same we color its constructor and the case itself, i.e. not like a property.

I can see reasoning for both "its all artifacts of the case - declaration, constructor, tester" as well as "its just another member".

See here how it si colored differently from the custom prop., I kind of like it. WDYT about it?
image

@T-Gro
T-Gro marked this pull request as ready for review February 18, 2026 12:16
@T-Gro
T-Gro requested a review from a team as a code ownerFebruary 18, 2026 12:16
@T-Gro
T-Gro requested a review from abonieFebruary 18, 2026 12:17
@kerams

kerams commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Why not. It'll make flattening a case to boolean stand out more. Making it configurable is always an option should someone complain.

auduchinok
auduchinok reviewed Feb 18, 2026
View reviewed changes
Comment threadsrc/Compiler/Checking/NameResolution.fs Outdated
@github-project-automationgithub-project-automationBot moved this from New to In Progress in F# Compiler and ToolingFeb 18, 2026
auduchinok
auduchinok reviewed Feb 18, 2026
View reviewed changes
Comment threadsrc/Compiler/Checking/NameResolution.fs Outdated
T-Gro
T-Gro commented Feb 18, 2026
View reviewed changes
Comment threadsrc/Compiler/Checking/NameResolution.fs Outdated
T-Gro
T-Gro commented Feb 18, 2026
View reviewed changes
Comment threadsrc/Compiler/Checking/NameResolution.fs Outdated
@T-Gro
T-Gro enabled auto-merge (squash) February 19, 2026 13:46
@T-Gro
T-Gro merged commit 7d0437e into mainFeb 19, 2026
44 checks passed
This was referenced Feb 20, 2026
Merged
Merged
Merged
Merged
@dotnet-botdotnet-bot mentioned this pull request Mar 2, 2026
Closed
T-Gro added a commit that referenced this pull request Mar 2, 2026
@T-Gro
Fixup#1: Restore deleted release notes, add trailing newline
5c94a60
- Restore docs/release-notes/.Language/11.0.md (DIM hierarchy notes from PR #19241)
- Restore docs/release-notes/.FSharp.Compiler.Service/10.0.300.md entries
(Nullness fixes PR #19262, graph-based checking PR #19280, semantic
classification PR #19311, type checker recovery PR #19314, overload
resolution cache)
- Add trailing newline to Operators.fs
- Remove untracked docs/RFC_Review.md review artifact
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@dotnet-botdotnet-bot mentioned this pull request Mar 14, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonieabonieabonie approved these changes
+1 more reviewer
@auduchinokauduchinokauduchinok left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@T-Gro@kerams@auduchinok@abonie