Uh oh!
There was an error while loading. Please reload this page.
Add FSI options tests - #19346
Merged
Merged
Conversation
Contributor
✅ No release notes required |
3 tasks
bbatsovforce-pushed
the
add-fsi-options-tests
branch
from
March 5, 2026 10:39
dc1a4fe to
67e228eCompareT-Gro
marked this pull request as draft
March 6, 2026 18:26
T-Gro
approved these changes
Apr 10, 2026
T-Gro
reviewed
Apr 10, 2026
Uh oh!
There was an error while loading. Please reload this page.
bbatsovforce-pushed
the
add-fsi-options-tests
branch
from
May 12, 2026 16:33
67e228e to
c20d2feCompareAdd runFsiProcess/runFscProcess subprocess helpers to Compiler.fs and include the existing CLI test files (FsiCliTests.fs, FscCliTests.fs, CliProcessTests.fs) in the project build. Add 19 new tests covering --quiet, --exec, --use, --load, --gui, --readline, --quotations-debug, --shadowcopyreferences, --nologo, and error cases for unknown options and invalid --warn levels. Contributes to dotnet#13878
bbatsovforce-pushed
the
add-fsi-options-tests
branch
from
May 12, 2026 16:38
c20d2fe to
f647f00Comparebbatsov
marked this pull request as ready for review
May 12, 2026 18:29
…fsproj The PR added three spurious <Compile> items that broke the build across all test-running CI jobs: - CompilerOptions\fsc\FscCliTests.fs duplicated the existing Fsc\FscCliTests.fs - CompilerOptions\fsi\FsiCliTests.fs duplicated an existing entry - CompilerOptions\CliProcessTests.fs referenced a file that does not exist The new FSI option tests live in the already-referenced FsiCliTests.fs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
# Conflicts: # tests/FSharp.Compiler.ComponentTests/CompilerOptions/fsi/FsiCliTests.fs
abonie
approved these changes
Aug 18, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds test coverage for FSI-specific command-line options that previously had none. This includes
--quiet,--exec,--use,--load,--gui,--readline,--quotations-debug,--shadowcopyreferences,--nologo, and error cases for unknown options and invalid--warnlevels.Also wires up the existing but never-compiled CLI test files (
FsiCliTests.fs,FscCliTests.fs,CliProcessTests.fs) by adding them to the.fsprojand implementing therunFsiProcess/runFscProcesssubprocess helpers they depend on.Contributes to #13878
Checklist
Test cases added
Performance benchmarks added in case of performance changes
Release notes entry updated:
If you believe that release notes are not necessary for this PR, please add
NO_RELEASE_NOTESlabel to the pull request.