Skip to content

Add documentation and tests that maxBy/minBy return the first max/min element - #19464

Merged
T-Gro merged 2 commits into
mainfrom
copilot/aw-debug-repo-assist-failure
Mar 27, 2026
Merged

Add documentation and tests that maxBy/minBy return the first max/min element#19464
T-Gro merged 2 commits into
mainfrom
copilot/aw-debug-repo-assist-failure

Conversation

CopilotAI commented Mar 24, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

Implements the approved but merge-conflicted changes from PR #19140. Documents the guarantee that maxBy/minBy return the first maximal/minimal element when duplicates exist, across Array, List, and Seq modules.

Documentation (array.fsi, list.fsi, seq.fsi)

  • Added <remarks> noting first-element-wins behavior for maxBy and minBy
  • Consolidated duplicate <remarks> tags in seq.fsi

Tests (ArrayModule2.fs, ListModule2.fs, SeqModule2.fs)

  • Added test cases for both maxBy and minBy verifying the first matching element is returned
// Example: 3 appears twice, first occurrence at "c" is returnedletmax= Array.maxBy fst [|1,"a";2,"b";3,"c";2,"d";3,"e";1,"f"|]assert(snd max ="c")
Original prompt

This section details on the original issue you should resolve

<issue_title>[aw] Repo Assist failed</issue_title>
<issue_description>### Workflow Failure

Workflow:Repo Assist
Branch: main
Run:https://github.com/dotnet/fsharp/actions/runs/23380883204
Pull Request:#19140

Action Required

Option 1: Debug using any coding agent

Use this prompt with any coding agent (GitHub Copilot, Claude, Gemini, etc.):

Debug the agentic workflow failure using https://raw.githubusercontent.com/github/gh-aw/main/debug.md
The failed workflow run is at https://github.com/dotnet/fsharp/actions/runs/23380883204

Option 2: Assign this issue to Copilot

Assign this issue to Copilot using the agentic-workflows sub-agent to automatically debug and fix the workflow failure.

Option 3: Manually invoke the agent

Debug this workflow failure using your favorite Agent CLI and the agentic-workflows prompt.

[!TIP]
To stop a workflow from creating failure issues, set report-failure-as-issue: false in its frontmatter:

safe-outputs:
report-failure-as-issue: false

Generated from Repo Assist

  • expires on Mar 28, 2026, 1:53 PM UTC

<agent_instructions>See the LATEST failure from the comment and focus on that.</agent_instructions>

Comments on the Issue (you are @copilot in this section)

💬 Send tasks to Copilot coding agent from Slack and Teams to turn conversations into code. Copilot posts an update in your thread when it's finished.

@T-Gro
Add documentation and tests that maxBy/minBy return the first max/min…
59bda26
… element
Fixes the Repo Assist workflow failure for PR #19140.
Adds documentation remarks to array.fsi, list.fsi, and seq.fsi stating
that maxBy/minBy returns the first maximal/minimal element when there
are multiple equal elements. Adds corresponding tests for Array, List,
and Seq modules.
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/c602ace4-48eb-4981-9070-8cbad6504be9
CopilotAI changed the title [WIP] Debug agentic workflow failure for Repo AssistAdd documentation and tests that maxBy/minBy return the first max/min elementMar 24, 2026
CopilotAI requested a review from T-GroMarch 24, 2026 10:41
@T-Gro
T-Gro marked this pull request as ready for review March 24, 2026 10:45
@T-Gro
T-Gro requested a review from a team as a code ownerMarch 24, 2026 10:45
@T-Gro
T-Gro requested a review from abonieMarch 24, 2026 10:45
@github-actions

github-actionsBot commented Mar 24, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@T-GroT-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Mar 24, 2026
@github-project-automationgithub-project-automationBot moved this from New to In Progress in F# Compiler and ToolingMar 26, 2026
@T-Gro
T-Gro merged commit 63294d7 into mainMar 27, 2026
60 of 61 checks passed
@github-project-automationgithub-project-automationBot moved this from In Progress to Done in F# Compiler and ToolingMar 27, 2026
@T-Gro
T-Gro deleted the copilot/aw-debug-repo-assist-failure branch March 27, 2026 15:51
This was referenced Mar 27, 2026
Merged
Merged
Merged
CopilotAI added a commit that referenced this pull request Mar 31, 2026
Add documentation and tests that maxBy/minBy return the first max/min…
aa88cab
… element (#19464)
Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
CopilotAI added a commit that referenced this pull request Mar 31, 2026
Add documentation and tests that maxBy/minBy return the first max/min…
13c6195
… element (#19464)
Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
CopilotAI added a commit that referenced this pull request Mar 31, 2026
Add documentation and tests that maxBy/minBy return the first max/min…
a7aaade
… element (#19464)
Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
This was referenced Apr 14, 2026
Closed
Closed
abonie added a commit that referenced this pull request May 7, 2026
@abonie@T-Gro
@dotnet-maestro@github-actions@majocha
Syncing release/dev18.6 with VS rel/insiders (#19699)
d291735
* Add regression test for #6750: Mutually recursive DU values initialization (#19483)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression tests for #14308 and #14310: Signature generation improvements (#19490)
Test 1 (#14310): Verify struct with private field roundtrips correctly
when signature includes the private field (as generated by --sig).
Test 2 (#14308): Verify Sealed, AbstractClass, Interface and Class
attributes roundtrip correctly in signature generation.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test for #16410: no spurious FS3570 with KeyValue active pattern (#19481)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test for #3841: Hash directive indentation in nested module (#19489)
Verify that a hash directive (#r) at column 0 inside a nested module
produces FS0058 indentation error with F# 8 strict indentation rules.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test for #14152: nowarn directive before module declaration (#19477)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test: #6929, Literal bindings preserve units of measure (#19463)
* Add regression test for #6929: Literal bindings preserve units of measure
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix: use local shouldSucceed wrapper instead of redundant pipeline
The test was calling asLibrary |> typecheck |> shouldSucceed, but the local
shouldSucceed function (which already does asLibrary/typecheck) was shadowing
FSharp.Test.Compiler.shouldSucceed, causing a type mismatch (FS0001).
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test: #3660, array of functions invocation correctness (#19479)
* Add regression test for #3660: array of functions invocation without closure allocation
- Runtime correctness test: compiles and runs the indexed array function
invocation pattern, verifying correct results
- IL verification test: compiles runAll as a library with optimizations and
asserts no closure class (extending FSharpFunc) is emitted, ensuring the
compiler does not generate needless allocations for fArr.[i] x
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Apply suggestions from code review
Co-authored-by: Adam Boniecki <20281641+abonie@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Adam Boniecki <20281641+abonie@users.noreply.github.com>
* Infra: Update gh aw (#19495)
* Fix CLIEvent properties to be recognized as events in Symbol API (#18584)
* Add regression test: #12067, signature generation preserves FSharp. prefix for external types (#19496)
Fixes#12067
Adds a regression test verifying that signature file generation preserves
the fully-qualified FSharp.Control.AsyncSeq<'t> type name when the type
comes from an external assembly in a FSharp.* namespace, rather than
incorrectly trimming the FSharp. prefix to produce Control.AsyncSeq<'t>.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test for #11331: accessibility error for internal type in public constructor sig (#19475)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test for #14216: No FS2303 warning for DU in FSI (#19465)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test for #13697: typeof in attribute should report FS0039 (#19474)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test for #9382: SRTP stress test with matrix inverse (#19469)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test: #12023, FSI can load System.Drawing.Common via nuget (#19497)
Fixes#12023
Verifies that FSI can load System.Drawing.Common via #r "nuget:" without
FS0193 assembly loading errors. The original issue was that FSI did not
probe the Microsoft.WindowsDesktop.App runtime folder.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add documentation and tests that maxBy/minBy return the first max/min element (#19464)
* Bugfix :: Fix type definition metadata: duplicate methods, event flags (#19341)
* resolve integrity issues in gh aw (#19510)
* Add Regression PR Shepherd workflow (#19500)
* Add Regression PR Shepherd agentic workflow
Shepherds open AI-Issue-Regression-PR pull requests to completion:
- Fixes CI failures and addresses review feedback
- Detects when a test proves the bug still exists (removes label, tags maintainers)
- Runs 6x/day, only touches tests/ files
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add min-integrity: none
* Add min-integrity: none
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Improve repo-assist: regression test verification, windows-only revisit, stricter labeling (#19499)
- Enable create-pull-request and push-to-pull-request-branch for regression test PRs
- Enable remove-labels for AI-thinks-issue-fixed and AI-thinks-windows-only
- Add Task 2: Regression Test Verification with adversarial dispute step
- Add Task 3: Systematic revisit of AI-thinks-windows-only claims
- Reorder tasks: Task 1 → Task 3 → Task 2 → FINAL (Task 3 feeds into Task 2)
- Strict windows-only rules with explicit FCS-testable feature list
- Fix memory section to match actual state.json schema
- Remove close-issue actions (closure happens via PR merge with Fixes link)
- Fix stale references, contradictory instructions, date cutoff to 2024
- Clarify anti-spam rules for multi-task commenting
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/arcade build 20260327.7 (#19512)
On relative base path root
Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.26168.1 -> To Version 10.0.0-beta.26177.7
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* [main] Update dependencies from dotnet/msbuild (#19493)
* Update dependencies from https://github.com/dotnet/msbuild build 20260324.4
On relative base path root
Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core From Version 18.6.0-preview-26173-02 -> To Version 18.6.0-preview-26174-04
* Update dependencies from https://github.com/dotnet/msbuild build 20260325.1
On relative base path root
Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core From Version 18.6.0-preview-26173-02 -> To Version 18.6.0-preview-26175-01
* Update dependencies from https://github.com/dotnet/msbuild build 20260326.1
On relative base path root
Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core From Version 18.6.0-preview-26173-02 -> To Version 18.6.0-preview-26176-01
* Update dependencies from https://github.com/dotnet/msbuild build 20260327.2
On relative base path root
Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core From Version 18.6.0-preview-26173-02 -> To Version 18.6.0-preview-26177-02
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Add regression test for #3532: FSharpEntity.IsByRef is false for byref`1 (#19485)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test for #15655: error codes 999 and 3217 are distinct (#19480)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test: #13519, C# optional parameters from F# (#19473)
* Add regression test for #13519: C# optional parameters from F#
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add ParamArray + optional params regression test for #13519
Addresses reviewer feedback: the original issue was specifically about
the intersection of omitted optional arguments and ParamArray arguments,
as identified by Don Syme. This adds a test covering that exact scenario.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test: #6648, DU of DUs with inline static members (#19470)
* Add regression test for #6648: DU of DUs with inline static members
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix unclosed triple-quoted string in Issue 6648 regression test
Add missing closing triple-quote and assertion pipeline to the
DU of DUs with inline static members test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix repo-assist: add safe output discipline and iteration limits (#19516)
* Initial plan
* Fix repo-assist: add safe output discipline, iteration limits, and noop fallback
Root cause: Agent spent ~37 minutes creating ~25 test files across 5+ issues
without calling any safe output MCP tools, resulting in empty agent_output.json.
- Add "Safe Output Discipline" section with incremental output, noop fallback,
3-attempt iteration limit per issue, and time awareness rules
- Task 1: call safe output tools immediately after each issue
- Task 2: limit build-and-test cycles to 3 per issue, create PRs immediately,
do not create multiple test file variants
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/cf589816-f234-44e2-9245-742907ee5d27
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
* Run gh aw upgrade and gh aw compile to regenerate lock files
Updates gh-aw from v0.64.2 to v0.64.4:
- Regenerate repo-assist.lock.yml with new frontmatter hash
- Regenerate regression-pr-shepherd.lock.yml
- Update actions-lock.json with new action SHAs
- Update agentic-workflows.agent.md version references
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/0f6b9ce7-da31-403c-b633-6bb5f004484e
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
Co-authored-by: Tomas Grosup <Tomas.Grosup@gmail.com>
Co-authored-by: Adam Boniecki <20281641+abonie@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/msbuild build 20260330.8 (#19525)
On relative base path root
Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core From Version 18.6.0-preview-26177-02 -> To Version 18.6.0-preview-26180-08
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Update dependencies from https://dev.azure.com/dnceng/internal/_git/dotnet-optimization build 20260330.1 (#19523)
On relative base path root
optimization.linux-arm64.MIBC.Runtime , optimization.linux-x64.MIBC.Runtime , optimization.windows_nt-arm64.MIBC.Runtime , optimization.windows_nt-x64.MIBC.Runtime , optimization.windows_nt-x86.MIBC.Runtime From Version 1.0.0-prerelease.26153.1 -> To Version 1.0.0-prerelease.26180.1
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* Add aw-auto-update workflow + upgrade to v0.64.4 (#19519)
* Add aw-auto-update workflow for daily gh aw upgrade/compile
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Update agentic workflows via gh aw upgrade (v0.64.2 → v0.64.4)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test for #6715: land is a valid identifier (#19478)
Verifies that land, lor, lxor, lsl, lsr, and asr can be used as valid
identifiers after the ML compatibility removal in PR #19143.
Fixes#6715
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* [main] Update dependencies from dotnet/roslyn (#19494)
* Update dependencies from https://github.com/dotnet/roslyn build 20260324.12
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.6.0-2.26173.11 -> To Version 5.6.0-2.26174.12
* Update dependencies from https://github.com/dotnet/roslyn build 20260325.12
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.6.0-2.26173.11 -> To Version 5.6.0-2.26175.12
* Update dependencies from https://github.com/dotnet/roslyn build 20260326.1
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.6.0-2.26173.11 -> To Version 5.6.0-2.26176.1
* Update dependencies from https://github.com/dotnet/roslyn build 20260327.5
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.6.0-2.26173.11 -> To Version 5.6.0-2.26177.5
* Update dependencies from https://github.com/dotnet/roslyn build 20260328.1
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.6.0-2.26173.11 -> To Version 5.6.0-2.26178.1
* Update dependencies from https://github.com/dotnet/roslyn build 20260330.1
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.6.0-2.26173.11 -> To Version 5.6.0-2.26180.1
* Update dependencies from https://github.com/dotnet/roslyn build 20260331.7
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.6.0-2.26173.11 -> To Version 5.7.0-1.26181.7
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test: #15987, SRTP overload resolution returns correct typed value (#19535)
Verifies that SRTP trait call selects the correct overload based on argument type:
float -> float overload, decimal -> decimal overload, 't -> int fallback overload.
Previously returned obj (null) instead of the expected typed value.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test: #15070, hash-load with dot-slash prefix no longer causes FS1141 (#19534)
Verifies that #load "./path/file.fsx" with a dot-slash prefix is
accepted by the parser (no FS1141 error), producing a file-not-found
error rather than the former 'Identifiers followed by ! are reserved' parse error.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test: #16056, auto property DeclarationLocation correct location (#19533)
Verifies that FSharpMemberOrFunctionOrValue.DeclarationLocation for
a property used as T().Prop points to the property name, not the get accessor.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test: #19456, nested let bang in plain let inside task CE raises FS0750 (#19531)
Fixes#19456
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test: #16007, SRTP ctor constraint no longer causes value restriction (#19529)
Fixes#16007
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test: #7177, never-matched warning with active patterns (#19528)
Fixes#7177
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Tests: prevent in-proc fsi from killing test host with "exit" (#19407)
* wip
* fix test
* use FSharpScript everywhere, remove ScriptingShims.fsx
* cleanup - this can run in parallel
* cleanup
* fix
* Add regression test: #9878, SRTP with phantom type parameter (#19467)
* Add regression test for #9878: SRTP with phantom type parameter
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix unclosed triple-quoted string in Issue 9878 regression test
Add missing closing triple-quote and assertion pipeline to the
SRTP with phantom type parameter test.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Rebase: add missing Issue 6648 test from main to resolve merge conflict
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
* Fix FS0452 for empty string pattern matching in quotations (#19532)
* Initial plan
* Fix FS0452: Handle non-null test IL pattern in quotation translator for empty string matching
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/213130f0-37c1-4efc-ab4d-e6f9b324a252
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
* Add runtime verification test for empty string pattern in quotation
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/213130f0-37c1-4efc-ab4d-e6f9b324a252
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
* Add test for empty string pattern match in quotation with outer variable
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/24c1fabb-ab83-45af-ab77-d9ca97cc8d69
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
* Fix regression-pr-shepherd: bound PR processing per run to prevent context overflow (#19526)
* Make fsharp-diagnostics skill a directive, not a suggestion (#19520)
Change wording from 'use this to get...' to 'Always invoke after
editing .fs files. Prefer this over dotnet build for iterative changes.'
The agent treats suggestions as optional but directives as requirements.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Update agentic workflows to v0.67.2 and fix merge conflict (#19556)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix Regression PR Shepherd: restrict push scope and strengthen PR selection (#19558)
* Initial plan
* Fix Regression PR Shepherd: add allowed-files restriction and strengthen instructions
Add frontmatter guardrails:
- allowed-files: restricts push-to-pull-request-branch to tests/**, vsintegration/tests/**, *.fsproj
- protected-files: fallback-to-issue for graceful failure
Strengthen agentic instructions:
- Explicit prohibition on modifying .github/ files (managed by aw-auto-update)
- Pre-push verification step: git diff --name-only check before every push
- Rebase step includes scope verification to catch unrelated files
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/b356f0ee-75da-4a9b-9517-8be6278d62ed
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
* Address review: remove *.fsproj from allowed-files, add strict PR eligibility checks
- Remove *.fsproj from allowed-files (already covered by tests/** patterns)
- Add strict eligibility filters: title must start with "Add regression test:",
PR must not be a draft, PR must originate from dotnet/fsharp (no forks)
- Add isDraft and headRepository to gh pr list JSON fields
- Add guideline: never touch draft PRs or PRs from external forks
- Recompile lock file
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/2049e905-31bd-4a7d-b2be-5e81a1a2b2ee
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
* [main] Source code updates from dotnet/dotnet (#19546)
* Backflow from https://github.com/dotnet/dotnet / 185a5cc build 308823
[[ commit created by automation ]]
* Update dependencies from build 308823
No dependency updates to commit
[[ commit created by automation ]]
* Update dependencies from build 309010
No dependency updates to commit
[[ commit created by automation ]]
* Update dependencies from build 309188
No dependency updates to commit
[[ commit created by automation ]]
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
* [main] Update dependencies from dotnet/roslyn (#19544)
* Update dependencies from https://github.com/dotnet/roslyn build 20260401.1
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26181.7 -> To Version 5.7.0-1.26201.1
* Update dependencies from https://github.com/dotnet/roslyn build 20260402.12
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26181.7 -> To Version 5.7.0-1.26202.12
* Update dependencies from https://github.com/dotnet/roslyn build 20260403.6
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26181.7 -> To Version 5.7.0-1.26203.6
* Update dependencies from https://github.com/dotnet/roslyn build 20260408.14
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26181.7 -> To Version 5.7.0-1.26208.14
* Bump FSBuildVersion to 101
FSharp.Core 11.0.100 and FSharp.Compiler.Service 43.12.100 have already been
published to NuGet, causing Check_Published_Package_Versions CI failures.
Bump FSBuildVersion from 100 to 101.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix flaky StartAsTaskCancellation test by increasing thread pool wait timeout
The test fails intermittently on loaded CI machines with 'Async body did not
start within 5 seconds' because the thread pool cannot schedule the async
computation in time. Increase the wait from 5s to 30s — this doesn't slow
down normal runs since the event is signaled almost immediately when the
thread pool picks up the work.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/roslyn build 20260409.5
On relative base path root
Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.7.0-1.26181.7 -> To Version 5.7.0-1.26209.5
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* [main] Update dependencies from dotnet/msbuild (#19543)
* Update dependencies from https://github.com/dotnet/msbuild build 20260401.1
On relative base path root
Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core From Version 18.6.0-preview-26180-08 -> To Version 18.6.0-preview-26201-01
* Update dependencies from https://github.com/dotnet/msbuild build 20260402.4
On relative base path root
Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core From Version 18.6.0-preview-26180-08 -> To Version 18.6.0
* Update dependencies from https://github.com/dotnet/msbuild build 20260408.4
On relative base path root
Microsoft.Build , Microsoft.Build.Framework , Microsoft.Build.Tasks.Core , Microsoft.Build.Utilities.Core From Version 18.6.0-preview-26180-08 -> To Version 18.6.1
* Bump FSBuildVersion to 101 to fix package version check
FSharp.Core 11.0.100 and FSharp.Compiler.Service 43.12.100 have already
been published to NuGet, causing the 'Check published package version'
CI step to fail. Bump to 101 so the versions are unpublished.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Add regression test: #16154, task CE with IQueryable filters no longer throws VerificationException (#19530)
* Add regression test: #16154, task CE with IQueryable filter no longer throws VerificationException
Fixes#16154
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix CI: scope issue 16154 regression test to NETCOREAPP only
The VerificationException from the upcast-to-obj in the task state machine
still occurs on .NET Framework due to stricter IL verification. The test
passes on .NET Core where this is handled correctly.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---------
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
* [main] Update dependencies from dotnet/arcade (#19542)
* Update dependencies from https://github.com/dotnet/arcade build 20260401.4
On relative base path root
Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.26177.7 -> To Version 10.0.0-beta.26201.4
* Update dependencies from https://github.com/dotnet/arcade build 20260408.2
On relative base path root
Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.26177.7 -> To Version 10.0.0-beta.26208.2
* Bump FSBuildVersion from 100 to 101
FSharp.Core=11.0.100 and FSharp.Compiler.Service=43.12.100 have
already been published. Bumping to 101 so the 'Check published
package version' CI jobs pass again.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Update dependencies from https://github.com/dotnet/arcade build 20260408.4
On relative base path root
Microsoft.DotNet.Arcade.Sdk From Version 10.0.0-beta.26177.7 -> To Version 10.0.0-beta.26208.4
---------
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Tomas Grosup <Tomas.Grosup@gmail.com>
* Add regression tests for #10043: backtick, @, and ! in type annotations (#19476)
Verifies that type annotations with invalid characters produce clear error messages:
- backtick: FS3563 'This is not a valid identifier'
- at sign: FS0615 'Unexpected infix operator in type expression'
- bang: FS1141 'Identifiers followed by ! are reserved for future use'
Fixes#10043
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix wrong warning 20 range in sequential expressions (#5735) (#19504)
In TcStmt, the range used for warning 20 was synExpr.Range which, for
sequential expressions (e.g. loop bodies with multiple statements),
covered the entire body. This made the squiggle highlight the whole
block instead of just the offending non-unit expression.
Added lastExprRange helper that walks the SynExpr.Sequential chain to
find the range of the last expression, so the warning now correctly
points at only the expression that produces the ignored value.
Added 4 regression tests for for-in, for-to, and while loops.
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
* Fix completion inconsistently filtering obsolete fields and events (#13512) (#19506)
* Fix completion inconsistently filtering obsolete fields and events
Add ILFieldInfoIsUnseen and EventInfoIsUnseen functions to filter obsolete
IL fields and events from completion, matching existing behavior for methods
and properties. Also update ItemIsUnseen to handle ILField and Event items.
Fixes#13693
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/1d21d452-3f55-4d56-898c-0b50980050b5
Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
* Add C# interop tests for obsolete field/event/method/property filtering
Fix issue number to #13512. Add ObsoleteMembersClass to CSharp_Analysis
with obsolete and non-obsolete members. Add 6 C# interop completion tests
verifying all obsolete member types are consistently hidden.
Agent-Logs-Url: https://github.com/dotnet/fsharp/sessions/1d21d452-3f55-4d56-898c-0b50980050b5
Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
---------
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: abonie <20281641+abonie@users.noreply.github.com>
* Map this branch to rel/insiders, set VSMinorVersion=7
---------
Co-authored-by: Tomas Grosup <Tomas.Grosup@gmail.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: T-Gro <46543583+T-Gro@users.noreply.github.com>
Co-authored-by: Tomas Grosup <tomasgrosup@microsoft.com>
Co-authored-by: Jakub Majocha <1760221+majocha@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonieabonieabonie approved these changes
+1 more reviewer
@T-GroT-GroT-Gro approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@T-GroT-Gro

Copilot code reviewCopilot

Labels

NO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[aw] Repo Assist failed

3 participants

@abonie@T-Gro