Add FS3889 diagnostic for namespace/type collision

[T-Gro]

Summary

When a namespace name collides with a type name across files in the same assembly, the compiler previously emitted FS0247 stating the partner was a module. However the partner is actually a type, so this PR introduces a new FS3888 diagnostic for that case while keeping FS0247 for namespace/module collisions.

Changes

• New diagnostic FS3888 (tastNamespaceAndTypeWithSameNameInAssembly): The namespace '%s' clashes with the type '%s'.
• TypedTreeOps.Remapping.fs: Updated match logic to detect namespace/type vs namespace/module collisions and emit the appropriate diagnostic.
• XLF translations: Updated all localization files with the new string.
• Tests: Added two component tests in NamespaceTests.fs:
  • Verifies FS3888 is emitted for namespace/type collision.
  • Verifies FS0247 is still emitted for namespace/module collision.

[github-actions]

❗ Release notes required

You can open this PR in browser to add release notes: open in github.dev

---

✅ Found changes and release notes in following paths:

Change path	Release notes path	Description
src/Compiler	docs/release-notes/.FSharp.Compiler.Service/11.0.100.md

[T-Gro]

Review Summary

The core fix in TypedTreeOps.Remapping.fs is correct and the tests are good. However, there are two issues that need to be addressed before merging.

---

🚫 Remove .executor-pid from the PR

The file .executor-pid (containing a PID number) is committed in the second commit. This is clearly a build/process artifact and should not be part of the repository. Please remove it and consider adding it to .gitignore.

---

🚫 Unrelated change in ServiceParsedInputOps.fs

The second commit (""Apply remaining changes"") adds a tryFindLastHashRLineInScript function and modifies FindNearestPointToInsertOpenDeclaration to ensure open statements are placed after #r directives in .fsx scripts. This change is completely unrelated to the FS3888 namespace/type collision diagnostic.

The PR description inaccurately states: ""ServiceParsedInputOps.fs: Updated logic to detect namespace/type vs namespace/module collisions and emit the appropriate diagnostic."" — the actual change has nothing to do with diagnostic detection.

Please either:

• Remove this change from this PR and submit it as a separate PR with its own tests, or
• At minimum, correct the PR description and add test coverage for the new open-insertion behavior.

---

✅ Core diagnostic logic is correct

The match pattern refactoring in TypedTreeOps.Remapping.fs correctly separates:

• namespace vs module → FS0247 (tastNamespaceAndModuleWithSameNameInAssembly)
• namespace vs type → FS3888 (tastNamespaceAndTypeWithSameNameInAssembly)

The pattern ordering handles all cases properly: (true, _, _, true) and (_, true, true, _) correctly catch the namespace+module cases first, leaving (true, _, _, _) and (_, true, _, _) to cover namespace+type (since namespace+namespace is already matched above).

✅ Tests look good

Both new tests in NamespaceTests.fs properly verify FS3888 for namespace/type collision and that FS0247 is still emitted for namespace/module collision.

[T-Gro]

@copilot : Remove the unrelated change in src/Compiler/Service/ServiceParsedInputOps.fs

[Copilot]

@copilot : Remove the unrelated change in src/Compiler/Service/ServiceParsedInputOps.fs

Done. Reverted src/Compiler/Service/ServiceParsedInputOps.fs to its original state and removed the associated release note entry. See commit Remove unrelated ServiceParsedInputOps.fs change and its release note.

[T-Gro]

/azp run fsharp-ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[T-Gro]

/azp run fsharp-ci

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[T-Gro]

@abonie :

I am sorry, you have to approve again:
"Waiting on 1 reapproval from someone other than the last pusher. Review from abonie is stale because it was submitted before the most recent code changes."