Skip to content

Fix ParallelCompilation property passing - #19945

Merged
T-Gro merged 4 commits into
dotnet:mainfrom
majocha:fix-parallelcompilation-prop
Jun 16, 2026
Merged

Fix ParallelCompilation property passing#19945
T-Gro merged 4 commits into
dotnet:mainfrom
majocha:fix-parallelcompilation-prop

Conversation

@majocha

@majochamajocha commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

Fixes#19935

@majocha
majocha requested a review from a team as a code ownerJune 13, 2026 17:25
@github-actions

github-actionsBot commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

✅ No release notes required

@majocha

majocha commented Jun 13, 2026

Copy link
Copy Markdown
ContributorAuthor

It looks that unlike Roslyn, we don't have dedicated integration tests around Fsc MSBuild task, letting bugs like this one slip through sometimes.

@github-actionsgithub-actionsBot added the ⚠️ Affects-Build-Infra Tooling check: PR touches build infrastructure label Jun 13, 2026
@github-actions

This comment has been minimized.

Sign in to view
@majocha

majocha commented Jun 13, 2026

Copy link
Copy Markdown
ContributorAuthor

The problem is --parallelcompilation will trigger FS0075. This will break projects with warnings as errors.

majocha
majocha commented Jun 14, 2026
View reviewed changes
Comment threadsrc/FSharp.Build/Microsoft.FSharp.NetSdk.props
@github-actionsgithub-actionsBot added the ⚠️ Affects-Test-Tooling Tooling check: PR touches test framework infrastructure label Jun 15, 2026
@github-actions

github-actionsBot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

🔍 Tooling Safety Check — Affects-Build-Infra, Affects-Test-Tooling
Affects-Build-Infra: modifies Microsoft.FSharp.NetSdk.props and .Targets
Affects-Test-Tooling: adds FSharpTargetsShim/FSharpPropsShim to tests/AheadOfTime/Directory.Build.props

Generated by PR Tooling Safety Check · opus46 3.3M · ◷

@github-project-automationgithub-project-automationBot moved this from New to In Progress in F# Compiler and ToolingJun 16, 2026
@T-Gro

T-Gro commented Jun 16, 2026

Copy link
Copy Markdown
Member

@majocha :

https://github.com/dotnet/fsharp/tree/main/tests/fsharp/SDKTests/tests is something like "unit tests" for individual pieces of logic contained within our msbuild artifacts.

@T-Gro
T-Gro merged commit 822e804 into dotnet:mainJun 16, 2026
50 checks passed
This was referenced Jun 16, 2026
Merged
Merged
@dotnet-botdotnet-bot mentioned this pull request Jun 22, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@T-GroT-GroT-Gro approved these changes

Assignees

No one assigned

Labels

⚠️ Affects-Build-InfraTooling check: PR touches build infrastructure⚠️ Affects-Test-ToolingTooling check: PR touches test framework infrastructure

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

$(ParallelCompilation) never reaches the Fsc task — targets pass the item @(ParallelCompilation) instead of the property

2 participants

@majocha@T-Gro