Uh oh!
There was an error while loading. Please reload this page.
Fix F# semantic classification for delegates, slices, CEs, open type - #19960
Merged
Conversation
Contributor
❗ Release notes requiredYou can open this PR in browser to add release notes: open in github.dev
|
T-Gro pushed a commit
to T-Gro/fsharp
that referenced
this pull request
Jun 16, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro pushed a commit
that referenced
this pull request
Jun 17, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Groforce-pushed
the
fix/issue-19905
branch
2 times, most recently
from
June 18, 2026 12:25
4c44aad to
1637561Compare…5/7) Items 1/2/5/7 are completion-safe and shipped here: - item 1: suppress the synthesized delegate Invoke value over the `delegate of ...` RHS - item 2: classify CE builders inside list/array comprehensions as ComputationExpression - item 5: don't paint slice brackets as Method; fix open-ended slice upper-bound range - item 7: `open type T` is not unused when its static members/fields or DU cases are used Items 3/4/6 (generic `<...>` argument colorization) are deferred: narrowing the shared name-resolution range to fix colorization breaks find-all-references, completion and parameter-info, because the resolution sink matches symbol uses by exact range end. The correct fix requires separating classification ranges from symbol-use ranges in the sink. Guard tests assert the IDE features still work. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
abonie
commented
Jun 25, 2026
Member
@copilot resolve the merge conflicts in this pull request |
abonie
approved these changes
Jun 25, 2026
T-Gro
commented
Jun 30, 2026
T-Gro
left a comment
MemberAuthor
There was a problem hiding this comment.
🤖 This review was generated by AI (@expert-reviewer agent). Findings may contain inaccuracies — please verify independently.
Nice, well-targeted set of fixes with thorough regression tests. The range1 → range2 change in ExpandIndexArgs correctly attaches the synthesized None of an open-ended slice's upper bound to the upper-bound range. A few suppression heuristics look slightly broader than the bugs they target — flagged inline for verification (all editor-classification only, low severity).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Responds to the expert-reviewer feedback on the editor semantic-classification fixes: - GetSlice/SetSlice suppression: document why the synthesized indexer (xs[a..]) cannot be distinguished from an explicit .GetSlice(..) call in this pass (no source text; both Item.MethodGroup resolutions cover the receiver). The broad suppression is an intentional trade-off. - open type unused-detection: clarify that recording static-member/static-field uses against the declaring entity mirrors existing open <module> behavior, and add a regression test asserting open type and open <module> behave consistently when their members are only ever used fully qualified. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
abonie
approved these changes
Jun 30, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #19905. Four F# editor semantic-classification errors:
delegate of …signature as a method.ComputationExpression.]of an open-ended slice (xs[0..]) is no longer classified asFunction/Method.open type Tis no longer reported as unused when its static members, static fields, or DU cases are used.The generic-argument colorization items (
Type<int>.Member, generic constructor/method calls) are deferred: narrowing the shared name-resolution range to fix coloring breaks find-all-references, completion, and parameter-info.