Skip to content

Don't regenerate xlf files in source-only builds - #19968

Merged
T-Gro merged 1 commit into
dotnet:mainfrom
T-Gro:fix/xlf-msbuild-error
Jun 24, 2026
Merged

Don't regenerate xlf files in source-only builds#19968
T-Gro merged 1 commit into
dotnet:mainfrom
T-Gro:fix/xlf-msbuild-error

Conversation

@T-Gro

@T-GroT-Gro commented Jun 18, 2026

Copy link
Copy Markdown
Member

Fixes#19961

Non-CI source-only builds default UpdateXlfOnBuild to true, then fail with
"The target UpdateXlf does not exist" when XliffTasks isn't imported for an
inner target framework. Source builds use the checked-in xlf.

@T-Gro
Don't regenerate xlf files in source-only builds
d7e3b55
Non-CI source-only builds default UpdateXlfOnBuild to true, then fail with
"The target UpdateXlf does not exist" when XliffTasks isn't imported for an
inner target framework. Source builds use the checked-in xlf.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-Gro
T-Gro requested a review from a team as a code ownerJune 18, 2026 09:12
@T-GroT-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Jun 18, 2026
@github-actions

github-actionsBot commented Jun 18, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

@github-actionsgithub-actionsBot added the ⚠️ Affects-Build-Infra Tooling check: PR touches build infrastructure label Jun 18, 2026
@github-actions

github-actionsBot commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

🔍 Tooling Safety Check — Affects-Build-Infra
Affects-Build-Infra: modifies FSharpBuild.Directory.Build.targets (MSBuild property)

Generated by PR Tooling Safety Check · opus46 3.7M · ◷

@T-Gro
T-Gro requested a review from abonieJune 18, 2026 10:39
@T-Gro
T-Gro enabled auto-merge (squash) June 18, 2026 10:39
@T-Gro
T-Gro merged commit 188a8b0 into dotnet:mainJun 24, 2026
58 checks passed
@github-project-automationgithub-project-automationBot moved this from New to In Progress in F# Compiler and ToolingJun 24, 2026
This was referenced Jun 24, 2026
Merged
Merged
Merged
@T-Gro
T-Gro deleted the fix/xlf-msbuild-error branch June 25, 2026 14:19
@dotnet-botdotnet-bot mentioned this pull request Jun 26, 2026
Closed
@ViktorHofer

ViktorHofer commented Aug 12, 2026

Copy link
Copy Markdown
Member

@T-Gro someone on our team also hit this. Do you still have a binlog hanging around somewhere that demonstrated the problem? Happy to actually diagnose this.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonieabonieabonie approved these changes

Assignees

No one assigned

Labels

⚠️ Affects-Build-InfraTooling check: PR touches build infrastructureNO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

FSharp.Core.fsproj : error MSB4057: The target "UpdateXlf" does not exist in the project.

3 participants

@T-Gro@ViktorHofer@abonie