Uh oh!
There was an error while loading. Please reload this page.
Add computation-expression tests for warning 20 range - #19992
Merged
Conversation
…19896) Answers @auduchinok's open question on PR #19896: in a computation expression the loop body is desugared per-statement, so the trailing expression reaches TcStmt on its own and warning 20 highlights only the offending expression (e.g. 'x'), same as the non-CE case. - async CE: asserts the squiggle lands on 'x' alone (Line 6, Col 13-14). - seq CE: trailing non-unit value is an implicit yield, so no warning 20. The CE test originally requested in review was removed in 0127569; this reinstates a genuine CE case plus the seq implicit-yield contrast. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
|
T-Gro
enabled auto-merge (squash)
June 25, 2026 13:53
T-Gro
commented
Jun 30, 2026
T-Gro
left a comment
MemberAuthor
There was a problem hiding this comment.
🤖 This review was generated by AI (@expert-reviewer agent). Findings may contain inaccuracies — please verify independently.
Test-only PR adding two computation-expression cases for the warning 20 range fix (#19896). Reviewed for correctness:
- The
asynctest asserts the warning highlights only the trailing offending expression (Line 6, Col 13-14), matching the per-statement desugaring of CE loop bodies throughTcStmt. - The
seqtest usestypecheck |> shouldSucceed. This is a meaningful assertion (not a no-op): the test harness treats warnings as failures by default (IgnoreWarnings = false, Compiler.fs ~L1046), soshouldSucceedgenuinely guarantees no warning 20 is emitted for the implicit-yield case.
No production code is touched; no correctness, security, or performance concerns. Optional: the description mentions task behaving like async, but only async is covered — a task case would round out the matrix, though it is not required.
abonie
approved these changes
Jul 1, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test-only follow-up to #19896, adding the computation-expression coverage requested in review.
Inside a CE the loop body is desugared per-statement, so the trailing expression reaches
TcStmton its own and warning 20 highlights only the offending expression.async/taskwarn on the value alone;seqtreats it as an implicit yield, so it doesn't warn at all.