Uh oh!
There was an error while loading. Please reload this page.
[main] Update dependencies from dotnet/roslyn - #20100
Merged
Merged
Conversation
…729.11 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.10.0-1.26365.3 -> To Version 5.11.0-1.26379.11
Contributor
✅ No release notes required |
…730.4 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.10.0-1.26365.3 -> To Version 5.11.0-1.26380.4
…731.6 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.10.0-1.26365.3 -> To Version 5.11.0-1.26381.6
…731.12 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.10.0-1.26365.3 -> To Version 5.11.0-1.26381.12
Roslyn 5.11.0-1.26381.12 pulls newer transitive versions of Microsoft.ServiceHub.Framework (4.10.147), Microsoft.VisualStudio.RpcContracts (18.9.918), StreamJsonRpc (2.26.10) and Microsoft.VisualStudio.Threading (18.7.23) than the versions pinned in eng/Versions.props, causing NU1605 package-downgrade errors across the vsintegration projects. Bump the pins to match. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…9b-4ac3-b408-09a00dcbc473
…803.5 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.ExternalAccess.FSharp , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices From Version 5.10.0-1.26365.3 -> To Version 5.11.0-1.26403.5
…ix NU1902/NU1903 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…xt.* pulled by Roslyn 5.11 Roslyn 5.11 transitively bumps Microsoft.VisualStudio.Text.* / .Editor from 18.9.123 to 18.9.179. VSEditor stayed pinned at 18.9.123, whose implementation references IRtfBuilderServiceInternal (removed in Text.UI 18.9.179), so the VsMocks MEF catalog GetTypes() threw ReflectionTypeLoadException and all legacy VS unit tests failed. Bump VSEditor to the matching 18.9.179. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…in FCS host) The test asserts #r "System" resolves specifically to the reference-assemblies folder, but name-based reference resolution in the FCS test host is non-deterministic and intermittently returns an empty tooltip - the same reason Fsx.HashR_QuickInfo.ResolveFromGAC is already skipped. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
… non-strict mode removal with Roslyn 5.11 dependency updates) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…#19993) into darc-main-bd030f95 Resolve eng/Versions.props conflict by adopting origin/main's Central Package Management structure (VS package versions live in eng/Packages.props). Bump the four VS pins Roslyn 5.11.0 requires higher than main's 5.10.0 baseline: Microsoft.VisualStudio.Threading 18.7.23, Microsoft.VisualStudio.RpcContracts 18.9.918, Microsoft.ServiceHub.Framework 4.10.147, StreamJsonRpc 2.26.10, and raise the shared editor pin VisualStudioEditorPackagesVersion to 18.9.179 (Roslyn 5.11.0 pulls the VS editor packages transitively at 18.9.179 -> NU1109 otherwise). Take origin/main's CPM form of Framework.Proxy.csproj (drop redundant Version-bearing PackageReferences superseded by central pins). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
T-Gro
approved these changes
Aug 5, 2026
T-Gro
enabled auto-merge (squash)
August 5, 2026 08:15
…807.4 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices , Microsoft.VisualStudio.LanguageServices.ExternalAccess From Version 5.10.0-1.26365.3 -> To Version 5.11.0-1.26407.4
Roslyn 5.11 (Microsoft.CodeAnalysis.Workspaces.Common 5.11.0) pulls System.Composition transitively at >= 10.0.10, but it was centrally pinned to the darc-flowed 10.0.8, causing NU1109 package-downgrade restore failures across all CI jobs. Extend the existing dotnet/runtime central-version floor mechanism to cover System.Composition and raise the shared floor to 10.0.10 (still satisfies MSBuild's >= 10.0.9). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…9b-4ac3-b408-09a00dcbc473
… for Roslyn 5.11 The vsintegration projects (FSharp.Editor + tests, in VisualFSharp.slnx, Windows-only jobs) failed restore with NU1109 because Roslyn 5.11 (Microsoft.CodeAnalysis.EditorFeatures / .LanguageServices.ExternalAccess) pulls System.Diagnostics.DiagnosticSource transitively at >= 10.0.10, but it was centrally pinned to the darc-flowed 10.0.8. Extend the existing dotnet/runtime central-version floor to cover System.Diagnostics.DiagnosticSource, mirroring the System.Composition fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…9b-4ac3-b408-09a00dcbc473
… them ServiceHub.Framework, RpcContracts and StreamJsonRpc were centrally pinned (and directly referenced in vsintegration) only to mirror the versions Roslyn's IDE packages already require transitively. A stale pin is exactly what trips NU1109/NU1605 on each Roslyn bump, so the pins created the very maintenance they were meant to avoid. Drop the three central PackageVersion pins and the vsintegration direct refs so these packages flow in from Roslyn's closure (still resolves to 4.10.147 / 18.9.918 / 2.26.10). The net8 LSP host is StreamJsonRpc's only non-Roslyn consumer, so it keeps its exact current version via VersionOverride. Restore is green with zero NU warnings across FSharp.Editor, FSharp.LanguageService, the LSP host and the CLASP proxy; resolved versions are unchanged. MSB3277 (the Windows-only VSIX assembly-unification check the direct refs also guarded) still needs CI confirmation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
…815.2 On relative base path root Microsoft.CodeAnalysis , Microsoft.CodeAnalysis.Compilers , Microsoft.CodeAnalysis.CSharp , Microsoft.CodeAnalysis.EditorFeatures , Microsoft.CodeAnalysis.EditorFeatures.Text , Microsoft.CodeAnalysis.Features , Microsoft.VisualStudio.LanguageServices , Microsoft.VisualStudio.LanguageServices.ExternalAccess From Version 5.10.0-1.26365.3 -> To Version 5.11.0-1.26415.2
Tighten the CPM/transitive-pinning explanatory comments added while de-churning Roslyn's VS-host transitive pins, keeping the essential rationale but making the overall PR diff net-negative. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
The FCS-test-host tooltip flake this skipped is unrelated to the Roslyn bump. Reverted so it isn't hidden inside a dependency update; tracked in #20276. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
abonie
approved these changes
Aug 18, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 18, 2026
dotnet-maestroBot
deleted the
darc-main-bd030f95-309b-4ac3-b408-09a00dcbc473
branch
August 24, 2026 05:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps Roslyn from 5.10.0-1.26365.3 to 5.11.0-1.26415.2, and stops hand-pinning the VS-host packages that Roslyn's IDE closure already forces transitively — so most future maestro bumps need no manual follow-up.
5.10.0-1.26365.3→5.11.0-1.26415.24.10.128→4.10.14718.9.453→18.9.918VersionOverride2.26.5→2.26.1018.7.19→18.7.2318.9.123→18.9.17910.0.9→10.0.10VS.Threading and the editor packages stay hand-managed because
FSharp.Editorhides its Roslyn references behindPrivateAssets="all", so net472 consumers compile against them directly instead of receiving them transitively.