Skip to content

Remove always-on StructActivePattern language feature flag - #20208

Merged
T-Gro merged 4 commits into
mainfrom
fix/issue-20161
Aug 6, 2026
Merged

Remove always-on StructActivePattern language feature flag#20208
T-Gro merged 4 commits into
mainfrom
fix/issue-20161

Conversation

@T-Gro

@T-GroT-Gro commented Aug 5, 2026

Copy link
Copy Markdown
Member

Fixes#20161

LanguageFeature.StructActivePattern has been enabled for every selectable --langversion since F# 6.0, so its flag could never be turned off. Removed the dead flag and collapsed the guarded active-pattern check to its enabled behaviour. As a result, --disableLanguageFeature:StructActivePattern is no longer a recognised feature name.

Remove always-on StructActivePattern language feature flag (#20161)
ade48a1
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-Gro
T-Gro requested a review from a team as a code ownerAugust 5, 2026 08:53
@github-actions

github-actionsBot commented Aug 5, 2026•
edited
Loading

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

Copilotand others added 2 commits August 5, 2026 10:54
Add release notes for#20208
7bf5b31
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Drop release notes: cleanup-only PR
2b67776
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@T-GroT-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 5, 2026
@github-actionsgithub-actionsBot added the AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed label Aug 5, 2026
Merge remote-tracking branch 'origin/main' into fix/issue-20161
2f57af3
# Conflicts:
#	src/Compiler/Facilities/LanguageFeatures.fs
#	src/Compiler/Facilities/LanguageFeatures.fsi
@T-Gro
T-Gro requested a review from abonieAugust 6, 2026 11:34
@T-Gro
T-Gro enabled auto-merge (squash) August 6, 2026 11:34
@github-project-automationgithub-project-automationBot moved this from New to In Progress in F# Compiler and ToolingAug 6, 2026
@T-Gro
T-Gro merged commit 2def18d into mainAug 6, 2026
48 checks passed
@github-project-automationgithub-project-automationBot moved this from In Progress to Done in F# Compiler and ToolingAug 6, 2026
bartelink pushed a commit to bartelink/fsharp that referenced this pull request Aug 6, 2026
@T-Gro@bartelink
Remove always-on StructActivePattern language feature flag (dotnet#20208
f8d194e
)
@dotnet-maestrodotnet-maestroBot mentioned this pull request Aug 7, 2026
Closed
@T-Gro
T-Gro requested a review from abonieAugust 10, 2026 08:45
@dotnet-maestrodotnet-maestroBot mentioned this pull request Aug 10, 2026
Merged
@dotnet-botdotnet-bot mentioned this pull request Aug 18, 2026
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abonieabonieAwaiting requested review from abonie

Assignees

No one assigned

Labels

AI-Tooling-Check-BypassedTooling check: non-fork PR, not diff-analyzedNO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

F# Compiler and Tooling
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove always-on language feature flag: StructActivePattern

3 participants

@T-Gro@abonie