Skip to content

Remove always-on OpenTypeDeclaration language feature flag - #20209

Merged
T-Gro merged 4 commits into
dotnet:mainfrom
T-Gro:fix/issue-20148
Aug 6, 2026
Merged

Remove always-on OpenTypeDeclaration language feature flag#20209
T-Gro merged 4 commits into
dotnet:mainfrom
T-Gro:fix/issue-20148

Conversation

@T-Gro

@T-GroT-Gro commented Aug 5, 2026

Copy link
Copy Markdown
Member

Fixes#20148

LanguageFeature.OpenTypeDeclaration has been on for every selectable --langversion since F# 5.0 and can never be turned off, so the flag was dead configuration. This removes the flag and collapses the guarded code to its enabled behaviour. As a consequence, --disableLanguageFeature:OpenTypeDeclaration is no longer a recognised feature name.

)
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@github-actions

github-actionsBot commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@T-GroT-Gro added NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes AI-Tooling-Check-Bypassed Tooling check: non-fork PR, not diff-analyzed labels Aug 5, 2026
@github-actionsgithub-actionsBot added the AI-Tooling-Check-Scanned-Clean Tooling check: diff analyzed, no interesting infrastructure files label Aug 5, 2026
@T-GroT-Gro removed the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 5, 2026
@T-GroT-Gro added the NO_RELEASE_NOTES Label for pull requests which signals, that user opted-out of providing release notes label Aug 6, 2026
@T-Gro
T-Gro requested a review from abonieAugust 6, 2026 11:35
@T-Gro
T-Gro enabled auto-merge (squash) August 6, 2026 11:35
@github-project-automationgithub-project-automationBot moved this from New to In Progress in F# Compiler and ToolingAug 6, 2026
@T-Gro
T-Gro merged commit e1ad05c into dotnet:mainAug 6, 2026
48 of 49 checks passed
@github-project-automationgithub-project-automationBot moved this from In Progress to Done in F# Compiler and ToolingAug 6, 2026
bartelink pushed a commit to bartelink/fsharp that referenced this pull request Aug 6, 2026
@T-Gro
T-Gro requested a review from abonieAugust 10, 2026 08:45
LanguageFeature.AndBang, languageVersion50
LanguageFeature.NullableOptionalInterop, languageVersion50
LanguageFeature.DefaultInterfaceMemberConsumption, languageVersion50
LanguageFeature.OpenTypeDeclaration, languageVersion50

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we keep a document with these features somewhere? Maybe we could keep them here as a reference?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI-Tooling-Check-BypassedTooling check: non-fork PR, not diff-analyzedAI-Tooling-Check-Scanned-CleanTooling check: diff analyzed, no interesting infrastructure filesNO_RELEASE_NOTESLabel for pull requests which signals, that user opted-out of providing release notes

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Remove always-on language feature flag: OpenTypeDeclaration

4 participants

@T-Gro@auduchinok@abonie