Uh oh!
There was an error while loading. Please reload this page.
WIP: Deduplicate FSharp.Core XML docs via <include> - #20231
Merged
Conversation
Contributor
|
T-Gro added a commit
that referenced
this pull request
Aug 7, 2026
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
T-Groforce-pushed
the
t-gro-fsharpcore-xmldoc-include-dedup
branch
from
August 7, 2026 11:51
bfddcc7 to
2ad440dCompareCo-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
T-Groforce-pushed
the
t-gro-fsharpcore-xmldoc-include-dedup
branch
from
August 7, 2026 12:07
2ad440d to
adff9a8CompareT-Gro
marked this pull request as ready for review
August 7, 2026 12:07
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
T-Groforce-pushed
the
t-gro-fsharpcore-xmldoc-include-dedup
branch
from
August 12, 2026 08:11
1da1e28 to
16d621fCompareabonie
reviewed
Aug 12, 2026
Uh oh!
There was an error while loading. Please reload this page.
abonie
approved these changes
Aug 12, 2026
… inputs Addresses review feedback: the <include> XML doc fragments are now referenced in the project (None + UpToDateCheckInput) so they are tracked as compilation inputs for incremental builds and the up-to-date check. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
abonie
approved these changes
Aug 17, 2026
T-Gro
enabled auto-merge (squash)
August 20, 2026 11:04
abonie
approved these changes
Aug 20, 2026
Uh oh!
There was an error while loading. Please reload this page.
xperiandri pushed a commit
to xperiandri/fsharp
that referenced
this pull request
Aug 20, 2026
* Deduplicate FSharp.Core XML docs via <include> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add test asserting no unexpanded <include> in generated FSharp.Core.xml Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Reference xmldoc/*.xml fragments in FSharp.Core.fsproj as compilation inputs Addresses review feedback: the <include> XML doc fragments are now referenced in the project (None + UpToDateCheckInput) so they are tracked as compilation inputs for incremental builds and the up-to-date check. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Tomas Grosup <tomas.grosup@microsoft.com>
xperiandri pushed a commit
to xperiandri/fsharp
that referenced
this pull request
Aug 20, 2026
* Deduplicate FSharp.Core XML docs via <include> Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Add test asserting no unexpanded <include> in generated FSharp.Core.xml Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> * Reference xmldoc/*.xml fragments in FSharp.Core.fsproj as compilation inputs Addresses review feedback: the <include> XML doc fragments are now referenced in the project (None + UpToDateCheckInput) so they are tracked as compilation inputs for incremental builds and the up-to-date check. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Co-authored-by: Copilot <copilot@github.com> Co-authored-by: Tomas Grosup <tomas.grosup@microsoft.com>
This was referenced Aug 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #19186 (FS-1341): first in-repo use of the compile-time
<include>tag inside FSharp.Core.Moves 8 repeated
///doc blocks (36 call sites) into shared fragments undersrc/FSharp.Core/xmldoc/and replaces each occurrence with a one-line<include>:Parallel.Forremark — array (5 identical sites; the genuinely different ones are left alone)Layout: per-topic files (
sort.xml,parallel.xml,dynamic.xml) with element-name keys; callsite readspath="/sort/arrayUnstable/*".Generated
FSharp.Core.xmlis unchanged apart from insignificant whitespace — verified canonically identical to the pre-change baseline. No documentation wording changes.WIP: draft while CI is validated.