chore(Async.RunSynchronouslyImmediate): Stragglers re #19804

[bartelink]

Followups to fsharp/fslang-suggestions#1042 (from fsharp/fslang-suggestions#1042) via #19844 (comment)

• rename and sync clone impls within VisualFSharp.slnx as per previous PR
• update internal helper RunImmediateExceptOnUI to delegate to RSI and follow naming

Checklist

• Release notes entry updated (PR ref added to existing changelog entry for FSharp.CompilerService

[github-actions]

⚠️ Release notes required, but author opted out

Warning

Author opted out of release notes, check is disabled for this pull request.
cc @dotnet/fsharp-team-msft

[bartelink]

@T-Gro want me to propagate that changelog entry to VS release notes like the comment says?

[Copilot]

Pull request overview

This PR finishes the Async.RunImmediate → Async.RunSynchronouslyImmediate rename across VS integration code/tests and updates helper APIs to match the new naming and behavior (notably exception unwrapping).

Changes:

• Replace remaining Async.RunImmediate usages in VS integration and Salsa tests with Async.RunSynchronouslyImmediate.
• Rename RunImmediateExceptOnUI to RunSynchronouslyImmediateExceptOnUI and delegate to Async.RunSynchronouslyImmediate.
• Update benchmarks/source payloads and release notes to reflect the rename.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
vsintegration/tests/Salsa/salsa.fs	Rename call sites to Async.RunSynchronouslyImmediate.
vsintegration/tests/Salsa/FSharpLanguageServiceTestable.fs	Rename NotifyProjectCleaned call site to Async.RunSynchronouslyImmediate.
vsintegration/tests/FSharp.Editor.Tests/BraceMatchingServiceTests.fs	Update tests to use RunSynchronouslyImmediateExceptOnUI.
vsintegration/src/FSharp.LanguageService/LanguageServiceConstants.fs	Introduces a shim for RunSynchronouslyImmediate (currently problematic).
vsintegration/src/FSharp.LanguageService/FSharpSource.fs	Rename parse call site to Async.RunSynchronouslyImmediate.
vsintegration/src/FSharp.LanguageService/BackgroundRequests.fs	Rename various checker call sites to Async.RunSynchronouslyImmediate.
vsintegration/src/FSharp.Editor/Common/Extensions.fs	Rename helper and delegate to Async.RunSynchronouslyImmediate off-UI thread.
tests/benchmarks/FCSBenchmarks/CompilerServiceBenchmarks/SomethingToCompileSmaller.fs	Updates embedded source; currently introduces a syntax error + duplicate member.
tests/benchmarks/FCSBenchmarks/CompilerServiceBenchmarks/SomethingToCompile.fs	Updates embedded source; currently defines a duplicate member.
docs/release-notes/.FSharp.Compiler.Service/11.0.100.md	Adds PR reference to existing entry (minor formatting issue).

---

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.