Uh oh!
There was an error while loading. Please reload this page.
Add Chiron to the compiler regression-test matrix - #20281
Merged
Conversation
Contributor
✅ No release notes required |
T-Groforce-pushed
the
t-gro-add-chiron-regression-test
branch
2 times, most recently
from
August 18, 2026 12:27
fe8fb80 to
ed61be9Compareabonie
approved these changes
Aug 18, 2026
Chiron's chiron-6 branch serializes through Aether 8.2.0's `inline` SRTP optics, which reproduces the SDK 10.0.400 legacy cross-assembly inline-metadata regression (#20253, fixed by #20260). The bug is runtime-only: a compiler that misreads Aether's legacy pickled inline flag drops the inline body and emits a call to the dynamic-invocation stub, so the build stays clean but System.NotSupportedException is thrown at run time. The matrix entry therefore runs Chiron's own xunit suite, filtered to the Aether Optic get/set/map tests that exercise the miscompiled path; a build-only check would pass despite the bug. Two sed edits only retarget dead frameworks (the library's net452 leg cannot restore on a current SDK; the test project targets the removed netcoreapp2.0) and change no test logic. Verified: the Optic tests fail with NotSupportedException on SDK 10.0.400, and all pass with the compiler built from main. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
T-Groforce-pushed
the
t-gro-add-chiron-regression-test
branch
from
August 18, 2026 12:54
ed61be9 to
e733a98Compareabonie
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Chiron to the compiler regression-test matrix. Chiron's chiron-6 branch serializes through Aether 8.2.0's
inlineSRTP optics, reproducing the runtime-only SDK 10.0.400 regression (#20253, fixed by #20260): a compiler that misreads the legacy pickledinlineflag drops the inline body and calls the dynamic-invocation stub, so the build stays clean butSystem.NotSupportedExceptionis thrown at run time. A build-only check would pass, so the entry runs Chiron's own xunit suite, filtered to the AetherOptictests that hit the miscompiled path.Runs on the default Windows image as a single
dotnet test— no source edits.AssetTargetFallback=net461lets Chiron's old net452 leg restore, andRollForward=Majorruns its netcoreapp2.0 tests on a current runtime.Verified locally: the
Optictests fail with 4 ×System.NotSupportedExceptionon the SDK 10.0.400 compiler, and all 6 pass with the compiler built from this branch.@panesofglass — is this OK with you? We'll be testing Chiron's build on every compiler PR, as we caused a regression in the 10.0.400 SDK.