Uh oh!
There was an error while loading. Please reload this page.
Backport #20210: switch fsi restore tests to FsCheck - #20282
Merged
abonie merged 3 commits intoAug 19, 2026
Conversation
* Bump Newtonsoft version restored in fsi tests * Switch from Newtonsoft to FsCheck for #r test * Make FSI nuget-restore tests robust to central package management The two FsiCliTests that exercise `#r "nuget:"` restore hardcoded Newtonsoft.Json 13.0.3. After central package management with transitive pinning was enabled, only the centrally-pinned version is restored into the offline cache used by the internal signed build, so requesting 13.0.3 failed there (version-resolution NUxxxx diagnostics on stdout). Instead of hardcoding a version (which would silently drift on every central bump), bake the centrally-pinned version into the test assembly via AssemblyMetadata and read it at runtime. Switch the target package from Newtonsoft.Json (a removal candidate) to MessagePack, which is actively maintained, published on public nuget.org (so online public CI restore works) and centrally pinned + restored transitively by the product (so it is present in the internal offline cache). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: df9d1550-25ab-4466-ae43-8c7f106f4e49 --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: df9d1550-25ab-4466-ae43-8c7f106f4e49
* Switch to FsCheck for fsi restore tests MessagePack has dependencies on net472 that are not cached on signed builds. FsCheck depends on FSharp.Core, but that should be cached. * Add logging in case of failed test
Contributor
|
10.1.400 is already published on nuget.org, so Check_Published_Package_Versions FSCore fails. Bump FSBuildVersion 400->401. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7d778863-b4d5-4e3d-95ba-980fd2eafc81
abonie
approved these changes
Aug 19, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #20210 (and its prerequisite #20205) to release/10.0.4xx.
The FSI
#r "nuget:"restore tests must restore offline-clean on the internal signed build. FsCheck is centrally pinned and its only dependency (FSharp.Core) is already cached via FSharp.Core.UnitTests, so its closure restores offline on both net472 and .NET Core — unlike MessagePack (uncached net472 deps) and the previous hardcoded Newtonsoft.Json version.