Uh oh!
There was an error while loading. Please reload this page.
Retarget the NativeAOT test to net10 to dogfood the net10 FSharp.Core - #20284
Merged
Conversation
Retarget the NativeAOT AheadOfTime test from net9.0 to net10.0 so a real app restores, native-AOT-publishes and runs against the packed net10 FSharp.Core asset (a net9 consumer resolves lib/netstandard2.1 by nearest-TFM, so it never exercised the new net10 asset). Assert in check.ps1 that the net10.0 consumer actually selects lib/net10.0/FSharp.Core.dll, parsing the resolved compile/runtime asset under project.assets.json 'targets' (the 'libraries' manifest lists every lib folder, so a plain substring match would false-pass on a ns2.1 fallback). Verified red/green locally. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 8f25b087-cec7-4d86-a31a-f1f6f00ccf1a
Contributor
✅ No release notes required |
abonie
reviewed
Aug 18, 2026
Uh oh!
There was an error while loading. Please reload this page.
abonie
approved these changes
Aug 18, 2026
The dogfood guard merged compile+runtime asset keys and passed if net10
appeared in either. FSharp.Core packs only lib/{tfm} (no ref/, no
runtimes/), so compile and runtime always resolve the same folder and
can't diverge - but assert both explicitly so the check is correct on
its own terms rather than by relying on the package layout.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 8f25b087-cec7-4d86-a31a-f1f6f00ccf1aT-Gro
enabled auto-merge (squash)
August 19, 2026 10:46
abonie
approved these changes
Aug 19, 2026
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#20229 shipped FSharp.Core with a net10.0 asset, but no in-repo consumer targeted net10, so every test resolved
lib/netstandard2.1by nearest-TFM and the new asset went unexercised. Retargeting the NativeAOT test to net10.0 makes a real app restore, native-AOT-publish and run againstlib/net10.0/FSharp.Core.dll.The check asserts on the selected compile/runtime asset in
project.assets.json, so it fails loudly if a net10 consumer ever silently falls back to a lower asset (the package manifest lists everylibfolder, which a plain substring match would not catch).