Uh oh!
There was an error while loading. Please reload this page.
Restore source-build overridable prop names for runtime packages - #20290
Merged
Conversation
The CPM central pins for the MSBuild/Roslyn-pulled dotnet/runtime packages (System.Collections.Immutable, System.Reflection.Metadata, System.Composition, System.Diagnostics.DiagnosticSource, System.Security.Cryptography.Xml) were routed through intermediate ...CentralVersion properties with a 10.0.10 floor. Source-build injects live runtime versions by overriding $(System*Version) (via PackageVersions.fsharp.props), but the renamed ...CentralVersion pins were frozen before that override and could not be set by source-build, so the floor forced 10.0.10 while source-build provided 10.0.9 -> prebuilt + downgrade. Reference $(System*Version) directly in eng/Packages.props (matching roslyn), drop the floor scaffolding, and declare the packages at 10.0.10 in Version.Details so product/PR restore satisfies MSBuild 18.11 / Roslyn 5.11 without a downgrade. Source-build overrides these to its live runtime version. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3a3d99e1-5b05-409a-afd5-c8d9676360f4
Contributor
✅ No release notes required |
T-Gro pushed a commit
to dotnet/dotnet
that referenced
this pull request
Aug 19, 2026
…ages Direct-apply of dotnet/fsharp#20290 to unblock this codeflow PR without waiting for the fsharp official build. Removes the ...CentralVersion/floor scaffolding (which froze the pins before source-build's PackageVersions.fsharp.props could override the runtime package properties) and declares the runtime packages at 10.0.10 so the vertical build restore has no downgrade. Source-build overrides these to the live runtime version.
Documents why renaming the runtime-package central pins to computed $(System*CentralVersion) aliases with a floor defeated source-build's $(System*Version) override, and adds an eng/ instruction file so the lesson is surfaced when editing the dependency manifests.
abonie
approved these changes
Aug 19, 2026
dotnet-maestroBot
added a commit
to dotnet/dotnet
that referenced
this pull request
Aug 19, 2026
[release/11.0.1xx-rc1] Source code updates from dotnet/fsharp - Fix conflicts - [fsharp] Restore source-build overridable prop names for runtime packages Direct-apply of dotnet/fsharp#20290 to unblock this codeflow PR without waiting for the fsharp official build. Removes the ...CentralVersion/floor scaffolding (which froze the pins before source-build's PackageVersions.fsharp.props could override the runtime package properties) and declares the runtime packages at 10.0.10 so the vertical build restore has no downgrade. Source-build overrides these to the live runtime version.
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #20278. The CPM central pins for the MSBuild/Roslyn-pulled dotnet/runtime packages were routed through intermediate
...CentralVersionproperties with a10.0.10floor. Source-build injects live runtime versions by overriding$(System*Version)(viaPackageVersions.fsharp.props), but the renamed...CentralVersionpins were evaluated before that override and could not be set by source-build — so the floor forced10.0.10while source-build supplied10.0.9, producing prebuilts and NU1109 downgrades in the VMR (dotnet/dotnet#8413, dotnet/dotnet#8414, dotnet/dotnet#8415).eng/Packages.propsnow references$(System*Version)directly (matching roslyn), the floor scaffolding is gone, and the packages are declared at10.0.10inVersion.Detailsso product/PR restore satisfies MSBuild18.11/ Roslyn5.11without a downgrade. Source-build overrides these to its live runtime version.