Skip to content

Colorize F# signature help - #2034

Merged
KevinRansom merged 3 commits into
dotnet:masterfrom
dungpa:signature-help
Dec 17, 2016
Merged

Colorize F# signature help#2034
KevinRansom merged 3 commits into
dotnet:masterfrom
dungpa:signature-help

Conversation

@dungpa

@dungpadungpa commented Dec 17, 2016•
edited
Loading

Copy link
Copy Markdown
Contributor

Screenshot:

image

The text parsing part is ad hoc. I imagine we can make use of structured data for precise coloring once these changes landed master...vladima:vladima/classification

@dungpadungpa mentioned this pull request Dec 17, 2016
Closed
1 task
@vasily-kirichenko

vasily-kirichenko commented Dec 17, 2016

Copy link
Copy Markdown
Contributor

Wow, cool.

@vasily-kirichenko

vasily-kirichenko commented Dec 17, 2016

Copy link
Copy Markdown
Contributor

D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\TestLib.LanguageService.fs(361,17): error FS0074: The type referenced through 'Microsoft.VisualStudio.Text.Classification.IClassifier' is defined in an assembly that is not referenced. You must add a reference to assembly 'Microsoft.VisualStudio.Text.Logic'. [D:\j\workspace\release_ci_pa---3f142ccc\vsintegration\tests\unittests\VisualFSharp.Unittests.fsproj]

@dungpa

dungpa commented Dec 17, 2016

Copy link
Copy Markdown
ContributorAuthor

@vasily-kirichenko Thanks, fixed.

@cartermp

cartermp commented Dec 17, 2016

Copy link
Copy Markdown
Contributor

@dungpa Awesome!

@KevinRansom

KevinRansom commented Dec 17, 2016

Copy link
Copy Markdown
Contributor

@dungpa
This is great thank you for this

Kevin

@KevinRansom
KevinRansom merged commit 8e07ffe into dotnet:masterDec 17, 2016
@dungpa
dungpa deleted the signature-help branch December 17, 2016 18:16
@vladima

vladima commented Dec 19, 2016

Copy link
Copy Markdown
Contributor

one step closer

classification in signature help
image

classfication in completion list
image

@vasily-kirichenko

vasily-kirichenko commented Dec 19, 2016

Copy link
Copy Markdown
Contributor

@vladima This is fantastic :)

I think namespaces should not be colorized as types, should they? (I mean System namespace in "Exceptions" block on the second screenshot)

@dungpa

dungpa commented Dec 19, 2016

Copy link
Copy Markdown
ContributorAuthor

@vladima Cool!

nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Jan 26, 2022
@dungpa@KevinRansom
Colorize F# signature help (dotnet#2034)
e6e7c89
* Colorize F# signature help
* Remove unnecessary symbol API
* Fix assembly references
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@KevinRansomKevinRansomKevinRansom approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dungpa@vasily-kirichenko@cartermp@KevinRansom@vladima@msftclas