Add colours to FSI output

[saul]

FSI results can now be coloured thanks to #2070:

The colours are up for discussion. In particular I think keywords should be a brighter colour than blue, maybe green or magenta. I just stuck to VS defaults as a first go.

[msftclas]

Hi @saul, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

[cartermp]

Ultimately colors should be configurable/conform to set profiles, but I think that VS defaults are fine for now. Any idea how much it would take to add some basic configuration in Tools|Options|F# Interactive?

[saul]

Definitely - this PR is for the console window only though. There's no integration for VS FSI yet. Any ideas as to where the colour settings should live?

[vasily-kirichenko]

About colors, switch to the dark theme in VS and grab colors from there, they should be much more readable compared to the current ones.

It would be very much appreciated if you enable the coloring in VS FSI, too. I don't think many people use the console FSI.

[vasily-kirichenko]

@dungpa I think you were tried to color VS FSI (in some hacky way :) ). Could you give some points on how to do it?

[KevinRansom]

Adding VFSI support for colours is a separate issue. Please start an issue .. for that.

Kevin

[saul]

@KevinRansom with regards to #2163, how do you want to move forward with this? Are we happy with the colours as is?

I'd personally prefer keywords to be green so they stand out on black. It should be worth noting that colours can be disabled with the current mechanism (command line option of --consolecolors-).

[KevinRansom]

@saul yes colours as is is fine. There are some baseline file errors that need fixing ...

[saul]

The baseline changes are due to newlines being consistently used for FSI errors and output. Previously there was no consistency. Now there's only ever a blank line after output/error and before the next prompt.

[KevinRansom]

@saul ... excellent.

Thank you

[saul]

@KevinRansom tests are green 👍

[KevinRansom]

Colourfull FSI ... what a thing ....

@saul
We need an issue to allow the configuration of these colours and the ability to select themes.
We need an issue to reproduce this colourful loveliness in VSFSI.

[KevinRansom]

Thank you for taking care of this