Skip to content

¯\_(ツ)_/¯ - #2639

Merged
KevinRansom merged 3 commits into
dotnet:masterfrom
forki:patch-25
Mar 17, 2017
Merged

¯\_(ツ)_/¯#2639
KevinRansom merged 3 commits into
dotnet:masterfrom
forki:patch-25

Conversation

@forki

@forkiforki commented Mar 17, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@forkiforki closed this Mar 17, 2017
@forki
forki deleted the patch-25 branch March 17, 2017 14:37
@forki

forki commented Mar 17, 2017

Copy link
Copy Markdown
ContributorAuthor

Lol it's needed

@smoothdeveloper

smoothdeveloper commented Mar 17, 2017

Copy link
Copy Markdown
Contributor

RIP, I think you removed the historical first line of the implementation of that function, when measures emerged.

@forki

forki commented Mar 17, 2017•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@smoothdeveloper@cartermp the issue is there is code under compiler directive that uses g - so it's only used for some compile runs. Other runs would flag it as "Unused parameter" and let the build fail. This is a clever trick to make sure it's "used" all the times.

@smoothdeveloper

smoothdeveloper commented Mar 17, 2017

Copy link
Copy Markdown
Contributor

mmh I see EXTENSIONTYPING, let's keep g but we can move ignore g in the #else or just leave a comment for saving next one to try to remove it :)

@forki
forki restored the patch-25 branch March 17, 2017 15:25
@forkiforki reopened this Mar 17, 2017
@forki

forki commented Mar 17, 2017

Copy link
Copy Markdown
ContributorAuthor

Ok tried to make situation more clear

@KevinRansom

KevinRansom commented Mar 17, 2017

Copy link
Copy Markdown
Contributor

Thanks for this

@KevinRansom
KevinRansom merged commit 46bed4f into dotnet:masterMar 17, 2017
@forki
forki deleted the patch-25 branch March 17, 2017 17:24
@smoothdeveloper

smoothdeveloper commented Mar 17, 2017

Copy link
Copy Markdown
Contributor

@forki you should also thank @dotnet-bot for helping you getting the code right :)

@KevinRansom

KevinRansom commented Mar 17, 2017

Copy link
Copy Markdown
Contributor

@smoothdeveloper We all owe dotnet bot gratitude for that. @dotnet-bot is one hard working engineer.

cloudRoutine pushed a commit to cloudRoutine/fsharp that referenced this pull request Mar 19, 2017
@forki@cloudRoutine
¯\_(ツ)_/¯ (dotnet#2639)
6561f26
* ¯\_(ツ)_/¯
* Make it more clear why "ignore g" is needed
* I heard F# is whitespace sensitive
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@smoothdevelopersmoothdevelopersmoothdeveloper approved these changes
@KevinRansomKevinRansomKevinRansom approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@forki@smoothdeveloper@KevinRansom@msftclas