Numbers with underscores cause compilation error sometimes

[forki]

fixes#2701

/cc @AviAvni

[AviAvni]

@forki thanks sorry for the missing need to add tests in https://github.com/Microsoft/visualfsharp/blob/master/tests/fsharpqa/Source/Conformance/BasicGrammarElements/Constants/BasicConstants.fs

[forki]

Could you please send a pull request to my fork? Or just add another pull request to the main fork and merge my stuff. Thanks Am 26.03.2017 3:42 nachm. schrieb "Avi Avni" <notifications@github.com>:

…

@forki <https://github.com/forki> thanks sorry for the missing need to add tests in https://github.com/Microsoft/visualfsharp/blob/master/ tests/fsharpqa/Source/Conformance/BasicGrammarElements/ Constants/BasicConstants.fs — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2702 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNOfzs73dKgfV1iWFP0G6SYbF_JMLks5rpms4gaJpZM4MpacQ> .

[AviAvni]

@forki I'll send PR with tests later

[AviAvni]

@forki@KevinRansom@dsyme
After I checked it when I implemented this feature I added this https://github.com/Microsoft/visualfsharp/blob/master/src/fsharp/FSharp.Core/prim-types.fs#L2523
but in the compilation of FSharp.Editor it uses the proto compiler and in ilSpy the FSharp.Core in the proto binary don't have this change

[forki]

@AviAvni yes it seems it's only happening in proto

[AviAvni]

@forki so no need tests if they fix this proto thing all be ok if they want this to be implemented in the lexer and not dependent in the FSharp.Core they can merge this PR

[forki]

The thing is: we need to fix it in order to have it available in fsharp itself. But good to know that other projects are not broken. So it's not that urgent Am 26.03.2017 7:50 nachm. schrieb "Avi Avni" <notifications@github.com>: @forki <https://github.com/forki> so no need tests if they fix this proto thing all be ok if they want this to be implemented in the lexer and not dependent in the FSharp.Core they can merge this PR — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2702 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNKW1QuwOb2_vecyiDp22M-dOzlecks5rpqVhgaJpZM4MpacQ> .

[KevinRansom]

Looks good

[KevinRansom]

@forki
Thank you for this .