Uh oh!
There was an error while loading. Please reload this page.
Use Dictionary instead of Map in ValInfos - #2725
Merged
Merged
Conversation
| let (ValHash t) = ht | ||
| let i = v.Stamp | ||
| if t.ContainsKey(i) then Some(t.[i]) else None | ||
| match t.TryGetValue v.Stamp with |
Contributor
There was a problem hiding this comment.
Have you tried this under some performance test?
I know this sounds stupid, but when I was looking at similar stuff and did simple testing under FSI, using similar sized dictionaries than code I was looking at, the former code actually performed better, which was kind of baffling.
ContributorAuthor
There was a problem hiding this comment.
yes in other situations we had very good perf improvements for such things
| | ValValue (vr,vinfo) -> ValValue (vr,bound (depth-1) vinfo) | ||
| | TupleValue vinfos -> TupleValue (Array.map (bound (depth-1)) vinfos) | ||
| | RecdValue (tcref,vinfos) -> RecdValue (tcref,Array.map (bound (depth-1)) vinfos) | ||
| | UnionCaseValue (ucr,vinfos) -> UnionCaseValue (ucr,Array.map (bound (depth-1)) vinfos) |
Contributor
There was a problem hiding this comment.
since that block is changing, maybe worth to get it aligned (as it was kind of half aligned).
dsyme
reviewed
Mar 29, 2017
| member ht.Values = | ||
| let (ValHash t) = ht | ||
| t.Values :> 'T seq |
dsyme
approved these changes
Mar 29, 2017
KevinRansom
approved these changes
Mar 31, 2017
KevinRansom
commented
Mar 31, 2017
Contributor
@forki Kevin |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.