') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); fix binding redirects by dsyme · Pull Request #2740 · dotnet/fsharp · GitHub
Skip to content

fix binding redirects - #2740

Closed
dsyme wants to merge 2 commits into
dotnet:masterfrom
dsyme:f8
Closed

fix binding redirects#2740
dsyme wants to merge 2 commits into
dotnet:masterfrom
dsyme:f8

Conversation

@dsyme

@dsymedsyme commented Mar 30, 2017

Copy link
Copy Markdown
Contributor

Unfortunately we don't use AutoGenerateBindingRedirects for these, because that doesn't generate an FSHarp.Core binding redirect, which is required for most type providers to work.

So we have to do this manually for now unless we find someway to automate this

KevinRansom
KevinRansom reviewed Mar 30, 2017
View reviewed changes
Comment threadsrc/fsharp/Fsc/fsc.exe.config
</dependentAssembly>
<dependentAssembly>
<assemblyIdentity name="System.Collections.Immutable" publicKeyToken="b03f5f7f11d50a3a" culture="neutral" />
<bindingRedirect oldVersion="0.0.0.0-1.2.1.0" newVersion="1.2.1.0" />

@KevinRansomKevinRansomMar 30, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dsyme

Yeah ... we are in actual dll hell now. I have spent most of the last two days trying to get our build working again. which included reverting back to System.Collections.Immutable 1.2.0.

Parts of vs require and deploys 1.2.0, roslyn is build using 1.2.1, VS has binding redirects back down to 1.2.0.

Anyway I think this will be taken care of by: #2675 which was supposed to just add sourcelink support, but now kind of fixes our current dll hell issues.

As a side note: when code reviewing we need to be especially careful when looking at changes to dependent packages.

I am actually a bit mystified why the CI is continuing to work, although I suppose it may be that it reuses images, and they have parts of previous package downloads.
Our internal microbuild has failed nightly for the last 4 nights, and I definitely see failures on all of my machines.
I am considering adding a git clean -fxdq to our CI.

Kevin

@smoothdevelopersmoothdeveloperMar 30, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a reminder that when using nuget packages, paket actually does a good work at generating those redirects (related to nuget packages you are pulling) for you.

I've spent too much time with conflicts and binding redirects, msbuild or nuget are just hopeless in helping the developer do the right thing in this context.

When I switched to paket at my work, it simply relieved me from that problem, I don't face binding redirects issues, or only in case I'm pulling dependencies outside of nuget eco system (which is very seldom).

This is the only fsharp repository which is not using paket so maybe we could do some harmonization?

@smoothdevelopersmoothdeveloperMar 30, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the diff, paket would solve the one for System.Collections.Immutable, and if we made a nupkg of FSharp.Core for consumption in other projects, it could also write that one automatically.

@vasily-kirichenkovasily-kirichenkoMar 31, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm for Paket, too. Are there any (corporate policy or the like) reasons to not switch to Paket?

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
@smoothdevelopersmoothdevelopersmoothdeveloper left review comments
@vasily-kirichenkovasily-kirichenkovasily-kirichenko left review comments
@KevinRansomKevinRansomKevinRansom left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dsyme@smoothdeveloper@vasily-kirichenko@KevinRansom@msftclas