Added "You must add a reference to '<assembly>'" code fixer by saul · Pull Request #2743 · dotnet/fsharp

saul · 2017-03-30T21:50:01Z

Project references

Assembly references

Remaining work

Localise text
Copy 'metadata' references from other projects in the solution if we can't find any matching projects
Fix assertion failure when adding the reference
Removing references are not reflected in the Roslyn workspace until solution reload

saul · 2017-03-30T21:55:47Z

I've opened this PR to get some help/pick the brains of others. The problem is that ProjectSysten.OAReferences.AddProject is being called with Library1, i.e. it's attempting to add a reference to Library1 from Library1.

We must be reporting our projects to Roslyn incorrectly, as the names are correct on the Roslyn end (as shown in the screenshot). ApplyProjectReferenceAdded is the first in the call-stack before we enter the F# project system code.

I have a feeling that we're calling projectInfoManager.UpdateProjectInfo with the correct project GUID but the incorrect site. My very preliminary debugging indicated that we're passing in the correct data, though.

vasily-kirichenko · 2017-03-31T16:52:52Z

@saul sorry for offtopic, I cannot find the place where you started the work to enable F# <-> C# Go to Definition. Have you suspended or given up on it? We'd like to join the effort if you are stuck or something.

saul · 2017-03-31T16:58:42Z

@vasily-kirichenko it's very WIP state on my desktop (I'm only on my laptop for a few days). I'll push what I've got onto a branch on Sunday night/Monday. It's certainly not suspended/given up on :)

…ctContext

saul · 2017-04-03T19:34:20Z

8228545 raised a bit of a doozy in our Roslyn workspace setup code. When we setup the project references, we were passing in the dependent project as the hierarchy for the dependency. How this hasn't caused more issues is beyond me!

…nces

saul · 2017-04-03T20:00:54Z

Added support for metadata references:

saul · 2017-04-03T20:07:35Z

This is now ready to merge 👍

…nces

…isualfsharp into missing-reference-codefix # Conflicts: # vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs

saul · 2017-04-03T20:17:08Z

I've screwed my rebase up again... I really should read up on how to do this properly.

cloudRoutine · 2017-04-03T21:30:14Z

just checkout a new branch off of master and cherry pick the important commits and you'll be back to status quo in a few mins

…-codefix

saul · 2017-04-15T10:54:01Z

@dotnet-bot test this please

cartermp · 2017-04-15T17:59:17Z

Ugh "The value, namespace, type or module 'CommonRoslynHelpers' is not defined." makes no sense

@dotnet-bot test this please

saul · 2017-04-15T18:00:52Z

@cartermp it's because I'm an idiot - fixed

cartermp · 2017-04-16T02:24:50Z

Looks like there's a merge conflict now. Unrelated to the build error, though.

# Conflicts: # vsintegration/src/FSharp.Editor/srFSharp.Editor.fs

saul · 2017-04-16T13:45:34Z

It's green!!

KevinRansom · 2017-04-03T01:32:43Z

+ | Some metadataRef ->
+ let codefix = 
+ createCodeFix(
+ sprintf "Add an assembly reference to '%s'" metadataRef.Display, // TODO: localise


can you localize this before I pull it.

KevinRansom · 2017-04-03T01:32:57Z

+ | Some refProject ->
+ let codefix = 
+ createCodeFix(
+ sprintf "Add a project reference to '%s'" refProject.Name, // TODO: localise


saul · 2017-04-17T18:00:08Z

@KevinRansom it is localised - see the latest commits

saul · 2017-04-18T17:33:02Z

@dotnet-bot test this please

…-codefix

saul · 2017-04-19T16:48:31Z

@KevinRansom you did a dodgy merge - fixed and merged master again. Hopefully this will be the final time -.-

saul · 2017-04-20T18:07:49Z

@cartermp @KevinRansom can this be merged?

KevinRansom · 2017-04-20T18:08:49Z

looking at it right now.

KevinRansom · 2017-04-20T18:13:36Z

Thank you for this, it looks great.,

) * Added "You must add a reference to 'foo'" code fixer * Preliminary work to enable metadata reference code fixing * Fix SetupProjectFile passing in the wrong IVsHierarchy to CreateProjectContext * Localise code fix strings, add support for metadata (assembly) references * Fix removing references not being reflected in the Roslyn workspace * Added "You must add a reference to 'foo'" code fixer * Preliminary work to enable metadata reference code fixing * Rebased onto master * Localise code fix strings, add support for metadata (assembly) references * Fix removing references not being reflected in the Roslyn workspace * Fix dodgy merge * Fix reference to CommonRoslynHelpers * Removed intellisense strings accidentally added in merge * Ignore case when comparing assembly names * Fix dodgy merge

psfinaki · 2023-09-25T17:02:55Z

Hey @saul, I know it's been 6 years, but maybe do you remember how to repro this? I would like to add some tests for this code fix but, whatever I am doing, I am either getting FS0039 or the the assembly is discovered and added automatically. So I wonder if this is still relevant.

saul · 2023-09-25T20:19:26Z

From memory, I think this would repro when you had a reference (on .NET Framework, before SDK-style projects judging by the year) onto Library2, which in turn referenced Library3 and exposed it through its public API (e.g. method parameters).

I think nowadays assembly references are rare, and in the age of SDK-style projects, project references are transitive. This may be quite a difficult scenario to stumble upon now.

psfinaki · 2023-09-26T12:46:37Z

Ohhhhhh this thing. Okay yeah, my brain has already purged the memories of those days and those project files :D
Yeah, I downloaded VS2017 and verified in on that scenario - this still works.

Thanks @saul for such a prompt response - you saved me a lot of time.

Added "You must add a reference to 'foo'" code fixer
7f5fb7b

msftclas added the cla-already-signed label Mar 30, 2017

Preliminary work to enable metadata reference code fixing
95e1ec3

Fix SetupProjectFile passing in the wrong IVsHierarchy to CreateProje…
8228545
…ctContext

Localise code fix strings, add support for metadata (assembly) refere…
957ef1e
…nces

Fix removing references not being reflected in the Roslyn workspace
91c2ceb

saul changed the title ~~[WIP] Added "You must add a reference to '<assembly>'" code fixer~~Added "You must add a reference to '<assembly>'" code fixerApr 3, 2017

saul added 6 commits April 3, 2017 21:10

Added "You must add a reference to 'foo'" code fixer
5cd8748

Preliminary work to enable metadata reference code fixing
b2d36fd

Rebased onto master
4f4b96a

Localise code fix strings, add support for metadata (assembly) refere…
e82a311
…nces

Fix removing references not being reflected in the Roslyn workspace
b5e242a

Merge branch 'missing-reference-codefix' ofhttps://github.com/saul/v…
b2e35b9
…isualfsharp into missing-reference-codefix # Conflicts: # vsintegration/src/FSharp.Editor/LanguageService/LanguageService.fs

saul added 2 commits April 4, 2017 07:31

Merge remote-tracking branch 'upstream/master' into missing-reference…
733ce07
…-codefix

Fix dodgy merge
a582f56

Fix reference to CommonRoslynHelpers
d772c65

saul added 2 commits April 16, 2017 10:02

Merge branch 'master' into missing-reference-codefix
b261c4b
# Conflicts: # vsintegration/src/FSharp.Editor/srFSharp.Editor.fs

Removed intellisense strings accidentally added in merge
0013976

cartermp approved these changes Apr 16, 2017
View reviewed changes

Ignore case when comparing assembly names
75ce1ff

KevinRansom approved these changes Apr 17, 2017
View reviewed changes

Merge branch 'master' into missing-reference-codefix
f174052

saul added 2 commits April 19, 2017 17:47

Fix dodgy merge
1d2bbeb

Merge remote-tracking branch 'upstream/master' into missing-reference…
20e2bc5
…-codefix

KevinRansom approved these changes Apr 20, 2017
View reviewed changes

KevinRansom merged commit 4c31706 into dotnet:masterApr 20, 2017

psfinaki mentioned this pull request Sep 26, 2023
Minor improvements to an old code fix #16048
Merged

Uh oh!

Conversation

saul commented Mar 30, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Project references

Assembly references

Remaining work

Uh oh!

saul commented Mar 30, 2017

Uh oh!

vasily-kirichenko commented Mar 31, 2017

Uh oh!

saul commented Mar 31, 2017

Uh oh!

saul commented Apr 3, 2017

Uh oh!

saul commented Apr 3, 2017

Uh oh!

saul commented Apr 3, 2017

Uh oh!

saul commented Apr 3, 2017

Uh oh!

cloudRoutine commented Apr 3, 2017

Uh oh!

saul commented Apr 15, 2017

Uh oh!

cartermp commented Apr 15, 2017

Uh oh!

saul commented Apr 15, 2017

Uh oh!

cartermp commented Apr 16, 2017

Uh oh!

saul commented Apr 16, 2017

Uh oh!

KevinRansomApr 3, 2017

Choose a reason for hiding this comment

Uh oh!

KevinRansomApr 3, 2017

Choose a reason for hiding this comment

Uh oh!

saul commented Apr 17, 2017

Uh oh!

saul commented Apr 18, 2017

Uh oh!

saul commented Apr 19, 2017

Uh oh!

saul commented Apr 20, 2017

Uh oh!

KevinRansom commented Apr 20, 2017

Uh oh!

KevinRansom commented Apr 20, 2017

Uh oh!

psfinaki commented Sep 25, 2023

Uh oh!

saul commented Sep 25, 2023

Uh oh!

psfinaki commented Sep 26, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

saul commented Mar 30, 2017•
edited
Loading