Uh oh!
There was an error while loading. Please reload this page.
add build task to generate *.resx and *.fs from *.txt resources - #3577
Merged
Conversation
dsyme
approved these changes
Sep 13, 2017
Contributor
There was a problem hiding this comment.
Should the name be something like ```FSharpEmbedResourceTest`` or something to make sure it is distinct?
dsyme
commented
Sep 13, 2017
Contributor
Neat |
brettfo
commented
Sep 14, 2017
MemberAuthor
@dotnet-bot test this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build task
FSharpEmbedResourceTextadded toFSharp.Build.dllis basically the contents offssrgen.fsx, just re-worked with the appropriate entry point.Projects using the old
<FsSrGen />task have been updated to<EmbeddedText />as appropriate except for the following:These can't be (easily) moved forward until our LKG contains this new build task, so for now the old method has to stick around for a bit longer.