Uh oh!
There was an error while loading. Please reload this page.
Add IsRelativeNameResolvableFromSymbol - #3722
Conversation
vasily-kirichenko
commented
Oct 10, 2017
|
Krzysztof-Cieslak
commented
Oct 10, 2017
@vasily-kirichenko, yes I've seen it. That's what happens if you send PRs from the train without working editor tooling ;-) Will fix later today |
| false) | ||
| /// Determines if a long ident is resolvable at a specific point. | ||
| member scope.IsRelativeNameResolvableFromSymbol(cursorPos: pos, plid: string list, symbol: FSharpSymbol) : bool = |
There was a problem hiding this comment.
Not the prettiest name but it will do :)
dsyme
commented
Oct 10, 2017
I'm ok with this. @vasily-kirichenko Do you think we need to add specific tests or is existing coverage of IsRelativeNameResolvable enough? |
vasily-kirichenko
commented
Oct 10, 2017
@dsyme we don't have any tests for |
Krzysztof-Cieslak
commented
Oct 10, 2017
If it's OK then I'd appreciate merge and getting FCS release with it 🙂 |
dsyme
commented
Oct 10, 2017
@Krzysztof-Cieslak Could you add a test please under tests\service? thanks |
KevinRansom
commented
Oct 16, 2017
@dotnet-bot test this please |
Krzysztof-Cieslak
commented
Oct 17, 2017
@KevinRansom, thanks for merging. @dsyme, I'll add tests in other PR, when I find some time to write it ;) I would be super happy if you could release FCS version with it, so we can use it in FSAC :-) |
Continuation of fsharp/fsharp-compiler-docs#823