Make FCS build work by forki · Pull Request #3788 · dotnet/fsharp

forki · 2017-10-20T19:56:42Z

restore from fake script since cmd had path issues
stackoverflow exception in ProjectCracker refactored to much more useful type load exception - thanks @0x53A and @matthid for support
Copy msbuild dependencies to Output
Fake installs dotnet core autimatically if needed
Created Clean target in build.fsx
made tests culture independent
disabled test that are dependent on MSBuild 14 runtime
execute flag on build.sh thanks @kjnilsson
better error messages in many places
if a project appears more than once in a deps tree we only parse it once
tests on Ubuntu disabled since they were already disabled in original FCS
corresponding FCS PR: [Test only] Apply changes from VF# Jenkins build activation fsharp/fsharp-compiler-docs#829

Remark: If we can get a CI server with MSBuild14 installed then we could enable 8 more tests

KevinRansom · 2017-10-20T19:58:03Z

I will try my best ...

KevinRansom · 2017-10-20T20:12:19Z

@forki -- Tip: if you want to ran a specific test use:
"@dotnet-bot test Windows_NT Release_fcs Build please"

forki · 2017-10-20T20:16:14Z

@KevinRansom I'm not sure but somehow other builds went red as well. I'm deeply sorry, but there was no way to test in pr and now I have to leave. If things are red on master apart from FCS build then please revert my stuff and I retry on monday

forki · 2017-10-20T20:17:30Z

If only FCS ist Red then WE can probably ignore for now

cartermp · 2017-10-20T20:38:49Z

It seems that only FCS is red here, so I think it's safe to ignore until this gets worked out

KevinRansom · 2017-10-20T20:42:27Z

@forki @cartermp I ain't bothered ... I was assuming if there was an _fcs red, I was going to consider things green ... until the _fcs stuff is working.

Anyway ... broken builds is how we know work is happening ...
You know what they say ... "If it ain't broke ... we aint trying hard enough"

Hmmmm!!!! do they say really that Kevin, or did you just make that up?

cartermp · 2017-10-20T21:10:57Z

https://www.youtube.com/watch?v=D8_nRkCJx9o

forki · 2017-10-20T21:54:19Z

OK the weird thing is: this looks as if my last groovy change never happened. Wtf

forki · 2017-10-20T21:58:53Z

Seriously it should have run ./fcs/build.cmd and not with \
And it should also have started an Ubuntu version. Why isn't it?

KevinRansom · 2017-10-20T21:59:27Z

@dotnet-bot test this please

forki · 2017-10-21T01:17:21Z

#3790 did not run the fcs build. And this one runs outdated version. @KevinRansom do you understand this?

KevinRansom · 2017-10-21T04:29:45Z

@forki I think it was this: PR:

https://github.com/Microsoft/visualfsharp/pull/3781/files

I think the first } is I=in the wrong place.

The CI will not update the groovy script if it has syntax errors, which makes sense if you think about it a bit.

 if (os == 'Windows_NT') { } configurations = ['Debug', 'Release_ci_part1', 'Release_ci_part2', 'Release_ci_part3', 'Release_net40_no_vs', 'Release_fcs' ]; else { // Linux configurations = ['Release', 'Release_fcs' ]; }

KevinRansom · 2017-10-21T04:35:38Z

@dotnet-bot test this please

KevinRansom · 2017-10-21T04:35:57Z

There you go fixed it.

forki · 2017-10-21T07:18:56Z

Thank you Kevin. Now I think I can try to make it work

forki · 2017-10-21T09:54:24Z

Ok progress. It now fails on the unit tests. Any ideas @vasily-kirichenko @dsyme @ncave @enricosada @Krzysztof-Cieslak

0x53A · 2017-10-21T13:55:09Z

05:45:32 Finished Target: Build.NetFx
05:45:32 Starting Target: Test.NetFx (==> Build.NetFx)
05:45:32 ..\packages\NUnit.Console.3.0.0\tools\nunit3-console.exe "--noheader" "--timeout=1200000" "--work=/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/Release/fcs/net45" "/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/Release/fcs/net45/FSharp.Compiler.Service.Tests.dll" 05:45:32 mono "..\packages\NUnit.Console.3.0.0\tools\nunit3-console.exe" "--noheader" "--timeout=1200000" "--work=/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/Release/fcs/net45" "/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/Release/fcs/net45/FSharp.Compiler.Service.Tests.dll" 05:45:32 Cannot open assembly '..\packages\NUnit.Console.3.0.0\tools\nunit3-console.exe': No such file or directory.
05:45:32 Running build failed.

https://github.com/Microsoft/visualfsharp/blob/f375d8d56cb69f7143254462fea2aa1c3cd12262/fcs/build.fsx#L90-L96

maybe the relative path is the issue? If the script is executed in the root, then it would try to look outside the repo.

I always use the pattern

letcd=__SOURCE_DIRECTORY__
ToolPath = cd @@@"..\packages\NUnit.Console.3.0.0\tools\nunit3-console.exe"

in my build scripts.

forki · 2017-10-21T13:56:58Z

I'd appreciate a pull request against my fork. Please please please Am 21.10.2017 15:55 schrieb "Lukas Rieger" <notifications@github.com>:

…

05:45:32 Finished Target: Build.NetFx 05:45:32 Starting Target: Test.NetFx (==> Build.NetFx) 05:45:32 ..\packages\NUnit.Console.3.0.0\tools\nunit3-console.exe "--noheader" "--timeout=1200000" "--work=/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/Release/fcs/net45" "/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/Release/fcs/net45/FSharp.Compiler.Service.Tests.dll" 05:45:32 mono "..\packages\NUnit.Console.3.0.0\tools\nunit3-console.exe" "--noheader" "--timeout=1200000" "--work=/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/Release/fcs/net45" "/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/Release/fcs/net45/FSharp.Compiler.Service.Tests.dll" 05:45:32 Cannot open assembly '..\packages\NUnit.Console.3.0.0\tools\nunit3-console.exe': No such file or directory. 05:45:32 Running build failed. https://github.com/Microsoft/visualfsharp/blob/f375d8d/fcs/build.fsx#L90-L96 maybe the relative path is the issue? If the script is executed in the root, then it would try to look outside the repo. I always use the pattern let cd = __SOURCE_DIRECTORY__ ToolPath = cd @@ @"..\packages\NUnit.Console.3.0.0\tools\nunit3-console.exe" in my build scripts. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#3788 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNJzhstVvLitWiD-jqGqfNMQSZ_2gks5sufe-gaJpZM4QBKDJ> .

0x53A · 2017-10-21T14:14:28Z

I'd appreciate a pull request against my fork. Please please please

done. Looking through the build script, relative paths are used in a few other places, so I'm no longer sure this is the issue, but at least it would now print the full path it it is looking for.

The Windows build fails with

05:37:00 1) Error : FSharp.Compiler.Service.Tests.ProjectOptionsTests.Project file parsing -- 2nd level references
05:37:00 System.Exception : Could not load file or assembly 'Microsoft.Build.Utilities.v12.0, Version=12.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified.
05:37:00 at <StartupCode$FSharp-Compiler-Service-ProjectCracker>.$ProjectCracker.convert@19(DateTime loadedTimeStamp, FSharpRef`1 logMap, ProjectOptions opts) in D:\j\w\release_fcs_w---49a16363\fcs\FSharp.Compiler.Service.ProjectCracker\ProjectCracker.fs:line 22
05:37:00 at Microsoft.FSharp.Compiler.SourceCodeServices.ProjectCracker.GetProjectOptionsFromProjectFileLogged(String projectFileName, FSharpOption`1 properties, FSharpOption`1 loadedTimeStamp, FSharpOption`1 enableLogging) in D:\j\w\release_fcs_w---49a16363\fcs\FSharp.Compiler.Service.ProjectCracker\ProjectCracker.fs:line 86
05:37:00 at FSharp.Compiler.Service.Tests.ProjectOptionsTests.Project file parsing -- 2nd level references() in D:\j\w\release_fcs_w---49a16363\tests\service\ProjectOptionsTests.fs:line 180

Just judging from the file name, Microsoft.Build.Utilities.v12.0 is probably a component of Visual Studio 2013. Maybe this version is not installed on the buildserver? It probably only has VS2017, and maybe 2015.

Best solution would be a nuget package providing it.

Edit: the dll is checked in

so it must probably "only" be copied to the output path. Or the directory with it needs to be added to the dll search directories.

forki · 2017-10-21T14:20:56Z

Whatever we need to shave this yak. I appreciate every help! Am 21.10.2017 16:14 schrieb "Lukas Rieger" <notifications@github.com>:

…

I'd appreciate a pull request against my fork. Please please please done. Looking through the build script, relative paths are used in a few other places, so I'm no longer sure this is the issue, but at least it would now print the full path it it is looking for. ------------------------------ The other build fails with 05:37:00 1) Error : FSharp.Compiler.Service.Tests.ProjectOptionsTests.Project file parsing -- 2nd level references 05:37:00 System.Exception : Could not load file or assembly 'Microsoft.Build.Utilities.v12.0, Version=12.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a' or one of its dependencies. The system cannot find the file specified. 05:37:00 at ***@***.***(DateTime loadedTimeStamp, FSharpRef`1 logMap, ProjectOptions opts) in D:\j\w\release_fcs_w---49a16363\fcs\FSharp.Compiler.Service.ProjectCracker\ProjectCracker.fs:line 22 05:37:00 at Microsoft.FSharp.Compiler.SourceCodeServices.ProjectCracker.GetProjectOptionsFromProjectFileLogged(String projectFileName, FSharpOption`1 properties, FSharpOption`1 loadedTimeStamp, FSharpOption`1 enableLogging) in D:\j\w\release_fcs_w---49a16363\fcs\FSharp.Compiler.Service.ProjectCracker\ProjectCracker.fs:line 86 05:37:00 at FSharp.Compiler.Service.Tests.ProjectOptionsTests.Project file parsing -- 2nd level references() in D:\j\w\release_fcs_w---49a16363\tests\service\ProjectOptionsTests.fs:line 180 Just judging from the file name, Microsoft.Build.Utilities.v12.0 is probably a component of Visual Studio 2013. Maybe this version is not installed on the buildserver? It probably only has VS2017, and maybe 2015. Best solution would be a nuget package providing it. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#3788 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNCocziXOPWcYStR2fjkLQ_UqK22jks5sufxEgaJpZM4QBKDJ> .

0x53A · 2017-10-21T14:52:58Z

The Ubuntu error is now different ...

07:34:34 Finished Target: Build.NetFx
07:34:34 Starting Target: Test.NetFx (==> Build.NetFx)
07:34:34 /mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/fcs/..\packages\NUnit.Console.3.0.0\tools\nunit3-console.exe "--noheader" "--timeout=1200000" "--work=/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/Release/fcs/net45" "/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/Release/fcs/net45/FSharp.Compiler.Service.Tests.dll" 07:34:34 mono "/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/fcs/..\packages\NUnit.Console.3.0.0\tools\nunit3-console.exe" "--noheader" "--timeout=1200000" "--work=/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/Release/fcs/net45" "/mnt/j/w/Microsoft_visualfsharp/master/release_fcs_ubuntu14.04_prtest/Release/fcs/net45/FSharp.Compiler.Service.Tests.dll" 07:34:34 07:34:34 Unhandled Exception:
07:34:34 System.IO.FileNotFoundException: Could not load file or assembly 'nunit.engine.api, Version=3.0.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb' or one of its dependencies.
07:34:34 File name: 'nunit.engine.api, Version=3.0.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb'
07:34:34 [ERROR] FATAL UNHANDLED EXCEPTION: System.IO.FileNotFoundException: Could not load file or assembly 'nunit.engine.api, Version=3.0.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb' or one of its dependencies.
07:34:34 File name: 'nunit.engine.api, Version=3.0.0.0, Culture=neutral, PublicKeyToken=2638cd05610744eb'
07:34:34 WARNING: The runtime version supported by this application is unavailable.
07:34:34 Using default runtime: v4.0.30319
07:34:34 Running build failed.
07:34:34 Error:
07:34:34 NUnit test failed (1).

This may be a hint:

07:34:34 WARNING: The runtime version supported by this application is unavailable.
07:34:34 Using default runtime: v4.0.30319

Maybe need to update mono?

0x53A · 2017-10-21T15:44:58Z

After setting <Private>true</Private>, the error on Windows is now different:

08:03:32 1) Error : FSharp.Compiler.Service.Tests.ProjectOptionsTests.Project file parsing -- 2nd level references
08:03:32 System.Runtime.Serialization.SerializationException : Expecting element 'root' from namespace ''.. Encountered 'None' with name '', namespace ''. 08:03:32 at System.Runtime.Serialization.Json.DataContractJsonSerializer.InternalReadObject(XmlReaderDelegator xmlReader, Boolean verifyObjectName)
08:03:32 at System.Runtime.Serialization.XmlObjectSerializer.ReadObjectHandleExceptions(XmlReaderDelegator reader, Boolean verifyObjectName, DataContractResolver dataContractResolver)
08:03:32 at System.Runtime.Serialization.Json.DataContractJsonSerializer.ReadObject(XmlDictionaryReader reader)
08:03:32 at Microsoft.FSharp.Compiler.SourceCodeServices.ProjectCracker.GetProjectOptionsFromProjectFileLogged(String projectFileName, FSharpOption`1 properties, FSharpOption`1 loadedTimeStamp, FSharpOption`1 enableLogging) in D:\j\w\release_fcs_w---49a16363\fcs\FSharp.Compiler.Service.ProjectCracker\ProjectCracker.fs:line 82
08:03:32 at FSharp.Compiler.Service.Tests.ProjectOptionsTests.Project file parsing -- 2nd level references() in D:\j\w\release_fcs_w---49a16363\tests\service\ProjectOptionsTests.fs:line 180

0x53A · 2017-10-21T17:19:14Z

AHA

Process is terminated due to StackOverflowException.

So the ProjectCrackerTool SOs.

@forki

forki · 2017-10-21T17:25:32Z

Are you kidding me? Am 21.10.2017 19:19 schrieb "Lukas Rieger" <notifications@github.com>:

…

AHA Process is terminated due to StackOverflowException. So the ProjectCrackerTool SOs. @forki <https://github.com/forki> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3788 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNF5zwDE_wA9MGcZc1oGLNQFSnBzvks5suieSgaJpZM4QBKDJ> .

forki · 2017-10-23T19:12:09Z

After 142 commits, 1136 builds and a lot of help from the community this now finally green and ready for review.

I'm happy to answer all questions.

cartermp · 2017-10-23T19:17:00Z

@forki are you feeling okay? 😄

For real though, good work.

Krzysztof-Cieslak · 2017-10-23T20:18:34Z

@forki, what is the meaning of life?

KevinRansom

@Krzysztof-Cieslak
@forki spent all weekend on this, he may not be qualified to answer that question.

KevinRansom · 2017-10-23T21:16:10Z

is this line correct?
+#endifests yet")
looks odd

Yes merge errors

forki · 2017-10-24T04:50:07Z

This is ready. The last error is fixed by groovy change in https://github.com/Microsoft/visualfsharp/pull/3805/files

forki · 2017-10-24T05:52:04Z

OMG It's green.

brb Rebasing.....

KevinRansom · 2017-10-24T08:41:39Z

@dotnet-bot test Windows_NT Release_ci_part2 Build please

KevinRansom

LGTM

KevinRansom · 2017-10-24T08:47:44Z

@forki,

I will merge it when I get in tomorrow.

Thanks for this, nice job.

eriawan · 2017-10-24T09:26:52Z

@forki

Just a suggestion, on your commit, these lines:
https://github.com/Microsoft/visualfsharp/pull/3788/files#diff-12575809f4907caaad73a959140e137d#L66-L109

 <Choose>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.5' Or $(TargetFrameworkVersion) == 'v4.6')">
<ItemGroup>
<Reference Include="Microsoft.Build">
<HintPath>..\packages\Microsoft.Build\lib\net45\Microsoft.Build.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
</Choose>
<Choose>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.5' Or $(TargetFrameworkVersion) == 'v4.6')">
<ItemGroup>
<Reference Include="Microsoft.Build.Engine">
<HintPath>..\packages\Microsoft.Build.Engine\lib\net45\Microsoft.Build.Engine.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
</Choose>
<Choose>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.5' Or $(TargetFrameworkVersion) == 'v4.6')">
<ItemGroup>
<Reference Include="Microsoft.Build.Framework">
<HintPath>..\packages\Microsoft.Build.Framework\lib\net45\Microsoft.Build.Framework.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
</Choose>
<Choose>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.5' Or $(TargetFrameworkVersion) == 'v4.6')">
<ItemGroup>
<Reference Include="Microsoft.Build.Utilities.Core">
<HintPath>..\packages\Microsoft.Build.Utilities.Core\lib\net45\Microsoft.Build.Utilities.Core.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
</Choose>

can be simplified to:

 <Choose>
<When Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.5' Or $(TargetFrameworkVersion) == 'v4.6')">
<ItemGroup>
<Reference Include="Microsoft.Build">
<HintPath>..\packages\Microsoft.Build\lib\net45\Microsoft.Build.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
<Reference Include="Microsoft.Build.Engine">
<HintPath>..\packages\Microsoft.Build.Engine\lib\net45\Microsoft.Build.Engine.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
<Reference Include="Microsoft.Build.Framework">
<HintPath>..\packages\Microsoft.Build.Framework\lib\net45\Microsoft.Build.Framework.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
<Reference Include="Microsoft.Build.Utilities.Core">
<HintPath>..\packages\Microsoft.Build.Utilities.Core\lib\net45\Microsoft.Build.Utilities.Core.dll</HintPath>
<Private>True</Private>
<Paket>True</Paket>
</Reference>
</ItemGroup>
</When>
</Choose>

The main reason is the condition of Condition="$(TargetFrameworkIdentifier) == '.NETFramework' And ($(TargetFrameworkVersion) == 'v4.5' Or $(TargetFrameworkVersion) == 'v4.6')" is literally the same or applicable for those Reference includes. It is also simpler 🙂

forki · 2017-10-24T09:27:47Z

@eriawan these lines are auto-generated by paket. we don't want to touch them!

eriawan · 2017-10-24T09:29:48Z

these lines are auto-generated by paket. we don't want to touch them!

@forki ah, ok. thanks for letting me know. 👍

KevinRansom · 2017-10-24T20:27:08Z

@forki

I will merge this shortly, we are in escrow, and have been trying to figure out what we needed from master and would be allowed to merge for the shipping branch.

We ended up going with everything, which is nice :-) When we have completed that, I will pull this and the other fcs pr.

Kevin

forki · 2017-10-24T20:30:12Z

Yes no need to merge this one. It should be reviewed carefully. But please consider to merge that groovy change in the other pr. It would unblock downstream immediately. Am 24.10.2017 22:27 schrieb "Kevin Ransom (msft)" <notifications@github.com

…

: @forki <https://github.com/forki> I will merge this shortly, we are in escrow, and have been trying to figure out what we needed from master and would be allowed to merge for the shipping branch. We ended up going with everything, which is nice :-) When we have completed that, I will pull this and the other fcs pr. Kevin — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3788 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNNsNkvD51HzMYwrxez4LX6Pdkwymks5svkgcgaJpZM4QBKDJ> .

dsyme · 2017-10-25T00:38:54Z

@forki What parts were you concerned about for review? I glanced over and it all looked reasonable - or at least localized to FCS and especially the project cracker

forki · 2017-10-25T01:52:18Z

Yes changes in project cracker make me nervous. But I got rid of the stackoverflow on type load (which is crazy that it happens at all) and that's probably a good thing. Am 25.10.2017 02:38 schrieb "Don Syme" <notifications@github.com>:

…

@forki <https://github.com/forki> What parts were you concerned about for review? I glanced over and it all looked reasonable - or at least localized to FCS and especially the project cracker — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3788 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADgNLNi8-FBqMej_1fOolJCiBzMSXYJks5svoMfgaJpZM4QBKDJ> .

* Put nupkgs into artifacts (#3806) * Make FCS build work on Jenkins (#3788)

* Merge dev15.5 to dev15.6 (#3825) * don't update project info if the source file collection is empty (#3792) * install templates VSIX to a unique directory (#3804) * P2p references (#3777) * P2p references * Fix test * test fix * go faster stripes * new project works better * Re-add debug assert for sourcefiles * Parameterise rc location (#3744) * Fix issues * Merge master to dev15.6 (#3826) * Put nupkgs into artifacts (#3806) * Make FCS build work on Jenkins (#3788)

forki closed this Oct 20, 2017

forki reopened this Oct 20, 2017

forki closed this Oct 21, 2017

forki reopened this Oct 21, 2017

forki force-pushed the patch-36 branch from 2d15ff4 to 4651c41Compare October 21, 2017 12:01

forki closed this Oct 21, 2017

forki force-pushed the patch-36 branch 2 times, most recently from c2d5d2f to 83cfd78Compare October 23, 2017 15:24

forki changed the title ~~[WIP] Evaluate if FCS build works~~Make FCS build workOct 23, 2017

forki force-pushed the patch-36 branch from b2fa134 to 80e506bCompare October 23, 2017 19:15

KevinRansom reviewed Oct 23, 2017
View reviewed changes

forki force-pushed the patch-36 branch from 1f0073a to d0144f7Compare October 24, 2017 05:07

forki force-pushed the patch-36 branch 2 times, most recently from 7f4d7e4 to 1de0471Compare October 24, 2017 05:54

forki mentioned this pull request Oct 24, 2017
[Test only] Apply changes from VF# Jenkins build activation fsharp/fsharp-compiler-docs#829
Closed

KevinRansom approved these changes Oct 24, 2017
View reviewed changes

Make FCS build work on Jenkins
d70cb1d

forki force-pushed the patch-36 branch from 1de0471 to d70cb1dCompare October 24, 2017 10:05

KevinRansom added the Merge when green label Oct 24, 2017

KevinRansom merged commit 4c19c42 into dotnet:masterOct 24, 2017

KevinRansom pushed a commit that referenced this pull request Oct 26, 2017
Merge master to dev15.6 (#3826)
01938e2
* Put nupkgs into artifacts (#3806) * Make FCS build work on Jenkins (#3788)

Uh oh!

Conversation

forki commented Oct 20, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KevinRansom commented Oct 20, 2017

Uh oh!

KevinRansom commented Oct 20, 2017

Uh oh!

forki commented Oct 20, 2017

Uh oh!

forki commented Oct 20, 2017

Uh oh!

cartermp commented Oct 20, 2017

Uh oh!

KevinRansom commented Oct 20, 2017

Uh oh!

cartermp commented Oct 20, 2017

Uh oh!

forki commented Oct 20, 2017

Uh oh!

forki commented Oct 20, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

KevinRansom commented Oct 20, 2017

Uh oh!

forki commented Oct 21, 2017

Uh oh!

KevinRansom commented Oct 21, 2017

Uh oh!

KevinRansom commented Oct 21, 2017

Uh oh!

KevinRansom commented Oct 21, 2017

Uh oh!

forki commented Oct 21, 2017

Uh oh!

forki commented Oct 21, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0x53A commented Oct 21, 2017

Uh oh!

forki commented Oct 21, 2017 via email

Uh oh!

0x53A commented Oct 21, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

forki commented Oct 21, 2017 via email

Uh oh!

0x53A commented Oct 21, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0x53A commented Oct 21, 2017

Uh oh!

0x53A commented Oct 21, 2017

Uh oh!

forki commented Oct 21, 2017 via email

Uh oh!

forki commented Oct 23, 2017• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cartermp commented Oct 23, 2017

Uh oh!

Krzysztof-Cieslak commented Oct 23, 2017

Uh oh!

KevinRansom left a comment

Choose a reason for hiding this comment

Uh oh!

KevinRansomOct 23, 2017

Choose a reason for hiding this comment

Uh oh!

forkiOct 24, 2017

Choose a reason for hiding this comment

Uh oh!

forki commented Oct 24, 2017

Uh oh!

forki commented Oct 24, 2017

Uh oh!

KevinRansom commented Oct 24, 2017

Uh oh!

KevinRansom left a comment

forki commented Oct 20, 2017•
edited
Loading

forki commented Oct 20, 2017•
edited
Loading

forki commented Oct 21, 2017•
edited
Loading

0x53A commented Oct 21, 2017•
edited
Loading

0x53A commented Oct 21, 2017•
edited
Loading

forki commented Oct 23, 2017•
edited
Loading