Skip to content

Test revert of #4173 - #4347

Merged
dsyme merged 1 commit into
dotnet:masterfrom
dsyme:revert-revert-revert
Feb 13, 2018
Merged

Test revert of #4173 #4347
dsyme merged 1 commit into
dotnet:masterfrom
dsyme:revert-revert-revert

Conversation

@dsyme

Copy link
Copy Markdown
Contributor

It is possible that we should revert #4173 until we understand the issues better and to ensure stability between F# 4.1 and its update releases.

See customer-reported issue #4343

This is trialling a revert of combined commit f9893b6.

@dsyme

Copy link
Copy Markdown
ContributorAuthor

@brettfo Close this since we have #4348 ? I assume you integrate dev15.6 --> master?

@dsymedsyme closed this Feb 13, 2018
@dsymedsyme reopened this Feb 13, 2018
@dsyme

Copy link
Copy Markdown
ContributorAuthor

@brettfo Is it OK if we apply this to the master branch too? I just want the core compiler logic to be in sync, so we can integrate it to Mono etc. (Mono release repo http://github.com/fsharp/fsharp is formed by integrating "master" branch here)

@brettfo

Copy link
Copy Markdown
Member

Yes we plan on merging dev15.6 back into master, but it might be a few weeks so having this separate PR is probably a good idea.

@dsyme

Copy link
Copy Markdown
ContributorAuthor

@brettfo Thanks. Merging since it was green before I opened it

@dsyme
dsyme merged commit 7377b02 into dotnet:masterFeb 13, 2018
@TIHanTIHan mentioned this pull request Sep 4, 2018
T-Gro pushed a commit that referenced this pull request Jun 12, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dsyme@brettfo