[CompilerPerf] Extends #5112 ideas to Comparers (i.e >, >=, <, <= and LanguagePrimitives.FastGenericComparer) by manofstick · Pull Request #5278 · dotnet/fsharp

manofstick · 2018-07-01T07:28:52Z

This is a standalone improvement, as is #5112, but this is branched off the tail of that PR as I see it being approved and integrated first, as this is still currently a WIP.

vasily-kirichenko · 2018-07-01T07:43:21Z

why not if...then...else?

that's what was there previously...

vasily-kirichenko · 2018-07-01T07:46:58Z

sbyte[] will match on this branch as well. Are you sure GenericHashByteArray will produce correct result in this case?

yep, I know, still WIP...

vasily-kirichenko · 2018-07-01T07:50:59Z

This whole condition is fully duplicated on line 1152. Maybe extract it into a function?

not the same - strings

I wouldn't bother too much checking this yet. I'm still a while off completing it...

this is done in the final PR #5307 btw, so assuming the whole chain of PRs is accepted...

vasily-kirichenko · 2018-07-13T18:54:50Z

@manofstick merge conflict!

manofstick · 2018-07-13T19:23:05Z

@vasily-kirichenko

Not being the master of git (or github) I don't know the process to fix.

The conflicted code can just be deleted (it was a line you added, which is now redundant). So the solution is to just ignore the mainline.

Should I could rebase off master?

manofstick · 2018-07-13T20:08:52Z

Slightly modified tests from #5112... (so they don't necessarily make sense, more just to try as many cases...)

1) https://gist.github.com/manofstick/33fefb8ac6b60d401375be738b521ac3

64-bit

test	original	modified	percent
custom dynamic	3599.00	1193.17	33%
custom structural	3614.00	1380.33	38%
custom default	1190.83	1197.33	101%
value dynamic	2958.33	2187.17	74%
value structural	1248.50	1240.00	99%
value default	1245.33	1249.00	100%
gen value dynamic	6026.33	2466.50	41%
gen value structural	4130.17	1503.33	36%
gen value default	4085.83	1524.83	37%
ref dynamic	2680.83	1749.67	65%
ref structural	1214.00	1262.83	104%
ref default	1314.67	1361.67	104%
gen ref dynamic	5882.17	2026.17	34%
gen ref structural	4343.50	1572.33	36%
gen ref default	4502.50	1673.50	37%
tuple dynamic	5618.67	4430.00	79%
tuple structural	1099.67	1070.33	97%
tuple default	7953.00	7844.33	99%
value tuple dynamic	5719.00	1570.17	27%
value tuple structural	5835.83	1558.83	27%
value tuple default	1686.67	1535.17	91%

32-bit

test	original	modified	percent
custom dynamic	11149.33	1192.33	11%
custom structural	11198.00	3798.5	34%
custom default	1280.50	1208.83	94%
value dynamic	9668.33	3648.83	38%
value structural	1337.00	1251.33	94%
value default	1321.83	1259.83	95%
gen value dynamic	19472.33	6444.83	33%
gen value structural	11084.00	3522.83	32%
gen value default	10975.00	3560.67	32%
ref dynamic	10149.17	3766.83	37%
ref structural	1353.50	1281.67	95%
ref default	1505.67	1438.83	96%
gen ref dynamic	20249.33	6484.83	32%
gen ref structural	12903.83	4804.17	37%
gen ref default	11318.67	3961.5	35%
tuple dynamic	18689.67	11176.33	60%
tuple structural	1326.33	1256.67	95%
tuple default	9330.17	8640.83	93%
value tuple dynamic	17674.67	1348	8%
value tuple structural	17620.83	1336.83	8%
value tuple default	1439.33	1349.5	94%

manofstick · 2018-07-13T20:11:51Z

2) https://gist.github.com/manofstick/04ba0c70c398bf5edeaba9b17d0b17c5

test	original	modified	percent
mapTest 32-bit	18169	3356	18%
mapTest 64-bit	7414	4441	60%

manofstick · 2018-07-13T20:14:23Z

3) https://gist.github.com/manofstick/bd374436a6d40218b2d836db34c494ca

test	original	modified	percent
32-bit	77167	68278	89%
64-bit	142949	74615	52%

manofstick · 2018-07-13T20:18:04Z

4) https://gist.github.com/manofstick/258edf7e7d39a76e9d1cdf0316ae2b47

test	original	modified	percent
non-generic 32-bit	56360	24545	44%
generic 32-bit	117833	46421	39%
non-generic 64-bit	23651	18227	77%
generic 64-bit	44738	22051	49%

manofstick · 2018-07-13T20:24:16Z

5) https://gist.github.com/manofstick/847922bcce2e2f47d3eca033ed9dc068

test	original	modified	percent
32-bit	897.4	363	40%
64-bit	499.2	306.8	61%

manofstick · 2018-07-13T20:28:20Z

6) https://gist.github.com/manofstick/b4fa5acc1abe3ca73a77a7eea12d205a

test	original	modified	percent
32-bit	9707.8	575.8	6%
64-bit	3733.8	498.8	13%

manofstick · 2018-07-13T20:29:20Z

@dsyme - I think this is done.

…insic

…iends (as they have special handling)

…ized GetHashCode)

…(+ comments)

…or EqualityComparer

… unnecessary

…sed where a stable one was required

KevinRansom · 2020-05-28T06:55:34Z

@dsyme , @manofstick , @cartermp -- what do we wnt to do with this PR? It looks beneficial, but the momentum just died on it!

Should I close it, or will we revisit it in the near future?

Thanks

Kevin

KevinRansom · 2020-05-28T07:43:16Z

@manofstick you will still do these really cool PR's in the future right, I learn a ton looking through them :-)

manofstick · 2020-05-28T08:54:12Z

@KevinRansom ha! well that's good! if I do have any more ideas I'll give 'em a crack, but I think most of my ideas are a bit too radical to get slurped upstream...

KevinRansom · 2020-05-28T09:17:22Z

@manofstick , I am not so sure, I just think the rate of change of some stuff is so slow that FUD and real life(TM) gets in the way.

vasily-kirichenko reviewed Jul 1, 2018
View reviewed changes

This was referenced Jul 5, 2018
[CompilerPerf] Faster equality in generic contexts #5112
Closed
Fix sbyte arrays comparison #5267
Closed

manofstick force-pushed the nobox_comparer branch from da96e12 to 3c288c6Compare July 11, 2018 07:07

manofstick changed the title ~~[WIP] [CompilerPerf] Extends #5112 ideas to Comparers (i.e >, >=, <, <= and LanguagePrimitives.FastGenericComparer)~~[CompilerPerf] Extends #5112 ideas to Comparers (i.e >, >=, <, <= and LanguagePrimitives.FastGenericComparer)Jul 13, 2018

manofstick mentioned this pull request Jul 14, 2018
[CompilerPerf] Using reflection to enhance #5112 and #5278 #5307
Closed

TIHan added Tenet-Performance Area-Library Issues for FSharp.Core not covered elsewhere labels Jul 16, 2018

dsyme added the Candidate for F# vNext label Jul 16, 2018

manofstick mentioned this pull request Aug 7, 2018
[CompilerPerf] Removed TaggedCollections from Compiler #5463
Closed

manofstick added 7 commits August 7, 2018 15:59

Helper function for FastGenericEqualityComparerTable
ff6b02d

Use the default equality comparer where applicable
fbf7cc0

Avoid calls to GenericEqualityObj for known types
4345590

Avoid boxing in the "standard" use of GenericEqualityWithComparerIntr…
02c028a
…insic

Added method to avoid tail calls
0e0c69b

Implemented hashing
61f79c6

Additional use of EqualityComparer.Default
11a95c2

manofstick added 19 commits August 7, 2018 15:59

Save unnecessary type checks when more information is known
ef8aafe

Removed now unused objects, and other minor cleanup
4e4c60e

Modified Optimizer to manually inline GenericEqualityIntrinsic and fr…
01734b6
…iends (as they have special handling)

Fixed SurfaceArea
3a30af3

Ensure FSharp.Core has the optimization functions (and added comments)
9e24a31

Remove IL bloat from this PR as perdotnet#5212
4130d6a

Remove null checks for IStructuralEquality Value Types
e7d618b

Consolidated Type Specific Array Equality functions
a72a1de

Fix compiler call via FSharpFunc.Invoke rather than direct
469f55c

Replaced duplicated GetHashCode code with inline function
0e7b688

Common array EqualityComparers (for types that previously had special…
4dc1a79
…ized GetHashCode)

Fix regression in regards to hash code on fast-path covariant arrays …
5b80e90
…(+ comments)

Similar treatment within prim-types for Comparer asdotnet#5112was f…
ab13281
…or EqualityComparer

Moved throwing exceptions closer
523f445

Added comparison usage, so could remove exception catching logic when…
ec8d87a
… unnecessary

Consolidated functions
c281065

Consolidated ArrayComparisons and addressed issuedotnet#5263
07467b7

Fixed bug introduced indotnet#5278where an unstable sort could be u…
73b94da
…sed where a stable one was required

Removed now unnecessary optimization from stableSortWithKeysAndComparer
f5298fd

manofstick force-pushed the nobox_comparer branch from cd6109c to f5298fdCompare August 7, 2018 09:22

manofstick added a commit to manofstick/visualfsharp that referenced this pull request Aug 7, 2018
Fixed bug introduced indotnet#5278where an unstable sort could be u…
508111f
…sed where a stable one was required

manofstick added a commit to manofstick/visualfsharp that referenced this pull request Aug 7, 2018
Fixed bug introduced indotnet#5278where an unstable sort could be u…
b9433c2
…sed where a stable one was required

manofstick added a commit to manofstick/visualfsharp that referenced this pull request Aug 12, 2018
Fixed bug introduced indotnet#5278where an unstable sort could be u…
0f42ffa
…sed where a stable one was required

manofstick closed this May 28, 2020

vzarytovskii mentioned this pull request Oct 16, 2023
Resurrect compiler perf improvements PRs #16125
Closed

Uh oh!

Conversation

manofstick commented Jul 1, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vasily-kirichenko commented Jul 13, 2018

Uh oh!

manofstick commented Jul 13, 2018• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

manofstick commented Jul 13, 2018

1) https://gist.github.com/manofstick/33fefb8ac6b60d401375be738b521ac3

Uh oh!

manofstick commented Jul 13, 2018

2) https://gist.github.com/manofstick/04ba0c70c398bf5edeaba9b17d0b17c5

Uh oh!

manofstick commented Jul 13, 2018

3) https://gist.github.com/manofstick/bd374436a6d40218b2d836db34c494ca

Uh oh!

manofstick commented Jul 13, 2018

4) https://gist.github.com/manofstick/258edf7e7d39a76e9d1cdf0316ae2b47

Uh oh!

manofstick commented Jul 13, 2018

5) https://gist.github.com/manofstick/847922bcce2e2f47d3eca033ed9dc068

Uh oh!

manofstick commented Jul 13, 2018

6) https://gist.github.com/manofstick/b4fa5acc1abe3ca73a77a7eea12d205a

Uh oh!

manofstick commented Jul 13, 2018

Uh oh!

KevinRansom commented May 28, 2020

Uh oh!

KevinRansom commented May 28, 2020

Uh oh!

manofstick commented May 28, 2020

Uh oh!

KevinRansom commented May 28, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

manofstick commented Jul 13, 2018•
edited
Loading