Uh oh!
There was an error while loading. Please reload this page.
Fix AST compilation in netcoreapp - #7912
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
eiriktsarpalis
commented
Dec 4, 2019
/azp run |
|
Commenter does not have sufficient privileges for PR 7912 in repo dotnet/fsharp |
TIHan
left a comment
There was a problem hiding this comment.
IMHO, we should not expose PrimaryAssembly. Instead, we should be thinking about trying to remove PrimaryAssembly altogether and getting the compiler to be framework agnostic.
TIHan
commented
Dec 11, 2019
After talking with @terrajobst , having the notion of a |
eiriktsarpalis
commented
Dec 12, 2019
That's fair, however the scope of this PR is to bring the ast compiler on par with the cli arguments, as they currently stand. |
663d0c0 to
3c4e39cCompareeiriktsarpalis
commented
Jan 7, 2020
Rebased on top of latest changes |
3c4e39c to
d1b5137Compared1b5137 to
9b62ae4Compare9b62ae4 to
ec43de5Compareeiriktsarpalis
commented
Feb 13, 2020
bb8b53e to
77727b1Comparecartermp
commented
Jun 27, 2020
@eiriktsarpalis is this work dependent on #8043? |
eiriktsarpalis
commented
Jun 29, 2020
cartermp
commented
Jun 29, 2020
Makes sense. |
eiriktsarpalis
commented
Aug 10, 2020
Are you planning on merging #8043 for 5.0? If not I think I should just go ahead and merge this, since it fixes a broken component of the compiler. |
cartermp
commented
Aug 10, 2020
I think that's @TIHan's call, but conservatively I'm going to estimate that it won't get in for F# 5. |
… implementation with cli pipeline
This reverts commit 596d6c1c4a20581f5f9ce861629b14077adfebed.
77727b1 to
927a8f5Compareeiriktsarpalis
commented
Aug 11, 2020
I've rebased on top of latest master. |
terrajobst
commented
Aug 11, 2020
To expand on this: you should chat with @jaredpar and how Roslyn solved this. AFAIK the core assembly is determined by picking the assembly that in turn has no references. If checking that is expensive, you could try a fast pass by checking for |
jaredpar
commented
Aug 11, 2020
The core assembly has no references and contains
FWIW: This check hasn't ever come up as a perf issue for us |
Thanks for this @eiriktsarpalis |
The FSCS untyped AST compilation facility is currently broken in .NET Core since the implementation is hardcoding the target profile to mscorlib.
This PR:
PrimaryAssemblyparameter in the AST Compile* functions.