Skip to content

Remove Finalize on obj holder for RawByteMemory - #8237

Merged
TIHan merged 4 commits into
dotnet:masterfrom
TIHan:opt/remove-finalize1
Jan 20, 2020
Merged

Remove Finalize on obj holder for RawByteMemory#8237
TIHan merged 4 commits into
dotnet:masterfrom
TIHan:opt/remove-finalize1

Conversation

@TIHan

@TIHanTIHan commented Jan 16, 2020

Copy link
Copy Markdown
Contributor

We do not need a Finalize on the object that is holding a memory mapped file for RawByteMemory. Memory mapped file implementation already uses a safe handle and does it for us.

cartermp
cartermp reviewed Jan 17, 2020
View reviewed changes
Comment threadsrc/absil/bytes.fs Outdated
@TIHan
TIHan merged commit b7a3bf8 into dotnet:masterJan 20, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
@TIHan@nosami
Remove Finalize on obj holder for RawByteMemory (dotnet#8237)
a0bb444
* Remove Finalize on obj holder for RawByteMemory as memory mapped files use a safe handler.
* Removed Finalize from SafeUnamanagedMemoryStream as it is an impl detail for viewing RawByteMemory as a stream
* Remove new
* Update bytes.fs
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@cartermpcartermpcartermp approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TIHan@cartermp