Skip to content

improve build telemetry - #8239

Merged
brettfo merged 2 commits into
dotnet:masterfrom
brettfo:build-telemetry
Jan 17, 2020
Merged

improve build telemetry#8239
brettfo merged 2 commits into
dotnet:masterfrom
brettfo:build-telemetry

Conversation

@brettfo

Copy link
Copy Markdown
Member

Since our build uses a custom script, this PR adds an explicit call to the Arcade function Write-PipelineTelemetryError in the root catch block. To handle the different stages of the build, two script-level variables are created, $BuildCategory and $BuildMessage, that get updated so that in the case of a failure, the contents are relevant.

@brettfo
brettfo requested a review from chcostaJanuary 16, 2020 21:28
@brettfobrettfo changed the title add windows build telemetryimprove build telemetryJan 17, 2020
@chcosta

Copy link
Copy Markdown
Member

Is there a test job we can look at to validate this works as expected? ie, have you tried forcing a failure or something?

@brettfo

Copy link
Copy Markdown
MemberAuthor

Good call, I just pushed a commit with a bad test that should catch on both Windows and Linux. If the build telemetry gets classified appropriately I'll walk back that commit.

@brettfo
brettfoforce-pushed the build-telemetry branch 2 times, most recently from fb4da6c to cda9234CompareJanuary 17, 2020 05:33
@brettfo

Copy link
Copy Markdown
MemberAuthor

Hijacked test resulted in the appropriate log lines and failure reasons:

Linux/Mac:
##[error](NETCORE_ENGINEERING_TELEMETRY=Test) Error running tests (exit code '1').

Windows:
##[error](NETCORE_ENGINEERING_TELEMETRY=Test) Failure running tests

I'll revert the bad test and this can be merged as soon as it's green.

@brettfo
brettfo merged commit 04119ce into dotnet:masterJan 17, 2020
@brettfo
brettfo deleted the build-telemetry branch January 17, 2020 11:44
@chcosta

Copy link
Copy Markdown
Member

Looks good, thanks Brett

nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
* add windows build telemetry
* fix linux build telemetry
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@brettfo@chcosta@KevinRansom