Skip to content

add more tests for SRTP resolution - #8318

Merged
TIHan merged 2 commits into
dotnet:masterfrom
dsyme:t4
Jan 22, 2020
Merged

add more tests for SRTP resolution#8318
TIHan merged 2 commits into
dotnet:masterfrom
dsyme:t4

Conversation

@dsyme

@dsymedsyme commented Jan 22, 2020

Copy link
Copy Markdown
Contributor

This adds four cases - one positive and three negative - related to SRTP constraint resolution

The aim is to pin down existing behaviour so we know if things change in the future, especially in subtle interactions with things like whether a type is sealed or not.

@dsyme

Copy link
Copy Markdown
ContributorAuthor

@cartermp@TIHan simple to review, thanks, just pinning known cases of interest down before we do anything in this area

@dsyme
dsyme requested a review from TIHanJanuary 22, 2020 17:15
@TIHan
TIHan merged commit 5ef3492 into dotnet:masterJan 22, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dsyme@cartermp@TIHan