Skip to content

only dump package list if the run failed - #8320

Merged
brettfo merged 1 commit into
dotnet:masterfrom
brettfo:dump-packages
Jan 22, 2020
Merged

only dump package list if the run failed#8320
brettfo merged 1 commit into
dotnet:masterfrom
brettfo:dump-packages

Conversation

@brettfo

@brettfobrettfo commented Jan 22, 2020

Copy link
Copy Markdown
Member

Building on #8303, this ensures the package dump always has a chance to run, but only does so if something failed.

PR includes a purposeful break to ensure the correct thing happens. Once that behavior has been observed, I'll remove the failure.

Build contained the expected artifacts.

@brettfobrettfo changed the title [WIP] only dump package list if the run failedonly dump package list if the run failedJan 22, 2020
@brettfo
brettfo requested review from TIHan and cartermpJanuary 22, 2020 20:43
@brettfo
brettfo merged commit 36d7799 into dotnet:masterJan 22, 2020
@brettfo
brettfo deleted the dump-packages branch January 22, 2020 21:50
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@brettfo@KevinRansom