Skip to content

add xmldoc about Seq.rev consume input sequence - #903

Merged
dsyme merged 3 commits into
dotnet:masterfrom
enricosada:xmldoc_seqrev
Jan 28, 2016
Merged

add xmldoc about Seq.rev consume input sequence#903
dsyme merged 3 commits into
dotnet:masterfrom
enricosada:xmldoc_seqrev

Conversation

@enricosada

Copy link
Copy Markdown
Contributor

ref #902

phrase is ok?

Comment threadsrc/fsharp/FSharp.Core/seq.fsi Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest

This function consumes the whole input sequence before yielding the first element of the reversed sequence.

@enricosada

Copy link
Copy Markdown
ContributorAuthor

used @dsyme phrase

@enricosada

Copy link
Copy Markdown
ContributorAuthor

others function who consume the whole input? /cc @vasily-kirichenko@forki@kolektiv

@forki

Copy link
Copy Markdown
Contributor

@7sharp9 identified: sort, foldBack, reduceBack, tryFindBack, findBack, scanBack, tryFindIndexBack, findIndexBack, sortWith, permute, mapFold, mapFoldBack, splitinto

@enricosada

Copy link
Copy Markdown
ContributorAuthor

*Back it's ok
*reduce, *fold, sort, scan ok

but splitInto too? why? /cc @7sharp9 nvm i was thinking about chunkInto

@enricosadaenricosada changed the title add xmldoc about Seq.rev consume input sequence[WIP] add xmldoc about Seq.rev consume input sequenceJan 27, 2016
…k, tryFindIndexBack, findIndexBack, sortWith, permute, mapFold, mapFoldBack, splitinto
@enricosadaenricosada changed the title [WIP] add xmldoc about Seq.rev consume input sequenceadd xmldoc about Seq.rev consume input sequenceJan 28, 2016
@enricosada

Copy link
Copy Markdown
ContributorAuthor

added the other functions, thx @forki and @7sharp9 .
@dsyme pharse are ok?

@dsyme

Copy link
Copy Markdown
Contributor

This looks fine. Since it's just XML documentation I will merge it.

dsyme added a commit that referenced this pull request Jan 28, 2016
add xmldoc about Seq.rev consume input sequence
@dsyme
dsyme merged commit a458989 into dotnet:masterJan 28, 2016
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@enricosada@forki@dsyme@msftclas