Skip to content

Adjust FS-1075 : nullable interop - apply rule to all arguments, not just optional ones - #9316

Merged
KevinRansom merged 5 commits into
dotnet:masterfrom
dsyme:feature/nullable-interop
May 29, 2020
Merged

Adjust FS-1075 : nullable interop - apply rule to all arguments, not just optional ones#9316
KevinRansom merged 5 commits into
dotnet:masterfrom
dsyme:feature/nullable-interop

Conversation

@dsyme

Copy link
Copy Markdown
Contributor

This is a potential adjustment to RFC FS-1075 which is currently in preview

The adjustment is based on this usability feedback, which indicates that we should extend this to interoperating with non-optional nullable-typed arguments

@dsyme
dsymeforce-pushed the feature/nullable-interop branch from 16eb5a5 to 6f0332dCompareMay 27, 2020 18:38
@cartermp
cartermp requested review from KevinRansom and TIHanMay 28, 2020 15:26
@cartermpcartermp changed the title Adjust FS-1075 : nullable interopAdjust FS-1075 : nullable interop - apply rule to all arguments, not just optional onesMay 28, 2020

@cartermpcartermp left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval here is for the scenario and test cases, which I feel are adequate. Not for the implementation.

This change definitely makes using packages like Microsoft.Data.Analysis more pleasant.

@KevinRansom
KevinRansom merged commit 3d19992 into dotnet:masterMay 29, 2020
nosami pushed a commit to xamarin/visualfsharp that referenced this pull request Feb 23, 2021
…just optional ones (dotnet#9316)
* adjust non-optional nullable interop
* adjust non-optional nullable interop
* fix error messages
* fix baseline
* fix baseline
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@dsyme@KevinRansom@cartermp