Uh oh!
There was an error while loading. Please reload this page.
Factor out CompilerAssert, TestFramework, ILChecker and Utilities - #9350
Conversation
KevinRansom
commented
May 31, 2020
Nice start. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
TIHan
left a comment
There was a problem hiding this comment.
This looks good. Since we don't know what the name is yet, the current name is fine and can address it later.
Glad we are starting to separate this.
KevinRansom
commented
Jun 1, 2020
@vzarytovskii , merge this when you ever want. |
| #endif | ||
| let inline getTestsDirectory dir = __SOURCE_DIRECTORY__ ++ dir | ||
| let testConfig' = getTestsDirectory >> testConfig |
There was a problem hiding this comment.
I feel it would be better to hide the other testConfig rather than making a "prime":
- minimizes the changes
- the underlying
testConfigis not used anywhere
I stumbled on this change while rebasing a PR where I add a test in this file, it would have just worked using the F# feature of hidding symbols.
There was a problem hiding this comment.
It makes sense, will most likely be done as part of bigger tests refactoring.
…tnet#9350) * [WIP] Factor out CompilerAsserts, TestFramework, ILChecker to separate library * [WIP] +NUnit reference; Put Utilities.fs under module * Fixed tests to use new helpers library * Added <NoWarn>3186</NoWarn> to the FSharpSuite.Tests. * Added missing import for the TestHelpers. * Added missing solution entries for the project * Fix tests.fs to run tests with proper path * Fixed more paths in the tests * More fixes to test paths * More fixes to test paths (again)
As part of the tests refactoring and restructuring initiaitive, created a new project with test helpers.
As a first step - moved CompilerAssert, TestFramework, ILChecker and Utilities there, so it will be easier to reuse in the future.
PS: Naming is hard, I've called it FSharp.TestHelpers for now, can be renamed if necessary.