Uh oh!
There was an error while loading. Please reload this page.
Add $schema to cgmanifest.json - #1035
Conversation
jonpryor
commented
Sep 6, 2022
What's "interesting" about this PR is that it's "not quite right"; see also: dotnet/android#7342 In particular, if we take the new contents at https://github.com/xamarin/java.interop/blob/c39a8b1509da69827f6a1321d26069c0bc40915d/tools/java-source-utils/CGManifest.json and use https://www.jsonschemavalidator.net/, it doesn't validate:
If we add the required This is doubly odd since the PR message itself mentions using "camel case for the properties", yet the PR didn't change the casing at all. |
jonpryor
commented
Sep 6, 2022
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This pull request adds the JSON schema for
cgmanifest.json.FAQ
Why?
A JSON schema helps you to ensure that your
cgmanifest.jsonfile is valid.JSON schema validation is a build-in feature in most modern IDEs like Visual Studio and Visual Studio Code.
Most modern IDEs also provide code-completion for JSON schemas.
How can I validate my
cgmanifest.jsonfile?Most modern IDEs like Visual Studio and Visual Studio Code have a built-in feature to validate JSON files.
You can also use this small script to validate your
cgmanifest.jsonfile.Why does it suggest camel case for the properties?
Component Detection is able to read camel case and pascal case properties.
However, the JSON schema doesn't have a case-insensitive mode.
We therefore suggest camel case as it's the most common format for JSON.
Why is the diff so large?
To deserialize the
cgmanifest.jsonfile, we useJSON.parse().However, to serialize the JSON again we use
prettier.We found that, in general, it gave smaller diffs than the default
JSON.stringify()function.