This repository was archived by the owner on Aug 27, 2026. It is now read-only.

Remove legacy NET preprocessor paths - #1451

Merged
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define
Jun 9, 2026
Merged

Remove legacy NET preprocessor paths#1451
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

Draft experiment.

This removes legacy NET/non-NET preprocessor branches and stale legacy TFM references from Java.Interop now that the active repo targets are modern .NET or netstandard2.0 support libraries.

Changes:

  • Make modern .NET paths unconditional in Java.Interop and Java.Runtime.Environment.
  • Remove #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 guarded code outside external/.
  • Stop generated XAJavaInterop1 output from emitting dummy non-NET compatibility attributes.
  • Remove the empty generator support stub that only existed for !NET.
  • Remove stale net472/monoandroid/old .NET TFM references outside external/, including the invocation-overhead net472 run path.

Validation:

  • Remaining NET/version guard refs outside external/: 0
  • Remaining legacy TFM refs outside external/: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop-Tests/Java.Interop-Tests.csproj
    • Passed: 671, Failed: 0, Skipped: 4
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/generator-Tests/generator-Tests.csproj
    • Passed: 455, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers-Tests.csproj
    • Passed: 47, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet build tests/invocation-overhead/invocation-overhead.csproj
    • Build succeeded

Notes:

  • Full dotnet build Java.Interop.sln was attempted but still hits existing/baseline failures unrelated to this cleanup: the Kotlin Gradle fixture in Xamarin.Android.Tools.Bytecode-Tests, and the current Java.Base generated binding error that also reproduces on the untouched main worktree.

Make modern .NET code paths unconditional and remove obsolete non-NET/generated compatibility branches now that Java.Interop targets current .NET or netstandard2.0 only.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
simonrozsival marked this pull request as ready for review June 9, 2026 10:03
CopilotAI review requested due to automatic review settings June 9, 2026 10:03
@simonrozsivalsimonrozsival added the ready-to-review This PR is ready to review/merge, thanks! label Jun 9, 2026
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy NET/non-NET conditional compilation paths and stale TFM-specific branches across Java.Interop, Java.Runtime.Environment, generator tooling, and associated tests/fixtures, making the modern .NET code paths unconditional.

Changes:

  • Remove #if NET / #if !NET / version-guarded code paths and associated compatibility stubs (including generator-emitted dummy attributes).
  • Update generator and expected outputs to no longer emit legacy guards and to always include modern attributes/suppressions.
  • Simplify test and benchmark infrastructure by dropping old framework-specific branches (e.g., net472 run path).
Show a summary per file
FileDescription
tools/param-name-importer/param-name-importer.csprojAdjust comment to reflect current package-asset rationale.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/NamespaceMapping.csStop emitting legacy dummy SupportedOSPlatformAttribute for !NET.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/ClassGen.csMake trimming suppression attribute emission unconditional in generated registrations.
tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers/JavaNativeTypeManagerTests.csRemove legacy NET/non-NET expected values.
tests/Java.Interop-Tests/Java.Interop/JniRuntimeJniValueManagerContract.csRemove legacy Mono/non-core runtime contract fixture.
tests/Java.Interop-Tests/Java.Interop/JniPeerMembersTests.csRemove NET guards around tests and helper types.
tests/Java.Interop-Tests/Java.Interop/JavaVMFixture.csMake fallback/replacement type logic unconditional (remove NET guards).
tests/invocation-overhead/invocation-overhead.targetsDrop net472 run target and unify run path.
tests/invocation-overhead/invocation-overhead.csRemove NET-only compilation blocks and keep modern code path.
tests/generator-Tests/SupportFiles/JavaTypeParametersAttribute.csRemove legacy !NET stub support file.
tests/generator-Tests/Integration-Tests/Compiler.csAlways define NET and always reference System.Runtime.dll facade for compilation.
tests/generator-Tests/Integration-Tests/BaseGeneratorTest.csRemove NET-guarded execution of JavaInterop1 target runs.
tests/generator-Tests/expected.xaji/TestInterface/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/TestInterface/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Streams/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Streams/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/ParameterXPath/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/ParameterXPath/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NonStaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NonStaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NestedTypes/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NestedTypes/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.util.List/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.util.List/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.lang.Object/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/GenericArguments/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/GenericArguments/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/CSharpKeywords/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/CSharpKeywords/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_ClassParse/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_ClassParse/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Constructors/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Constructors/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Arrays/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Arrays/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Adapters/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Adapters/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/AccessModifiers/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/AccessModifiers/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
src/Java.Runtime.Environment/Java.Interop/JreTypeManager.csRemove NET-only compile guard to make JRE type manager unconditional.
src/Java.Runtime.Environment/Java.Interop/JreRuntime.csRemove NET/non-NET branching in type manager selection and loader implementation.
src/Java.Interop/Java.Interop/ManagedPeer.csRemove legacy string marshaling path and always use span-based registration.
src/Java.Interop/Java.Interop/JniTypeSignature.csRemove legacy hash code implementation branch and use modern overload.
src/Java.Interop/Java.Interop/JniType.csMake helper TryParse/TryGet*Method APIs unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniRuntime.JniTypeManager.csMake replacement/fallback APIs unconditional and remove NET-only obsolete guards.
src/Java.Interop/Java.Interop/JniRuntime.csRemove NET9+ conditional around Debugger.BreakForUserUnhandledException.
src/Java.Interop/Java.Interop/JniPeerMembers.JniStaticMethods.csMake replacement/fallback lookup paths unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods.csMake replacement lookup unconditional and update stack-trace comment path.
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods_Invoke.csRemove !NET short-circuiting and always enable static redirect invoke logic.
src/Java.Interop/Java.Interop/JniPeerMembers.csMake replacement type lookup unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMethodInfo.csMake redirect metadata fields unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMemberSignature.csRemove NET-only compilation guard for signature type.
src/Java.Interop/Java.Interop/JniEnvironment.Types.csMake TryFindClass unconditional and broaden DEBUG-only diagnostics.
src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaArray.csUpdate nullable-contract comment and remove trailing whitespace.
src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.csRemove NETSTANDARD2_0 conditional logic around IJavaPeerable checks.
Documentation/Motivation.mdUpdate motivation text to remove obsolete legacy framework references.

Copilot's findings

  • Files reviewed: 78/78 changed files
  • Comments generated: 1

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR correctly removes all legacy #if NET, #if !NET, #if NETCOREAPP, #if NET5_0_OR_GREATER, #if NET9_0_OR_GREATER, and #if NETSTANDARD2_0 preprocessor branches from files outside external/. Since all projects target net10.0, these guards were always-true (or always-false) dead code.

What I verified

  • Correctness: In every case, the kept code path matches what was already active under net10.0. No behavioral changes.
  • Debugger.BreakForUserUnhandledException (JniRuntime.cs): API introduced in .NET 9, safe to use unconditionally on net10.0.
  • JavaNativeTypeManager.cs: NETSTANDARD2_0 fallback removed — correct since the project now targets only net10.0, not netstandard2.0.
  • Generator codegen (ClassGen.cs, NamespaceMapping.cs): Dummy SupportedOSPlatformAttribute for !NET removed; #if NET5_0_OR_GREATER around [UnconditionalSuppressMessage] removed — both consistent with modern .NET only.
  • Expected test output files: All updated consistently with the generator changes.
  • JvmLibraryHandler.Create(): Default handler correctly remains NativeLibraryJvmLibraryHandler (the NET path).
  • invocation-overhead: net472 target removed; run target renamed from _Run_netcoreapp to _Run.
  • Zero remaining NET/version guards outside external/ confirmed via grep.

CI status

⏳ The dotnet.java-interop CI build is queued but has not run yet. The author reports manual test results (671 passed for Java.Interop-Tests, 455 for generator-Tests, 47 for JCW-Tests) which is encouraging, but CI should be green before merging.

Issues found

SeverityCountCategory
💡1Formatting (double blank lines artifact)

The only issue is minor double blank lines left behind in 8 files after removing #if/#endif directives — see inline comment for the full list.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 14.5M

@@ -1,4 +1,3 @@
#if NET

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 💡 Formatting — Removing #if NET / #endif guards left behind double consecutive blank lines (or a leading blank line) in several files. The repo convention says "Don't leave random empty lines." These are minor artifacts but easy to clean up in a follow-up pass.

Affected files:

  • src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs (lines 2–3)
  • src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.cs (lines 5–6)
  • src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.cs (lines 4–5)
  • src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.cs (lines 5–6)
  • src/Java.Runtime.Environment/Java.Interop/JreRuntime.cs (lines 216–217, 279–280, 337–338)
  • src/Java.Runtime.Environment/Java.Interop/JreTypeManager.cs (leading blank at line 1, lines 7–8)

Rule: Minimal diffs

@simonrozsival

Copy link
Copy Markdown
MemberAuthor

@copilot address the code review comments

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

CopilotAI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@copilot address the code review comments

Addressed in 94bafb1. I changed JavaNativeTypeManager to resolve Java.Interop.IJavaPeerable with throwOnError: false and added a fallback interface-name check when that type cannot be loaded, so netstandard consumers no longer fail at runtime.

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR does exactly what it says: mechanically removes #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 preprocessor guards from code that now targets only modern .NET (net10.0).

Verified:

  • All removed code paths were the inactive branches (the #if !NET / #else arms). The surviving code is what was already compiling and running.
  • Debugger.BreakForUserUnhandledException (previously #if NET9_0_OR_GREATER) — API available since .NET 9; safe to make unconditional on net10.0.
  • string.GetHashCode(StringComparison) (previously #if NETCOREAPP) — available since .NET Core 2.1; correct to make unconditional.
  • JreRuntime switch statement merge correctly preserves the modern .NET behavior (default → NativeLibraryJvmLibraryHandler).
  • ManagedPeer.RegisterNativeMembers correctly keeps the ReadOnlySpan<char> path and removes the string-based fallback.
  • Generator output changes (ClassGen.cs, NamespaceMapping.cs) are consistent with all 40+ expected test output file updates.
  • Zero remaining NET/NETCOREAPP/NETSTANDARD/version-guard references outside external/ — confirmed.
  • The removed JavaTypeParametersAttribute.cs test support file was a !NET-only stub duplicating the real type; correctly removed.

1 suggestion: A few files have double blank lines left from the mechanical removal (listed in the inline comment). Very minor — can be addressed in a follow-up.

CI note: Only license/cla check is reported (passing). No build/test CI results visible yet — those should be verified before merging.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 12.9M

Comment threadsrc/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs

@jonathanpeppersjonathanpeppers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anything in dotnet/android that uses netstandard2.0 versions of these files:

Image

@jonathanpeppers
jonathanpeppers merged commit 9ca7064 into mainJun 9, 2026
2 checks passed
@jonathanpeppers
jonathanpeppers deleted the dev/simonrozsival/remove-net-define branch June 9, 2026 16:02
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jun 16, 2026
Bumps [external/Java.Interop](https://github.com/dotnet/java-interop) from `b881d21` to [`6820a9cb`](dotnet/java-interop@6820a9c).
## Java.Interop changes pulled in
- [`6820a9c`](dotnet/java-interop@6820a9c) [Java.Interop] Make JavaProxyObject.RegisterNativeMembers private again ([#1468](dotnet/java-interop#1468))
- [`a2159d7`](dotnet/java-interop@a2159d70) Remove NuGet dependency grouping from Dependabot config ([#1459](dotnet/java-interop#1459))
- [`a0ca676`](dotnet/java-interop@a0ca6760) [ci] Update agentic workflows to claude-opus-4.8 ([#1461](dotnet/java-interop#1461))
- [`6d8aef7`](dotnet/java-interop@6d8aef7b) Bump to dotnet/android-tools@1fb68b6 ([#1457](dotnet/java-interop#1457))
- [`cfca8ad`](dotnet/java-interop@cfca8ad) Upgrade gh-aw to v0.79.6 and recompile workflows ([#1460](dotnet/java-interop#1460))
- [`0104236`](dotnet/java-interop@0104236e) [JniValueManager] Make TryConstructPeer virtual ([#1456](dotnet/java-interop#1456))
- [`d7dbad5`](dotnet/java-interop@d7dbad5) Remove Java.Interop.Dynamic ([#1449](dotnet/java-interop#1449))
- [`0244c10`](dotnet/java-interop@0244c10) Split reflection-based JniTypeManager and JniValueManager behavior ([#1441](dotnet/java-interop#1441))
- [`9ca7064`](dotnet/java-interop@9ca7064) [Java.Interop] Remove legacy `NET` preprocessor paths ([#1451](dotnet/java-interop#1451))
- [`cd2fc12`](dotnet/java-interop@cd2fc12) Remove Java.Interop.GenericMarshaler ([#1450](dotnet/java-interop#1450))
See full diff in [compare view](dotnet/java-interop@b881d21...6820a9c).
## Changes in this PR (beyond the submodule bump)
The Java.Interop bump — particularly [#1441](dotnet/java-interop#1441) (split reflection-based `JniTypeManager` and `JniValueManager`) and [#1449](dotnet/java-interop#1449) (removal of `Java.Interop.Dynamic`) — required a number of follow-on changes in `dotnet/android`:
### Runtime / `Mono.Android`
- **Adapt Android runtime to Java.Interop reflection managers** — switch the `JavaInteropTypeManager` / `JavaInteropValueManager` hierarchy to the new reflection-based base types and update type/value manager construction to match.
- **Change base type of value managers and type managers** so the runtime composes correctly with the new Java.Interop split.
- **Suppress reflection manager trim warnings only** — narrow the existing trim suppressions so they apply to the reflection-only managers and don't hide other warnings.
- **Suppress IL2068 on `ManagedTypeManager.GetTypeForSimpleReference`** — annotate the entry point that legitimately requires reflection so trim analysis is satisfied.
### Tests / apkdescs
- **Regenerate `BuildReleaseArm64SimpleDotNet.MonoVM.apkdesc`** to track size changes from the Java.Interop bump.
- **Regenerate Simple `BuildReleaseArm64` apkdescs** (`MonoVM` + `NativeAOT`) from a `Release` SDK so they match what CI produces.
- **Update NativeAOT warning expectations** — `Mono.Android` now produces fewer trim/AOT warnings, so loosen the strict `4 Warning(s)` checks in `SupportedOSPlatformVersion` and `CheckSignApk` to `AssertHasAtMostWarnings (2)` (new helper in `AssertionExtensions`) and drop the `BuildHasTrimmerWarnings` data counts (`3 → 2`, `4 → 3`) accordingly.
### Merges
- Two merges from `origin/main` to keep the branch current and resolve a conflict in `Microsoft.Android.Sdk.TypeMap.Trimmable.targets`.
Co-authored-by: Simon Rozsival <simon@rozsival.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-reviewThis PR is ready to review/merge, thanks!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@simonrozsival@jonathanpeppers
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content
This repository was archived by the owner on Aug 27, 2026. It is now read-only.

Remove legacy NET preprocessor paths - #1451

Merged
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define
Jun 9, 2026
Merged

Remove legacy NET preprocessor paths#1451
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

Draft experiment.

This removes legacy NET/non-NET preprocessor branches and stale legacy TFM references from Java.Interop now that the active repo targets are modern .NET or netstandard2.0 support libraries.

Changes:

  • Make modern .NET paths unconditional in Java.Interop and Java.Runtime.Environment.
  • Remove #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 guarded code outside external/.
  • Stop generated XAJavaInterop1 output from emitting dummy non-NET compatibility attributes.
  • Remove the empty generator support stub that only existed for !NET.
  • Remove stale net472/monoandroid/old .NET TFM references outside external/, including the invocation-overhead net472 run path.

Validation:

  • Remaining NET/version guard refs outside external/: 0
  • Remaining legacy TFM refs outside external/: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop-Tests/Java.Interop-Tests.csproj
    • Passed: 671, Failed: 0, Skipped: 4
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/generator-Tests/generator-Tests.csproj
    • Passed: 455, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers-Tests.csproj
    • Passed: 47, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet build tests/invocation-overhead/invocation-overhead.csproj
    • Build succeeded

Notes:

  • Full dotnet build Java.Interop.sln was attempted but still hits existing/baseline failures unrelated to this cleanup: the Kotlin Gradle fixture in Xamarin.Android.Tools.Bytecode-Tests, and the current Java.Base generated binding error that also reproduces on the untouched main worktree.

Make modern .NET code paths unconditional and remove obsolete non-NET/generated compatibility branches now that Java.Interop targets current .NET or netstandard2.0 only.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
simonrozsival marked this pull request as ready for review June 9, 2026 10:03
CopilotAI review requested due to automatic review settings June 9, 2026 10:03
@simonrozsivalsimonrozsival added the ready-to-review This PR is ready to review/merge, thanks! label Jun 9, 2026
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy NET/non-NET conditional compilation paths and stale TFM-specific branches across Java.Interop, Java.Runtime.Environment, generator tooling, and associated tests/fixtures, making the modern .NET code paths unconditional.

Changes:

  • Remove #if NET / #if !NET / version-guarded code paths and associated compatibility stubs (including generator-emitted dummy attributes).
  • Update generator and expected outputs to no longer emit legacy guards and to always include modern attributes/suppressions.
  • Simplify test and benchmark infrastructure by dropping old framework-specific branches (e.g., net472 run path).
Show a summary per file
FileDescription
tools/param-name-importer/param-name-importer.csprojAdjust comment to reflect current package-asset rationale.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/NamespaceMapping.csStop emitting legacy dummy SupportedOSPlatformAttribute for !NET.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/ClassGen.csMake trimming suppression attribute emission unconditional in generated registrations.
tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers/JavaNativeTypeManagerTests.csRemove legacy NET/non-NET expected values.
tests/Java.Interop-Tests/Java.Interop/JniRuntimeJniValueManagerContract.csRemove legacy Mono/non-core runtime contract fixture.
tests/Java.Interop-Tests/Java.Interop/JniPeerMembersTests.csRemove NET guards around tests and helper types.
tests/Java.Interop-Tests/Java.Interop/JavaVMFixture.csMake fallback/replacement type logic unconditional (remove NET guards).
tests/invocation-overhead/invocation-overhead.targetsDrop net472 run target and unify run path.
tests/invocation-overhead/invocation-overhead.csRemove NET-only compilation blocks and keep modern code path.
tests/generator-Tests/SupportFiles/JavaTypeParametersAttribute.csRemove legacy !NET stub support file.
tests/generator-Tests/Integration-Tests/Compiler.csAlways define NET and always reference System.Runtime.dll facade for compilation.
tests/generator-Tests/Integration-Tests/BaseGeneratorTest.csRemove NET-guarded execution of JavaInterop1 target runs.
tests/generator-Tests/expected.xaji/TestInterface/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/TestInterface/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Streams/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Streams/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/ParameterXPath/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/ParameterXPath/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NonStaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NonStaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NestedTypes/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NestedTypes/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.util.List/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.util.List/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.lang.Object/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/GenericArguments/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/GenericArguments/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/CSharpKeywords/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/CSharpKeywords/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_ClassParse/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_ClassParse/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Constructors/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Constructors/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Arrays/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Arrays/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Adapters/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Adapters/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/AccessModifiers/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/AccessModifiers/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
src/Java.Runtime.Environment/Java.Interop/JreTypeManager.csRemove NET-only compile guard to make JRE type manager unconditional.
src/Java.Runtime.Environment/Java.Interop/JreRuntime.csRemove NET/non-NET branching in type manager selection and loader implementation.
src/Java.Interop/Java.Interop/ManagedPeer.csRemove legacy string marshaling path and always use span-based registration.
src/Java.Interop/Java.Interop/JniTypeSignature.csRemove legacy hash code implementation branch and use modern overload.
src/Java.Interop/Java.Interop/JniType.csMake helper TryParse/TryGet*Method APIs unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniRuntime.JniTypeManager.csMake replacement/fallback APIs unconditional and remove NET-only obsolete guards.
src/Java.Interop/Java.Interop/JniRuntime.csRemove NET9+ conditional around Debugger.BreakForUserUnhandledException.
src/Java.Interop/Java.Interop/JniPeerMembers.JniStaticMethods.csMake replacement/fallback lookup paths unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods.csMake replacement lookup unconditional and update stack-trace comment path.
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods_Invoke.csRemove !NET short-circuiting and always enable static redirect invoke logic.
src/Java.Interop/Java.Interop/JniPeerMembers.csMake replacement type lookup unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMethodInfo.csMake redirect metadata fields unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMemberSignature.csRemove NET-only compilation guard for signature type.
src/Java.Interop/Java.Interop/JniEnvironment.Types.csMake TryFindClass unconditional and broaden DEBUG-only diagnostics.
src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaArray.csUpdate nullable-contract comment and remove trailing whitespace.
src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.csRemove NETSTANDARD2_0 conditional logic around IJavaPeerable checks.
Documentation/Motivation.mdUpdate motivation text to remove obsolete legacy framework references.

Copilot's findings

  • Files reviewed: 78/78 changed files
  • Comments generated: 1

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR correctly removes all legacy #if NET, #if !NET, #if NETCOREAPP, #if NET5_0_OR_GREATER, #if NET9_0_OR_GREATER, and #if NETSTANDARD2_0 preprocessor branches from files outside external/. Since all projects target net10.0, these guards were always-true (or always-false) dead code.

What I verified

  • Correctness: In every case, the kept code path matches what was already active under net10.0. No behavioral changes.
  • Debugger.BreakForUserUnhandledException (JniRuntime.cs): API introduced in .NET 9, safe to use unconditionally on net10.0.
  • JavaNativeTypeManager.cs: NETSTANDARD2_0 fallback removed — correct since the project now targets only net10.0, not netstandard2.0.
  • Generator codegen (ClassGen.cs, NamespaceMapping.cs): Dummy SupportedOSPlatformAttribute for !NET removed; #if NET5_0_OR_GREATER around [UnconditionalSuppressMessage] removed — both consistent with modern .NET only.
  • Expected test output files: All updated consistently with the generator changes.
  • JvmLibraryHandler.Create(): Default handler correctly remains NativeLibraryJvmLibraryHandler (the NET path).
  • invocation-overhead: net472 target removed; run target renamed from _Run_netcoreapp to _Run.
  • Zero remaining NET/version guards outside external/ confirmed via grep.

CI status

⏳ The dotnet.java-interop CI build is queued but has not run yet. The author reports manual test results (671 passed for Java.Interop-Tests, 455 for generator-Tests, 47 for JCW-Tests) which is encouraging, but CI should be green before merging.

Issues found

SeverityCountCategory
💡1Formatting (double blank lines artifact)

The only issue is minor double blank lines left behind in 8 files after removing #if/#endif directives — see inline comment for the full list.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 14.5M

@@ -1,4 +1,3 @@
#if NET

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 💡 Formatting — Removing #if NET / #endif guards left behind double consecutive blank lines (or a leading blank line) in several files. The repo convention says "Don't leave random empty lines." These are minor artifacts but easy to clean up in a follow-up pass.

Affected files:

  • src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs (lines 2–3)
  • src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.cs (lines 5–6)
  • src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.cs (lines 4–5)
  • src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.cs (lines 5–6)
  • src/Java.Runtime.Environment/Java.Interop/JreRuntime.cs (lines 216–217, 279–280, 337–338)
  • src/Java.Runtime.Environment/Java.Interop/JreTypeManager.cs (leading blank at line 1, lines 7–8)

Rule: Minimal diffs

@simonrozsival

Copy link
Copy Markdown
MemberAuthor

@copilot address the code review comments

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

CopilotAI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@copilot address the code review comments

Addressed in 94bafb1. I changed JavaNativeTypeManager to resolve Java.Interop.IJavaPeerable with throwOnError: false and added a fallback interface-name check when that type cannot be loaded, so netstandard consumers no longer fail at runtime.

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR does exactly what it says: mechanically removes #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 preprocessor guards from code that now targets only modern .NET (net10.0).

Verified:

  • All removed code paths were the inactive branches (the #if !NET / #else arms). The surviving code is what was already compiling and running.
  • Debugger.BreakForUserUnhandledException (previously #if NET9_0_OR_GREATER) — API available since .NET 9; safe to make unconditional on net10.0.
  • string.GetHashCode(StringComparison) (previously #if NETCOREAPP) — available since .NET Core 2.1; correct to make unconditional.
  • JreRuntime switch statement merge correctly preserves the modern .NET behavior (default → NativeLibraryJvmLibraryHandler).
  • ManagedPeer.RegisterNativeMembers correctly keeps the ReadOnlySpan<char> path and removes the string-based fallback.
  • Generator output changes (ClassGen.cs, NamespaceMapping.cs) are consistent with all 40+ expected test output file updates.
  • Zero remaining NET/NETCOREAPP/NETSTANDARD/version-guard references outside external/ — confirmed.
  • The removed JavaTypeParametersAttribute.cs test support file was a !NET-only stub duplicating the real type; correctly removed.

1 suggestion: A few files have double blank lines left from the mechanical removal (listed in the inline comment). Very minor — can be addressed in a follow-up.

CI note: Only license/cla check is reported (passing). No build/test CI results visible yet — those should be verified before merging.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 12.9M

Comment threadsrc/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs

@jonathanpeppersjonathanpeppers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anything in dotnet/android that uses netstandard2.0 versions of these files:

Image

@jonathanpeppers
jonathanpeppers merged commit 9ca7064 into mainJun 9, 2026
2 checks passed
@jonathanpeppers
jonathanpeppers deleted the dev/simonrozsival/remove-net-define branch June 9, 2026 16:02
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jun 16, 2026
Bumps [external/Java.Interop](https://github.com/dotnet/java-interop) from `b881d21` to [`6820a9cb`](dotnet/java-interop@6820a9c).
## Java.Interop changes pulled in
- [`6820a9c`](dotnet/java-interop@6820a9c) [Java.Interop] Make JavaProxyObject.RegisterNativeMembers private again ([#1468](dotnet/java-interop#1468))
- [`a2159d7`](dotnet/java-interop@a2159d70) Remove NuGet dependency grouping from Dependabot config ([#1459](dotnet/java-interop#1459))
- [`a0ca676`](dotnet/java-interop@a0ca6760) [ci] Update agentic workflows to claude-opus-4.8 ([#1461](dotnet/java-interop#1461))
- [`6d8aef7`](dotnet/java-interop@6d8aef7b) Bump to dotnet/android-tools@1fb68b6 ([#1457](dotnet/java-interop#1457))
- [`cfca8ad`](dotnet/java-interop@cfca8ad) Upgrade gh-aw to v0.79.6 and recompile workflows ([#1460](dotnet/java-interop#1460))
- [`0104236`](dotnet/java-interop@0104236e) [JniValueManager] Make TryConstructPeer virtual ([#1456](dotnet/java-interop#1456))
- [`d7dbad5`](dotnet/java-interop@d7dbad5) Remove Java.Interop.Dynamic ([#1449](dotnet/java-interop#1449))
- [`0244c10`](dotnet/java-interop@0244c10) Split reflection-based JniTypeManager and JniValueManager behavior ([#1441](dotnet/java-interop#1441))
- [`9ca7064`](dotnet/java-interop@9ca7064) [Java.Interop] Remove legacy `NET` preprocessor paths ([#1451](dotnet/java-interop#1451))
- [`cd2fc12`](dotnet/java-interop@cd2fc12) Remove Java.Interop.GenericMarshaler ([#1450](dotnet/java-interop#1450))
See full diff in [compare view](dotnet/java-interop@b881d21...6820a9c).
## Changes in this PR (beyond the submodule bump)
The Java.Interop bump — particularly [#1441](dotnet/java-interop#1441) (split reflection-based `JniTypeManager` and `JniValueManager`) and [#1449](dotnet/java-interop#1449) (removal of `Java.Interop.Dynamic`) — required a number of follow-on changes in `dotnet/android`:
### Runtime / `Mono.Android`
- **Adapt Android runtime to Java.Interop reflection managers** — switch the `JavaInteropTypeManager` / `JavaInteropValueManager` hierarchy to the new reflection-based base types and update type/value manager construction to match.
- **Change base type of value managers and type managers** so the runtime composes correctly with the new Java.Interop split.
- **Suppress reflection manager trim warnings only** — narrow the existing trim suppressions so they apply to the reflection-only managers and don't hide other warnings.
- **Suppress IL2068 on `ManagedTypeManager.GetTypeForSimpleReference`** — annotate the entry point that legitimately requires reflection so trim analysis is satisfied.
### Tests / apkdescs
- **Regenerate `BuildReleaseArm64SimpleDotNet.MonoVM.apkdesc`** to track size changes from the Java.Interop bump.
- **Regenerate Simple `BuildReleaseArm64` apkdescs** (`MonoVM` + `NativeAOT`) from a `Release` SDK so they match what CI produces.
- **Update NativeAOT warning expectations** — `Mono.Android` now produces fewer trim/AOT warnings, so loosen the strict `4 Warning(s)` checks in `SupportedOSPlatformVersion` and `CheckSignApk` to `AssertHasAtMostWarnings (2)` (new helper in `AssertionExtensions`) and drop the `BuildHasTrimmerWarnings` data counts (`3 → 2`, `4 → 3`) accordingly.
### Merges
- Two merges from `origin/main` to keep the branch current and resolve a conflict in `Microsoft.Android.Sdk.TypeMap.Trimmable.targets`.
Co-authored-by: Simon Rozsival <simon@rozsival.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-reviewThis PR is ready to review/merge, thanks!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@simonrozsival@jonathanpeppers
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 27, 2026. It is now read-only.

Remove legacy NET preprocessor paths - #1451

Merged
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define
Jun 9, 2026
Merged

Remove legacy NET preprocessor paths#1451
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

Draft experiment.

This removes legacy NET/non-NET preprocessor branches and stale legacy TFM references from Java.Interop now that the active repo targets are modern .NET or netstandard2.0 support libraries.

Changes:

  • Make modern .NET paths unconditional in Java.Interop and Java.Runtime.Environment.
  • Remove #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 guarded code outside external/.
  • Stop generated XAJavaInterop1 output from emitting dummy non-NET compatibility attributes.
  • Remove the empty generator support stub that only existed for !NET.
  • Remove stale net472/monoandroid/old .NET TFM references outside external/, including the invocation-overhead net472 run path.

Validation:

  • Remaining NET/version guard refs outside external/: 0
  • Remaining legacy TFM refs outside external/: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop-Tests/Java.Interop-Tests.csproj
    • Passed: 671, Failed: 0, Skipped: 4
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/generator-Tests/generator-Tests.csproj
    • Passed: 455, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers-Tests.csproj
    • Passed: 47, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet build tests/invocation-overhead/invocation-overhead.csproj
    • Build succeeded

Notes:

  • Full dotnet build Java.Interop.sln was attempted but still hits existing/baseline failures unrelated to this cleanup: the Kotlin Gradle fixture in Xamarin.Android.Tools.Bytecode-Tests, and the current Java.Base generated binding error that also reproduces on the untouched main worktree.

Make modern .NET code paths unconditional and remove obsolete non-NET/generated compatibility branches now that Java.Interop targets current .NET or netstandard2.0 only.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
simonrozsival marked this pull request as ready for review June 9, 2026 10:03
CopilotAI review requested due to automatic review settings June 9, 2026 10:03
@simonrozsivalsimonrozsival added the ready-to-review This PR is ready to review/merge, thanks! label Jun 9, 2026
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy NET/non-NET conditional compilation paths and stale TFM-specific branches across Java.Interop, Java.Runtime.Environment, generator tooling, and associated tests/fixtures, making the modern .NET code paths unconditional.

Changes:

  • Remove #if NET / #if !NET / version-guarded code paths and associated compatibility stubs (including generator-emitted dummy attributes).
  • Update generator and expected outputs to no longer emit legacy guards and to always include modern attributes/suppressions.
  • Simplify test and benchmark infrastructure by dropping old framework-specific branches (e.g., net472 run path).
Show a summary per file
FileDescription
tools/param-name-importer/param-name-importer.csprojAdjust comment to reflect current package-asset rationale.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/NamespaceMapping.csStop emitting legacy dummy SupportedOSPlatformAttribute for !NET.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/ClassGen.csMake trimming suppression attribute emission unconditional in generated registrations.
tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers/JavaNativeTypeManagerTests.csRemove legacy NET/non-NET expected values.
tests/Java.Interop-Tests/Java.Interop/JniRuntimeJniValueManagerContract.csRemove legacy Mono/non-core runtime contract fixture.
tests/Java.Interop-Tests/Java.Interop/JniPeerMembersTests.csRemove NET guards around tests and helper types.
tests/Java.Interop-Tests/Java.Interop/JavaVMFixture.csMake fallback/replacement type logic unconditional (remove NET guards).
tests/invocation-overhead/invocation-overhead.targetsDrop net472 run target and unify run path.
tests/invocation-overhead/invocation-overhead.csRemove NET-only compilation blocks and keep modern code path.
tests/generator-Tests/SupportFiles/JavaTypeParametersAttribute.csRemove legacy !NET stub support file.
tests/generator-Tests/Integration-Tests/Compiler.csAlways define NET and always reference System.Runtime.dll facade for compilation.
tests/generator-Tests/Integration-Tests/BaseGeneratorTest.csRemove NET-guarded execution of JavaInterop1 target runs.
tests/generator-Tests/expected.xaji/TestInterface/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/TestInterface/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Streams/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Streams/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/ParameterXPath/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/ParameterXPath/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NonStaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NonStaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NestedTypes/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NestedTypes/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.util.List/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.util.List/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.lang.Object/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/GenericArguments/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/GenericArguments/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/CSharpKeywords/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/CSharpKeywords/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_ClassParse/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_ClassParse/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Constructors/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Constructors/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Arrays/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Arrays/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Adapters/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Adapters/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/AccessModifiers/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/AccessModifiers/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
src/Java.Runtime.Environment/Java.Interop/JreTypeManager.csRemove NET-only compile guard to make JRE type manager unconditional.
src/Java.Runtime.Environment/Java.Interop/JreRuntime.csRemove NET/non-NET branching in type manager selection and loader implementation.
src/Java.Interop/Java.Interop/ManagedPeer.csRemove legacy string marshaling path and always use span-based registration.
src/Java.Interop/Java.Interop/JniTypeSignature.csRemove legacy hash code implementation branch and use modern overload.
src/Java.Interop/Java.Interop/JniType.csMake helper TryParse/TryGet*Method APIs unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniRuntime.JniTypeManager.csMake replacement/fallback APIs unconditional and remove NET-only obsolete guards.
src/Java.Interop/Java.Interop/JniRuntime.csRemove NET9+ conditional around Debugger.BreakForUserUnhandledException.
src/Java.Interop/Java.Interop/JniPeerMembers.JniStaticMethods.csMake replacement/fallback lookup paths unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods.csMake replacement lookup unconditional and update stack-trace comment path.
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods_Invoke.csRemove !NET short-circuiting and always enable static redirect invoke logic.
src/Java.Interop/Java.Interop/JniPeerMembers.csMake replacement type lookup unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMethodInfo.csMake redirect metadata fields unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMemberSignature.csRemove NET-only compilation guard for signature type.
src/Java.Interop/Java.Interop/JniEnvironment.Types.csMake TryFindClass unconditional and broaden DEBUG-only diagnostics.
src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaArray.csUpdate nullable-contract comment and remove trailing whitespace.
src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.csRemove NETSTANDARD2_0 conditional logic around IJavaPeerable checks.
Documentation/Motivation.mdUpdate motivation text to remove obsolete legacy framework references.

Copilot's findings

  • Files reviewed: 78/78 changed files
  • Comments generated: 1

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR correctly removes all legacy #if NET, #if !NET, #if NETCOREAPP, #if NET5_0_OR_GREATER, #if NET9_0_OR_GREATER, and #if NETSTANDARD2_0 preprocessor branches from files outside external/. Since all projects target net10.0, these guards were always-true (or always-false) dead code.

What I verified

  • Correctness: In every case, the kept code path matches what was already active under net10.0. No behavioral changes.
  • Debugger.BreakForUserUnhandledException (JniRuntime.cs): API introduced in .NET 9, safe to use unconditionally on net10.0.
  • JavaNativeTypeManager.cs: NETSTANDARD2_0 fallback removed — correct since the project now targets only net10.0, not netstandard2.0.
  • Generator codegen (ClassGen.cs, NamespaceMapping.cs): Dummy SupportedOSPlatformAttribute for !NET removed; #if NET5_0_OR_GREATER around [UnconditionalSuppressMessage] removed — both consistent with modern .NET only.
  • Expected test output files: All updated consistently with the generator changes.
  • JvmLibraryHandler.Create(): Default handler correctly remains NativeLibraryJvmLibraryHandler (the NET path).
  • invocation-overhead: net472 target removed; run target renamed from _Run_netcoreapp to _Run.
  • Zero remaining NET/version guards outside external/ confirmed via grep.

CI status

⏳ The dotnet.java-interop CI build is queued but has not run yet. The author reports manual test results (671 passed for Java.Interop-Tests, 455 for generator-Tests, 47 for JCW-Tests) which is encouraging, but CI should be green before merging.

Issues found

SeverityCountCategory
💡1Formatting (double blank lines artifact)

The only issue is minor double blank lines left behind in 8 files after removing #if/#endif directives — see inline comment for the full list.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 14.5M

@@ -1,4 +1,3 @@
#if NET

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 💡 Formatting — Removing #if NET / #endif guards left behind double consecutive blank lines (or a leading blank line) in several files. The repo convention says "Don't leave random empty lines." These are minor artifacts but easy to clean up in a follow-up pass.

Affected files:

  • src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs (lines 2–3)
  • src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.cs (lines 5–6)
  • src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.cs (lines 4–5)
  • src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.cs (lines 5–6)
  • src/Java.Runtime.Environment/Java.Interop/JreRuntime.cs (lines 216–217, 279–280, 337–338)
  • src/Java.Runtime.Environment/Java.Interop/JreTypeManager.cs (leading blank at line 1, lines 7–8)

Rule: Minimal diffs

@simonrozsival

Copy link
Copy Markdown
MemberAuthor

@copilot address the code review comments

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

CopilotAI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@copilot address the code review comments

Addressed in 94bafb1. I changed JavaNativeTypeManager to resolve Java.Interop.IJavaPeerable with throwOnError: false and added a fallback interface-name check when that type cannot be loaded, so netstandard consumers no longer fail at runtime.

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR does exactly what it says: mechanically removes #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 preprocessor guards from code that now targets only modern .NET (net10.0).

Verified:

  • All removed code paths were the inactive branches (the #if !NET / #else arms). The surviving code is what was already compiling and running.
  • Debugger.BreakForUserUnhandledException (previously #if NET9_0_OR_GREATER) — API available since .NET 9; safe to make unconditional on net10.0.
  • string.GetHashCode(StringComparison) (previously #if NETCOREAPP) — available since .NET Core 2.1; correct to make unconditional.
  • JreRuntime switch statement merge correctly preserves the modern .NET behavior (default → NativeLibraryJvmLibraryHandler).
  • ManagedPeer.RegisterNativeMembers correctly keeps the ReadOnlySpan<char> path and removes the string-based fallback.
  • Generator output changes (ClassGen.cs, NamespaceMapping.cs) are consistent with all 40+ expected test output file updates.
  • Zero remaining NET/NETCOREAPP/NETSTANDARD/version-guard references outside external/ — confirmed.
  • The removed JavaTypeParametersAttribute.cs test support file was a !NET-only stub duplicating the real type; correctly removed.

1 suggestion: A few files have double blank lines left from the mechanical removal (listed in the inline comment). Very minor — can be addressed in a follow-up.

CI note: Only license/cla check is reported (passing). No build/test CI results visible yet — those should be verified before merging.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 12.9M

Comment threadsrc/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs

@jonathanpeppersjonathanpeppers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anything in dotnet/android that uses netstandard2.0 versions of these files:

Image

@jonathanpeppers
jonathanpeppers merged commit 9ca7064 into mainJun 9, 2026
2 checks passed
@jonathanpeppers
jonathanpeppers deleted the dev/simonrozsival/remove-net-define branch June 9, 2026 16:02
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jun 16, 2026
Bumps [external/Java.Interop](https://github.com/dotnet/java-interop) from `b881d21` to [`6820a9cb`](dotnet/java-interop@6820a9c).
## Java.Interop changes pulled in
- [`6820a9c`](dotnet/java-interop@6820a9c) [Java.Interop] Make JavaProxyObject.RegisterNativeMembers private again ([#1468](dotnet/java-interop#1468))
- [`a2159d7`](dotnet/java-interop@a2159d70) Remove NuGet dependency grouping from Dependabot config ([#1459](dotnet/java-interop#1459))
- [`a0ca676`](dotnet/java-interop@a0ca6760) [ci] Update agentic workflows to claude-opus-4.8 ([#1461](dotnet/java-interop#1461))
- [`6d8aef7`](dotnet/java-interop@6d8aef7b) Bump to dotnet/android-tools@1fb68b6 ([#1457](dotnet/java-interop#1457))
- [`cfca8ad`](dotnet/java-interop@cfca8ad) Upgrade gh-aw to v0.79.6 and recompile workflows ([#1460](dotnet/java-interop#1460))
- [`0104236`](dotnet/java-interop@0104236e) [JniValueManager] Make TryConstructPeer virtual ([#1456](dotnet/java-interop#1456))
- [`d7dbad5`](dotnet/java-interop@d7dbad5) Remove Java.Interop.Dynamic ([#1449](dotnet/java-interop#1449))
- [`0244c10`](dotnet/java-interop@0244c10) Split reflection-based JniTypeManager and JniValueManager behavior ([#1441](dotnet/java-interop#1441))
- [`9ca7064`](dotnet/java-interop@9ca7064) [Java.Interop] Remove legacy `NET` preprocessor paths ([#1451](dotnet/java-interop#1451))
- [`cd2fc12`](dotnet/java-interop@cd2fc12) Remove Java.Interop.GenericMarshaler ([#1450](dotnet/java-interop#1450))
See full diff in [compare view](dotnet/java-interop@b881d21...6820a9c).
## Changes in this PR (beyond the submodule bump)
The Java.Interop bump — particularly [#1441](dotnet/java-interop#1441) (split reflection-based `JniTypeManager` and `JniValueManager`) and [#1449](dotnet/java-interop#1449) (removal of `Java.Interop.Dynamic`) — required a number of follow-on changes in `dotnet/android`:
### Runtime / `Mono.Android`
- **Adapt Android runtime to Java.Interop reflection managers** — switch the `JavaInteropTypeManager` / `JavaInteropValueManager` hierarchy to the new reflection-based base types and update type/value manager construction to match.
- **Change base type of value managers and type managers** so the runtime composes correctly with the new Java.Interop split.
- **Suppress reflection manager trim warnings only** — narrow the existing trim suppressions so they apply to the reflection-only managers and don't hide other warnings.
- **Suppress IL2068 on `ManagedTypeManager.GetTypeForSimpleReference`** — annotate the entry point that legitimately requires reflection so trim analysis is satisfied.
### Tests / apkdescs
- **Regenerate `BuildReleaseArm64SimpleDotNet.MonoVM.apkdesc`** to track size changes from the Java.Interop bump.
- **Regenerate Simple `BuildReleaseArm64` apkdescs** (`MonoVM` + `NativeAOT`) from a `Release` SDK so they match what CI produces.
- **Update NativeAOT warning expectations** — `Mono.Android` now produces fewer trim/AOT warnings, so loosen the strict `4 Warning(s)` checks in `SupportedOSPlatformVersion` and `CheckSignApk` to `AssertHasAtMostWarnings (2)` (new helper in `AssertionExtensions`) and drop the `BuildHasTrimmerWarnings` data counts (`3 → 2`, `4 → 3`) accordingly.
### Merges
- Two merges from `origin/main` to keep the branch current and resolve a conflict in `Microsoft.Android.Sdk.TypeMap.Trimmable.targets`.
Co-authored-by: Simon Rozsival <simon@rozsival.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-reviewThis PR is ready to review/merge, thanks!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@simonrozsival@jonathanpeppers
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 27, 2026. It is now read-only.

Remove legacy NET preprocessor paths - #1451

Merged
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define
Jun 9, 2026
Merged

Remove legacy NET preprocessor paths#1451
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

Draft experiment.

This removes legacy NET/non-NET preprocessor branches and stale legacy TFM references from Java.Interop now that the active repo targets are modern .NET or netstandard2.0 support libraries.

Changes:

  • Make modern .NET paths unconditional in Java.Interop and Java.Runtime.Environment.
  • Remove #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 guarded code outside external/.
  • Stop generated XAJavaInterop1 output from emitting dummy non-NET compatibility attributes.
  • Remove the empty generator support stub that only existed for !NET.
  • Remove stale net472/monoandroid/old .NET TFM references outside external/, including the invocation-overhead net472 run path.

Validation:

  • Remaining NET/version guard refs outside external/: 0
  • Remaining legacy TFM refs outside external/: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop-Tests/Java.Interop-Tests.csproj
    • Passed: 671, Failed: 0, Skipped: 4
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/generator-Tests/generator-Tests.csproj
    • Passed: 455, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers-Tests.csproj
    • Passed: 47, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet build tests/invocation-overhead/invocation-overhead.csproj
    • Build succeeded

Notes:

  • Full dotnet build Java.Interop.sln was attempted but still hits existing/baseline failures unrelated to this cleanup: the Kotlin Gradle fixture in Xamarin.Android.Tools.Bytecode-Tests, and the current Java.Base generated binding error that also reproduces on the untouched main worktree.

Make modern .NET code paths unconditional and remove obsolete non-NET/generated compatibility branches now that Java.Interop targets current .NET or netstandard2.0 only.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
simonrozsival marked this pull request as ready for review June 9, 2026 10:03
CopilotAI review requested due to automatic review settings June 9, 2026 10:03
@simonrozsivalsimonrozsival added the ready-to-review This PR is ready to review/merge, thanks! label Jun 9, 2026
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy NET/non-NET conditional compilation paths and stale TFM-specific branches across Java.Interop, Java.Runtime.Environment, generator tooling, and associated tests/fixtures, making the modern .NET code paths unconditional.

Changes:

  • Remove #if NET / #if !NET / version-guarded code paths and associated compatibility stubs (including generator-emitted dummy attributes).
  • Update generator and expected outputs to no longer emit legacy guards and to always include modern attributes/suppressions.
  • Simplify test and benchmark infrastructure by dropping old framework-specific branches (e.g., net472 run path).
Show a summary per file
FileDescription
tools/param-name-importer/param-name-importer.csprojAdjust comment to reflect current package-asset rationale.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/NamespaceMapping.csStop emitting legacy dummy SupportedOSPlatformAttribute for !NET.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/ClassGen.csMake trimming suppression attribute emission unconditional in generated registrations.
tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers/JavaNativeTypeManagerTests.csRemove legacy NET/non-NET expected values.
tests/Java.Interop-Tests/Java.Interop/JniRuntimeJniValueManagerContract.csRemove legacy Mono/non-core runtime contract fixture.
tests/Java.Interop-Tests/Java.Interop/JniPeerMembersTests.csRemove NET guards around tests and helper types.
tests/Java.Interop-Tests/Java.Interop/JavaVMFixture.csMake fallback/replacement type logic unconditional (remove NET guards).
tests/invocation-overhead/invocation-overhead.targetsDrop net472 run target and unify run path.
tests/invocation-overhead/invocation-overhead.csRemove NET-only compilation blocks and keep modern code path.
tests/generator-Tests/SupportFiles/JavaTypeParametersAttribute.csRemove legacy !NET stub support file.
tests/generator-Tests/Integration-Tests/Compiler.csAlways define NET and always reference System.Runtime.dll facade for compilation.
tests/generator-Tests/Integration-Tests/BaseGeneratorTest.csRemove NET-guarded execution of JavaInterop1 target runs.
tests/generator-Tests/expected.xaji/TestInterface/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/TestInterface/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Streams/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Streams/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/ParameterXPath/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/ParameterXPath/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NonStaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NonStaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NestedTypes/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NestedTypes/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.util.List/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.util.List/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.lang.Object/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/GenericArguments/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/GenericArguments/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/CSharpKeywords/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/CSharpKeywords/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_ClassParse/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_ClassParse/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Constructors/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Constructors/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Arrays/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Arrays/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Adapters/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Adapters/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/AccessModifiers/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/AccessModifiers/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
src/Java.Runtime.Environment/Java.Interop/JreTypeManager.csRemove NET-only compile guard to make JRE type manager unconditional.
src/Java.Runtime.Environment/Java.Interop/JreRuntime.csRemove NET/non-NET branching in type manager selection and loader implementation.
src/Java.Interop/Java.Interop/ManagedPeer.csRemove legacy string marshaling path and always use span-based registration.
src/Java.Interop/Java.Interop/JniTypeSignature.csRemove legacy hash code implementation branch and use modern overload.
src/Java.Interop/Java.Interop/JniType.csMake helper TryParse/TryGet*Method APIs unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniRuntime.JniTypeManager.csMake replacement/fallback APIs unconditional and remove NET-only obsolete guards.
src/Java.Interop/Java.Interop/JniRuntime.csRemove NET9+ conditional around Debugger.BreakForUserUnhandledException.
src/Java.Interop/Java.Interop/JniPeerMembers.JniStaticMethods.csMake replacement/fallback lookup paths unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods.csMake replacement lookup unconditional and update stack-trace comment path.
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods_Invoke.csRemove !NET short-circuiting and always enable static redirect invoke logic.
src/Java.Interop/Java.Interop/JniPeerMembers.csMake replacement type lookup unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMethodInfo.csMake redirect metadata fields unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMemberSignature.csRemove NET-only compilation guard for signature type.
src/Java.Interop/Java.Interop/JniEnvironment.Types.csMake TryFindClass unconditional and broaden DEBUG-only diagnostics.
src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaArray.csUpdate nullable-contract comment and remove trailing whitespace.
src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.csRemove NETSTANDARD2_0 conditional logic around IJavaPeerable checks.
Documentation/Motivation.mdUpdate motivation text to remove obsolete legacy framework references.

Copilot's findings

  • Files reviewed: 78/78 changed files
  • Comments generated: 1

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR correctly removes all legacy #if NET, #if !NET, #if NETCOREAPP, #if NET5_0_OR_GREATER, #if NET9_0_OR_GREATER, and #if NETSTANDARD2_0 preprocessor branches from files outside external/. Since all projects target net10.0, these guards were always-true (or always-false) dead code.

What I verified

  • Correctness: In every case, the kept code path matches what was already active under net10.0. No behavioral changes.
  • Debugger.BreakForUserUnhandledException (JniRuntime.cs): API introduced in .NET 9, safe to use unconditionally on net10.0.
  • JavaNativeTypeManager.cs: NETSTANDARD2_0 fallback removed — correct since the project now targets only net10.0, not netstandard2.0.
  • Generator codegen (ClassGen.cs, NamespaceMapping.cs): Dummy SupportedOSPlatformAttribute for !NET removed; #if NET5_0_OR_GREATER around [UnconditionalSuppressMessage] removed — both consistent with modern .NET only.
  • Expected test output files: All updated consistently with the generator changes.
  • JvmLibraryHandler.Create(): Default handler correctly remains NativeLibraryJvmLibraryHandler (the NET path).
  • invocation-overhead: net472 target removed; run target renamed from _Run_netcoreapp to _Run.
  • Zero remaining NET/version guards outside external/ confirmed via grep.

CI status

⏳ The dotnet.java-interop CI build is queued but has not run yet. The author reports manual test results (671 passed for Java.Interop-Tests, 455 for generator-Tests, 47 for JCW-Tests) which is encouraging, but CI should be green before merging.

Issues found

SeverityCountCategory
💡1Formatting (double blank lines artifact)

The only issue is minor double blank lines left behind in 8 files after removing #if/#endif directives — see inline comment for the full list.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 14.5M

@@ -1,4 +1,3 @@
#if NET

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 💡 Formatting — Removing #if NET / #endif guards left behind double consecutive blank lines (or a leading blank line) in several files. The repo convention says "Don't leave random empty lines." These are minor artifacts but easy to clean up in a follow-up pass.

Affected files:

  • src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs (lines 2–3)
  • src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.cs (lines 5–6)
  • src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.cs (lines 4–5)
  • src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.cs (lines 5–6)
  • src/Java.Runtime.Environment/Java.Interop/JreRuntime.cs (lines 216–217, 279–280, 337–338)
  • src/Java.Runtime.Environment/Java.Interop/JreTypeManager.cs (leading blank at line 1, lines 7–8)

Rule: Minimal diffs

@simonrozsival

Copy link
Copy Markdown
MemberAuthor

@copilot address the code review comments

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

CopilotAI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@copilot address the code review comments

Addressed in 94bafb1. I changed JavaNativeTypeManager to resolve Java.Interop.IJavaPeerable with throwOnError: false and added a fallback interface-name check when that type cannot be loaded, so netstandard consumers no longer fail at runtime.

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR does exactly what it says: mechanically removes #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 preprocessor guards from code that now targets only modern .NET (net10.0).

Verified:

  • All removed code paths were the inactive branches (the #if !NET / #else arms). The surviving code is what was already compiling and running.
  • Debugger.BreakForUserUnhandledException (previously #if NET9_0_OR_GREATER) — API available since .NET 9; safe to make unconditional on net10.0.
  • string.GetHashCode(StringComparison) (previously #if NETCOREAPP) — available since .NET Core 2.1; correct to make unconditional.
  • JreRuntime switch statement merge correctly preserves the modern .NET behavior (default → NativeLibraryJvmLibraryHandler).
  • ManagedPeer.RegisterNativeMembers correctly keeps the ReadOnlySpan<char> path and removes the string-based fallback.
  • Generator output changes (ClassGen.cs, NamespaceMapping.cs) are consistent with all 40+ expected test output file updates.
  • Zero remaining NET/NETCOREAPP/NETSTANDARD/version-guard references outside external/ — confirmed.
  • The removed JavaTypeParametersAttribute.cs test support file was a !NET-only stub duplicating the real type; correctly removed.

1 suggestion: A few files have double blank lines left from the mechanical removal (listed in the inline comment). Very minor — can be addressed in a follow-up.

CI note: Only license/cla check is reported (passing). No build/test CI results visible yet — those should be verified before merging.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 12.9M

Comment threadsrc/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs

@jonathanpeppersjonathanpeppers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anything in dotnet/android that uses netstandard2.0 versions of these files:

Image

@jonathanpeppers
jonathanpeppers merged commit 9ca7064 into mainJun 9, 2026
2 checks passed
@jonathanpeppers
jonathanpeppers deleted the dev/simonrozsival/remove-net-define branch June 9, 2026 16:02
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jun 16, 2026
Bumps [external/Java.Interop](https://github.com/dotnet/java-interop) from `b881d21` to [`6820a9cb`](dotnet/java-interop@6820a9c).
## Java.Interop changes pulled in
- [`6820a9c`](dotnet/java-interop@6820a9c) [Java.Interop] Make JavaProxyObject.RegisterNativeMembers private again ([#1468](dotnet/java-interop#1468))
- [`a2159d7`](dotnet/java-interop@a2159d70) Remove NuGet dependency grouping from Dependabot config ([#1459](dotnet/java-interop#1459))
- [`a0ca676`](dotnet/java-interop@a0ca6760) [ci] Update agentic workflows to claude-opus-4.8 ([#1461](dotnet/java-interop#1461))
- [`6d8aef7`](dotnet/java-interop@6d8aef7b) Bump to dotnet/android-tools@1fb68b6 ([#1457](dotnet/java-interop#1457))
- [`cfca8ad`](dotnet/java-interop@cfca8ad) Upgrade gh-aw to v0.79.6 and recompile workflows ([#1460](dotnet/java-interop#1460))
- [`0104236`](dotnet/java-interop@0104236e) [JniValueManager] Make TryConstructPeer virtual ([#1456](dotnet/java-interop#1456))
- [`d7dbad5`](dotnet/java-interop@d7dbad5) Remove Java.Interop.Dynamic ([#1449](dotnet/java-interop#1449))
- [`0244c10`](dotnet/java-interop@0244c10) Split reflection-based JniTypeManager and JniValueManager behavior ([#1441](dotnet/java-interop#1441))
- [`9ca7064`](dotnet/java-interop@9ca7064) [Java.Interop] Remove legacy `NET` preprocessor paths ([#1451](dotnet/java-interop#1451))
- [`cd2fc12`](dotnet/java-interop@cd2fc12) Remove Java.Interop.GenericMarshaler ([#1450](dotnet/java-interop#1450))
See full diff in [compare view](dotnet/java-interop@b881d21...6820a9c).
## Changes in this PR (beyond the submodule bump)
The Java.Interop bump — particularly [#1441](dotnet/java-interop#1441) (split reflection-based `JniTypeManager` and `JniValueManager`) and [#1449](dotnet/java-interop#1449) (removal of `Java.Interop.Dynamic`) — required a number of follow-on changes in `dotnet/android`:
### Runtime / `Mono.Android`
- **Adapt Android runtime to Java.Interop reflection managers** — switch the `JavaInteropTypeManager` / `JavaInteropValueManager` hierarchy to the new reflection-based base types and update type/value manager construction to match.
- **Change base type of value managers and type managers** so the runtime composes correctly with the new Java.Interop split.
- **Suppress reflection manager trim warnings only** — narrow the existing trim suppressions so they apply to the reflection-only managers and don't hide other warnings.
- **Suppress IL2068 on `ManagedTypeManager.GetTypeForSimpleReference`** — annotate the entry point that legitimately requires reflection so trim analysis is satisfied.
### Tests / apkdescs
- **Regenerate `BuildReleaseArm64SimpleDotNet.MonoVM.apkdesc`** to track size changes from the Java.Interop bump.
- **Regenerate Simple `BuildReleaseArm64` apkdescs** (`MonoVM` + `NativeAOT`) from a `Release` SDK so they match what CI produces.
- **Update NativeAOT warning expectations** — `Mono.Android` now produces fewer trim/AOT warnings, so loosen the strict `4 Warning(s)` checks in `SupportedOSPlatformVersion` and `CheckSignApk` to `AssertHasAtMostWarnings (2)` (new helper in `AssertionExtensions`) and drop the `BuildHasTrimmerWarnings` data counts (`3 → 2`, `4 → 3`) accordingly.
### Merges
- Two merges from `origin/main` to keep the branch current and resolve a conflict in `Microsoft.Android.Sdk.TypeMap.Trimmable.targets`.
Co-authored-by: Simon Rozsival <simon@rozsival.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-reviewThis PR is ready to review/merge, thanks!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@simonrozsival@jonathanpeppers
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content
This repository was archived by the owner on Aug 27, 2026. It is now read-only.

Remove legacy NET preprocessor paths - #1451

Merged
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define
Jun 9, 2026
Merged

Remove legacy NET preprocessor paths#1451
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

Draft experiment.

This removes legacy NET/non-NET preprocessor branches and stale legacy TFM references from Java.Interop now that the active repo targets are modern .NET or netstandard2.0 support libraries.

Changes:

  • Make modern .NET paths unconditional in Java.Interop and Java.Runtime.Environment.
  • Remove #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 guarded code outside external/.
  • Stop generated XAJavaInterop1 output from emitting dummy non-NET compatibility attributes.
  • Remove the empty generator support stub that only existed for !NET.
  • Remove stale net472/monoandroid/old .NET TFM references outside external/, including the invocation-overhead net472 run path.

Validation:

  • Remaining NET/version guard refs outside external/: 0
  • Remaining legacy TFM refs outside external/: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop-Tests/Java.Interop-Tests.csproj
    • Passed: 671, Failed: 0, Skipped: 4
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/generator-Tests/generator-Tests.csproj
    • Passed: 455, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers-Tests.csproj
    • Passed: 47, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet build tests/invocation-overhead/invocation-overhead.csproj
    • Build succeeded

Notes:

  • Full dotnet build Java.Interop.sln was attempted but still hits existing/baseline failures unrelated to this cleanup: the Kotlin Gradle fixture in Xamarin.Android.Tools.Bytecode-Tests, and the current Java.Base generated binding error that also reproduces on the untouched main worktree.

Make modern .NET code paths unconditional and remove obsolete non-NET/generated compatibility branches now that Java.Interop targets current .NET or netstandard2.0 only.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
simonrozsival marked this pull request as ready for review June 9, 2026 10:03
CopilotAI review requested due to automatic review settings June 9, 2026 10:03
@simonrozsivalsimonrozsival added the ready-to-review This PR is ready to review/merge, thanks! label Jun 9, 2026
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy NET/non-NET conditional compilation paths and stale TFM-specific branches across Java.Interop, Java.Runtime.Environment, generator tooling, and associated tests/fixtures, making the modern .NET code paths unconditional.

Changes:

  • Remove #if NET / #if !NET / version-guarded code paths and associated compatibility stubs (including generator-emitted dummy attributes).
  • Update generator and expected outputs to no longer emit legacy guards and to always include modern attributes/suppressions.
  • Simplify test and benchmark infrastructure by dropping old framework-specific branches (e.g., net472 run path).
Show a summary per file
FileDescription
tools/param-name-importer/param-name-importer.csprojAdjust comment to reflect current package-asset rationale.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/NamespaceMapping.csStop emitting legacy dummy SupportedOSPlatformAttribute for !NET.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/ClassGen.csMake trimming suppression attribute emission unconditional in generated registrations.
tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers/JavaNativeTypeManagerTests.csRemove legacy NET/non-NET expected values.
tests/Java.Interop-Tests/Java.Interop/JniRuntimeJniValueManagerContract.csRemove legacy Mono/non-core runtime contract fixture.
tests/Java.Interop-Tests/Java.Interop/JniPeerMembersTests.csRemove NET guards around tests and helper types.
tests/Java.Interop-Tests/Java.Interop/JavaVMFixture.csMake fallback/replacement type logic unconditional (remove NET guards).
tests/invocation-overhead/invocation-overhead.targetsDrop net472 run target and unify run path.
tests/invocation-overhead/invocation-overhead.csRemove NET-only compilation blocks and keep modern code path.
tests/generator-Tests/SupportFiles/JavaTypeParametersAttribute.csRemove legacy !NET stub support file.
tests/generator-Tests/Integration-Tests/Compiler.csAlways define NET and always reference System.Runtime.dll facade for compilation.
tests/generator-Tests/Integration-Tests/BaseGeneratorTest.csRemove NET-guarded execution of JavaInterop1 target runs.
tests/generator-Tests/expected.xaji/TestInterface/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/TestInterface/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Streams/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Streams/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/ParameterXPath/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/ParameterXPath/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NonStaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NonStaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NestedTypes/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NestedTypes/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.util.List/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.util.List/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.lang.Object/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/GenericArguments/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/GenericArguments/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/CSharpKeywords/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/CSharpKeywords/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_ClassParse/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_ClassParse/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Constructors/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Constructors/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Arrays/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Arrays/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Adapters/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Adapters/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/AccessModifiers/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/AccessModifiers/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
src/Java.Runtime.Environment/Java.Interop/JreTypeManager.csRemove NET-only compile guard to make JRE type manager unconditional.
src/Java.Runtime.Environment/Java.Interop/JreRuntime.csRemove NET/non-NET branching in type manager selection and loader implementation.
src/Java.Interop/Java.Interop/ManagedPeer.csRemove legacy string marshaling path and always use span-based registration.
src/Java.Interop/Java.Interop/JniTypeSignature.csRemove legacy hash code implementation branch and use modern overload.
src/Java.Interop/Java.Interop/JniType.csMake helper TryParse/TryGet*Method APIs unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniRuntime.JniTypeManager.csMake replacement/fallback APIs unconditional and remove NET-only obsolete guards.
src/Java.Interop/Java.Interop/JniRuntime.csRemove NET9+ conditional around Debugger.BreakForUserUnhandledException.
src/Java.Interop/Java.Interop/JniPeerMembers.JniStaticMethods.csMake replacement/fallback lookup paths unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods.csMake replacement lookup unconditional and update stack-trace comment path.
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods_Invoke.csRemove !NET short-circuiting and always enable static redirect invoke logic.
src/Java.Interop/Java.Interop/JniPeerMembers.csMake replacement type lookup unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMethodInfo.csMake redirect metadata fields unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMemberSignature.csRemove NET-only compilation guard for signature type.
src/Java.Interop/Java.Interop/JniEnvironment.Types.csMake TryFindClass unconditional and broaden DEBUG-only diagnostics.
src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaArray.csUpdate nullable-contract comment and remove trailing whitespace.
src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.csRemove NETSTANDARD2_0 conditional logic around IJavaPeerable checks.
Documentation/Motivation.mdUpdate motivation text to remove obsolete legacy framework references.

Copilot's findings

  • Files reviewed: 78/78 changed files
  • Comments generated: 1

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR correctly removes all legacy #if NET, #if !NET, #if NETCOREAPP, #if NET5_0_OR_GREATER, #if NET9_0_OR_GREATER, and #if NETSTANDARD2_0 preprocessor branches from files outside external/. Since all projects target net10.0, these guards were always-true (or always-false) dead code.

What I verified

  • Correctness: In every case, the kept code path matches what was already active under net10.0. No behavioral changes.
  • Debugger.BreakForUserUnhandledException (JniRuntime.cs): API introduced in .NET 9, safe to use unconditionally on net10.0.
  • JavaNativeTypeManager.cs: NETSTANDARD2_0 fallback removed — correct since the project now targets only net10.0, not netstandard2.0.
  • Generator codegen (ClassGen.cs, NamespaceMapping.cs): Dummy SupportedOSPlatformAttribute for !NET removed; #if NET5_0_OR_GREATER around [UnconditionalSuppressMessage] removed — both consistent with modern .NET only.
  • Expected test output files: All updated consistently with the generator changes.
  • JvmLibraryHandler.Create(): Default handler correctly remains NativeLibraryJvmLibraryHandler (the NET path).
  • invocation-overhead: net472 target removed; run target renamed from _Run_netcoreapp to _Run.
  • Zero remaining NET/version guards outside external/ confirmed via grep.

CI status

⏳ The dotnet.java-interop CI build is queued but has not run yet. The author reports manual test results (671 passed for Java.Interop-Tests, 455 for generator-Tests, 47 for JCW-Tests) which is encouraging, but CI should be green before merging.

Issues found

SeverityCountCategory
💡1Formatting (double blank lines artifact)

The only issue is minor double blank lines left behind in 8 files after removing #if/#endif directives — see inline comment for the full list.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 14.5M

@@ -1,4 +1,3 @@
#if NET

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 💡 Formatting — Removing #if NET / #endif guards left behind double consecutive blank lines (or a leading blank line) in several files. The repo convention says "Don't leave random empty lines." These are minor artifacts but easy to clean up in a follow-up pass.

Affected files:

  • src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs (lines 2–3)
  • src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.cs (lines 5–6)
  • src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.cs (lines 4–5)
  • src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.cs (lines 5–6)
  • src/Java.Runtime.Environment/Java.Interop/JreRuntime.cs (lines 216–217, 279–280, 337–338)
  • src/Java.Runtime.Environment/Java.Interop/JreTypeManager.cs (leading blank at line 1, lines 7–8)

Rule: Minimal diffs

@simonrozsival

Copy link
Copy Markdown
MemberAuthor

@copilot address the code review comments

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

CopilotAI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@copilot address the code review comments

Addressed in 94bafb1. I changed JavaNativeTypeManager to resolve Java.Interop.IJavaPeerable with throwOnError: false and added a fallback interface-name check when that type cannot be loaded, so netstandard consumers no longer fail at runtime.

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR does exactly what it says: mechanically removes #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 preprocessor guards from code that now targets only modern .NET (net10.0).

Verified:

  • All removed code paths were the inactive branches (the #if !NET / #else arms). The surviving code is what was already compiling and running.
  • Debugger.BreakForUserUnhandledException (previously #if NET9_0_OR_GREATER) — API available since .NET 9; safe to make unconditional on net10.0.
  • string.GetHashCode(StringComparison) (previously #if NETCOREAPP) — available since .NET Core 2.1; correct to make unconditional.
  • JreRuntime switch statement merge correctly preserves the modern .NET behavior (default → NativeLibraryJvmLibraryHandler).
  • ManagedPeer.RegisterNativeMembers correctly keeps the ReadOnlySpan<char> path and removes the string-based fallback.
  • Generator output changes (ClassGen.cs, NamespaceMapping.cs) are consistent with all 40+ expected test output file updates.
  • Zero remaining NET/NETCOREAPP/NETSTANDARD/version-guard references outside external/ — confirmed.
  • The removed JavaTypeParametersAttribute.cs test support file was a !NET-only stub duplicating the real type; correctly removed.

1 suggestion: A few files have double blank lines left from the mechanical removal (listed in the inline comment). Very minor — can be addressed in a follow-up.

CI note: Only license/cla check is reported (passing). No build/test CI results visible yet — those should be verified before merging.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 12.9M

Comment threadsrc/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs

@jonathanpeppersjonathanpeppers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anything in dotnet/android that uses netstandard2.0 versions of these files:

Image

@jonathanpeppers
jonathanpeppers merged commit 9ca7064 into mainJun 9, 2026
2 checks passed
@jonathanpeppers
jonathanpeppers deleted the dev/simonrozsival/remove-net-define branch June 9, 2026 16:02
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jun 16, 2026
Bumps [external/Java.Interop](https://github.com/dotnet/java-interop) from `b881d21` to [`6820a9cb`](dotnet/java-interop@6820a9c).
## Java.Interop changes pulled in
- [`6820a9c`](dotnet/java-interop@6820a9c) [Java.Interop] Make JavaProxyObject.RegisterNativeMembers private again ([#1468](dotnet/java-interop#1468))
- [`a2159d7`](dotnet/java-interop@a2159d70) Remove NuGet dependency grouping from Dependabot config ([#1459](dotnet/java-interop#1459))
- [`a0ca676`](dotnet/java-interop@a0ca6760) [ci] Update agentic workflows to claude-opus-4.8 ([#1461](dotnet/java-interop#1461))
- [`6d8aef7`](dotnet/java-interop@6d8aef7b) Bump to dotnet/android-tools@1fb68b6 ([#1457](dotnet/java-interop#1457))
- [`cfca8ad`](dotnet/java-interop@cfca8ad) Upgrade gh-aw to v0.79.6 and recompile workflows ([#1460](dotnet/java-interop#1460))
- [`0104236`](dotnet/java-interop@0104236e) [JniValueManager] Make TryConstructPeer virtual ([#1456](dotnet/java-interop#1456))
- [`d7dbad5`](dotnet/java-interop@d7dbad5) Remove Java.Interop.Dynamic ([#1449](dotnet/java-interop#1449))
- [`0244c10`](dotnet/java-interop@0244c10) Split reflection-based JniTypeManager and JniValueManager behavior ([#1441](dotnet/java-interop#1441))
- [`9ca7064`](dotnet/java-interop@9ca7064) [Java.Interop] Remove legacy `NET` preprocessor paths ([#1451](dotnet/java-interop#1451))
- [`cd2fc12`](dotnet/java-interop@cd2fc12) Remove Java.Interop.GenericMarshaler ([#1450](dotnet/java-interop#1450))
See full diff in [compare view](dotnet/java-interop@b881d21...6820a9c).
## Changes in this PR (beyond the submodule bump)
The Java.Interop bump — particularly [#1441](dotnet/java-interop#1441) (split reflection-based `JniTypeManager` and `JniValueManager`) and [#1449](dotnet/java-interop#1449) (removal of `Java.Interop.Dynamic`) — required a number of follow-on changes in `dotnet/android`:
### Runtime / `Mono.Android`
- **Adapt Android runtime to Java.Interop reflection managers** — switch the `JavaInteropTypeManager` / `JavaInteropValueManager` hierarchy to the new reflection-based base types and update type/value manager construction to match.
- **Change base type of value managers and type managers** so the runtime composes correctly with the new Java.Interop split.
- **Suppress reflection manager trim warnings only** — narrow the existing trim suppressions so they apply to the reflection-only managers and don't hide other warnings.
- **Suppress IL2068 on `ManagedTypeManager.GetTypeForSimpleReference`** — annotate the entry point that legitimately requires reflection so trim analysis is satisfied.
### Tests / apkdescs
- **Regenerate `BuildReleaseArm64SimpleDotNet.MonoVM.apkdesc`** to track size changes from the Java.Interop bump.
- **Regenerate Simple `BuildReleaseArm64` apkdescs** (`MonoVM` + `NativeAOT`) from a `Release` SDK so they match what CI produces.
- **Update NativeAOT warning expectations** — `Mono.Android` now produces fewer trim/AOT warnings, so loosen the strict `4 Warning(s)` checks in `SupportedOSPlatformVersion` and `CheckSignApk` to `AssertHasAtMostWarnings (2)` (new helper in `AssertionExtensions`) and drop the `BuildHasTrimmerWarnings` data counts (`3 → 2`, `4 → 3`) accordingly.
### Merges
- Two merges from `origin/main` to keep the branch current and resolve a conflict in `Microsoft.Android.Sdk.TypeMap.Trimmable.targets`.
Co-authored-by: Simon Rozsival <simon@rozsival.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-reviewThis PR is ready to review/merge, thanks!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@simonrozsival@jonathanpeppers
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 27, 2026. It is now read-only.

Remove legacy NET preprocessor paths - #1451

Merged
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define
Jun 9, 2026
Merged

Remove legacy NET preprocessor paths#1451
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

Draft experiment.

This removes legacy NET/non-NET preprocessor branches and stale legacy TFM references from Java.Interop now that the active repo targets are modern .NET or netstandard2.0 support libraries.

Changes:

  • Make modern .NET paths unconditional in Java.Interop and Java.Runtime.Environment.
  • Remove #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 guarded code outside external/.
  • Stop generated XAJavaInterop1 output from emitting dummy non-NET compatibility attributes.
  • Remove the empty generator support stub that only existed for !NET.
  • Remove stale net472/monoandroid/old .NET TFM references outside external/, including the invocation-overhead net472 run path.

Validation:

  • Remaining NET/version guard refs outside external/: 0
  • Remaining legacy TFM refs outside external/: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop-Tests/Java.Interop-Tests.csproj
    • Passed: 671, Failed: 0, Skipped: 4
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/generator-Tests/generator-Tests.csproj
    • Passed: 455, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers-Tests.csproj
    • Passed: 47, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet build tests/invocation-overhead/invocation-overhead.csproj
    • Build succeeded

Notes:

  • Full dotnet build Java.Interop.sln was attempted but still hits existing/baseline failures unrelated to this cleanup: the Kotlin Gradle fixture in Xamarin.Android.Tools.Bytecode-Tests, and the current Java.Base generated binding error that also reproduces on the untouched main worktree.

Make modern .NET code paths unconditional and remove obsolete non-NET/generated compatibility branches now that Java.Interop targets current .NET or netstandard2.0 only.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
simonrozsival marked this pull request as ready for review June 9, 2026 10:03
CopilotAI review requested due to automatic review settings June 9, 2026 10:03
@simonrozsivalsimonrozsival added the ready-to-review This PR is ready to review/merge, thanks! label Jun 9, 2026
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy NET/non-NET conditional compilation paths and stale TFM-specific branches across Java.Interop, Java.Runtime.Environment, generator tooling, and associated tests/fixtures, making the modern .NET code paths unconditional.

Changes:

  • Remove #if NET / #if !NET / version-guarded code paths and associated compatibility stubs (including generator-emitted dummy attributes).
  • Update generator and expected outputs to no longer emit legacy guards and to always include modern attributes/suppressions.
  • Simplify test and benchmark infrastructure by dropping old framework-specific branches (e.g., net472 run path).
Show a summary per file
FileDescription
tools/param-name-importer/param-name-importer.csprojAdjust comment to reflect current package-asset rationale.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/NamespaceMapping.csStop emitting legacy dummy SupportedOSPlatformAttribute for !NET.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/ClassGen.csMake trimming suppression attribute emission unconditional in generated registrations.
tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers/JavaNativeTypeManagerTests.csRemove legacy NET/non-NET expected values.
tests/Java.Interop-Tests/Java.Interop/JniRuntimeJniValueManagerContract.csRemove legacy Mono/non-core runtime contract fixture.
tests/Java.Interop-Tests/Java.Interop/JniPeerMembersTests.csRemove NET guards around tests and helper types.
tests/Java.Interop-Tests/Java.Interop/JavaVMFixture.csMake fallback/replacement type logic unconditional (remove NET guards).
tests/invocation-overhead/invocation-overhead.targetsDrop net472 run target and unify run path.
tests/invocation-overhead/invocation-overhead.csRemove NET-only compilation blocks and keep modern code path.
tests/generator-Tests/SupportFiles/JavaTypeParametersAttribute.csRemove legacy !NET stub support file.
tests/generator-Tests/Integration-Tests/Compiler.csAlways define NET and always reference System.Runtime.dll facade for compilation.
tests/generator-Tests/Integration-Tests/BaseGeneratorTest.csRemove NET-guarded execution of JavaInterop1 target runs.
tests/generator-Tests/expected.xaji/TestInterface/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/TestInterface/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Streams/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Streams/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/ParameterXPath/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/ParameterXPath/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NonStaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NonStaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NestedTypes/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NestedTypes/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.util.List/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.util.List/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.lang.Object/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/GenericArguments/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/GenericArguments/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/CSharpKeywords/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/CSharpKeywords/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_ClassParse/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_ClassParse/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Constructors/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Constructors/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Arrays/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Arrays/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Adapters/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Adapters/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/AccessModifiers/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/AccessModifiers/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
src/Java.Runtime.Environment/Java.Interop/JreTypeManager.csRemove NET-only compile guard to make JRE type manager unconditional.
src/Java.Runtime.Environment/Java.Interop/JreRuntime.csRemove NET/non-NET branching in type manager selection and loader implementation.
src/Java.Interop/Java.Interop/ManagedPeer.csRemove legacy string marshaling path and always use span-based registration.
src/Java.Interop/Java.Interop/JniTypeSignature.csRemove legacy hash code implementation branch and use modern overload.
src/Java.Interop/Java.Interop/JniType.csMake helper TryParse/TryGet*Method APIs unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniRuntime.JniTypeManager.csMake replacement/fallback APIs unconditional and remove NET-only obsolete guards.
src/Java.Interop/Java.Interop/JniRuntime.csRemove NET9+ conditional around Debugger.BreakForUserUnhandledException.
src/Java.Interop/Java.Interop/JniPeerMembers.JniStaticMethods.csMake replacement/fallback lookup paths unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods.csMake replacement lookup unconditional and update stack-trace comment path.
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods_Invoke.csRemove !NET short-circuiting and always enable static redirect invoke logic.
src/Java.Interop/Java.Interop/JniPeerMembers.csMake replacement type lookup unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMethodInfo.csMake redirect metadata fields unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMemberSignature.csRemove NET-only compilation guard for signature type.
src/Java.Interop/Java.Interop/JniEnvironment.Types.csMake TryFindClass unconditional and broaden DEBUG-only diagnostics.
src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaArray.csUpdate nullable-contract comment and remove trailing whitespace.
src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.csRemove NETSTANDARD2_0 conditional logic around IJavaPeerable checks.
Documentation/Motivation.mdUpdate motivation text to remove obsolete legacy framework references.

Copilot's findings

  • Files reviewed: 78/78 changed files
  • Comments generated: 1

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR correctly removes all legacy #if NET, #if !NET, #if NETCOREAPP, #if NET5_0_OR_GREATER, #if NET9_0_OR_GREATER, and #if NETSTANDARD2_0 preprocessor branches from files outside external/. Since all projects target net10.0, these guards were always-true (or always-false) dead code.

What I verified

  • Correctness: In every case, the kept code path matches what was already active under net10.0. No behavioral changes.
  • Debugger.BreakForUserUnhandledException (JniRuntime.cs): API introduced in .NET 9, safe to use unconditionally on net10.0.
  • JavaNativeTypeManager.cs: NETSTANDARD2_0 fallback removed — correct since the project now targets only net10.0, not netstandard2.0.
  • Generator codegen (ClassGen.cs, NamespaceMapping.cs): Dummy SupportedOSPlatformAttribute for !NET removed; #if NET5_0_OR_GREATER around [UnconditionalSuppressMessage] removed — both consistent with modern .NET only.
  • Expected test output files: All updated consistently with the generator changes.
  • JvmLibraryHandler.Create(): Default handler correctly remains NativeLibraryJvmLibraryHandler (the NET path).
  • invocation-overhead: net472 target removed; run target renamed from _Run_netcoreapp to _Run.
  • Zero remaining NET/version guards outside external/ confirmed via grep.

CI status

⏳ The dotnet.java-interop CI build is queued but has not run yet. The author reports manual test results (671 passed for Java.Interop-Tests, 455 for generator-Tests, 47 for JCW-Tests) which is encouraging, but CI should be green before merging.

Issues found

SeverityCountCategory
💡1Formatting (double blank lines artifact)

The only issue is minor double blank lines left behind in 8 files after removing #if/#endif directives — see inline comment for the full list.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 14.5M

@@ -1,4 +1,3 @@
#if NET

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 💡 Formatting — Removing #if NET / #endif guards left behind double consecutive blank lines (or a leading blank line) in several files. The repo convention says "Don't leave random empty lines." These are minor artifacts but easy to clean up in a follow-up pass.

Affected files:

  • src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs (lines 2–3)
  • src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.cs (lines 5–6)
  • src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.cs (lines 4–5)
  • src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.cs (lines 5–6)
  • src/Java.Runtime.Environment/Java.Interop/JreRuntime.cs (lines 216–217, 279–280, 337–338)
  • src/Java.Runtime.Environment/Java.Interop/JreTypeManager.cs (leading blank at line 1, lines 7–8)

Rule: Minimal diffs

@simonrozsival

Copy link
Copy Markdown
MemberAuthor

@copilot address the code review comments

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

CopilotAI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@copilot address the code review comments

Addressed in 94bafb1. I changed JavaNativeTypeManager to resolve Java.Interop.IJavaPeerable with throwOnError: false and added a fallback interface-name check when that type cannot be loaded, so netstandard consumers no longer fail at runtime.

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR does exactly what it says: mechanically removes #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 preprocessor guards from code that now targets only modern .NET (net10.0).

Verified:

  • All removed code paths were the inactive branches (the #if !NET / #else arms). The surviving code is what was already compiling and running.
  • Debugger.BreakForUserUnhandledException (previously #if NET9_0_OR_GREATER) — API available since .NET 9; safe to make unconditional on net10.0.
  • string.GetHashCode(StringComparison) (previously #if NETCOREAPP) — available since .NET Core 2.1; correct to make unconditional.
  • JreRuntime switch statement merge correctly preserves the modern .NET behavior (default → NativeLibraryJvmLibraryHandler).
  • ManagedPeer.RegisterNativeMembers correctly keeps the ReadOnlySpan<char> path and removes the string-based fallback.
  • Generator output changes (ClassGen.cs, NamespaceMapping.cs) are consistent with all 40+ expected test output file updates.
  • Zero remaining NET/NETCOREAPP/NETSTANDARD/version-guard references outside external/ — confirmed.
  • The removed JavaTypeParametersAttribute.cs test support file was a !NET-only stub duplicating the real type; correctly removed.

1 suggestion: A few files have double blank lines left from the mechanical removal (listed in the inline comment). Very minor — can be addressed in a follow-up.

CI note: Only license/cla check is reported (passing). No build/test CI results visible yet — those should be verified before merging.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 12.9M

Comment threadsrc/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs

@jonathanpeppersjonathanpeppers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anything in dotnet/android that uses netstandard2.0 versions of these files:

Image

@jonathanpeppers
jonathanpeppers merged commit 9ca7064 into mainJun 9, 2026
2 checks passed
@jonathanpeppers
jonathanpeppers deleted the dev/simonrozsival/remove-net-define branch June 9, 2026 16:02
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jun 16, 2026
Bumps [external/Java.Interop](https://github.com/dotnet/java-interop) from `b881d21` to [`6820a9cb`](dotnet/java-interop@6820a9c).
## Java.Interop changes pulled in
- [`6820a9c`](dotnet/java-interop@6820a9c) [Java.Interop] Make JavaProxyObject.RegisterNativeMembers private again ([#1468](dotnet/java-interop#1468))
- [`a2159d7`](dotnet/java-interop@a2159d70) Remove NuGet dependency grouping from Dependabot config ([#1459](dotnet/java-interop#1459))
- [`a0ca676`](dotnet/java-interop@a0ca6760) [ci] Update agentic workflows to claude-opus-4.8 ([#1461](dotnet/java-interop#1461))
- [`6d8aef7`](dotnet/java-interop@6d8aef7b) Bump to dotnet/android-tools@1fb68b6 ([#1457](dotnet/java-interop#1457))
- [`cfca8ad`](dotnet/java-interop@cfca8ad) Upgrade gh-aw to v0.79.6 and recompile workflows ([#1460](dotnet/java-interop#1460))
- [`0104236`](dotnet/java-interop@0104236e) [JniValueManager] Make TryConstructPeer virtual ([#1456](dotnet/java-interop#1456))
- [`d7dbad5`](dotnet/java-interop@d7dbad5) Remove Java.Interop.Dynamic ([#1449](dotnet/java-interop#1449))
- [`0244c10`](dotnet/java-interop@0244c10) Split reflection-based JniTypeManager and JniValueManager behavior ([#1441](dotnet/java-interop#1441))
- [`9ca7064`](dotnet/java-interop@9ca7064) [Java.Interop] Remove legacy `NET` preprocessor paths ([#1451](dotnet/java-interop#1451))
- [`cd2fc12`](dotnet/java-interop@cd2fc12) Remove Java.Interop.GenericMarshaler ([#1450](dotnet/java-interop#1450))
See full diff in [compare view](dotnet/java-interop@b881d21...6820a9c).
## Changes in this PR (beyond the submodule bump)
The Java.Interop bump — particularly [#1441](dotnet/java-interop#1441) (split reflection-based `JniTypeManager` and `JniValueManager`) and [#1449](dotnet/java-interop#1449) (removal of `Java.Interop.Dynamic`) — required a number of follow-on changes in `dotnet/android`:
### Runtime / `Mono.Android`
- **Adapt Android runtime to Java.Interop reflection managers** — switch the `JavaInteropTypeManager` / `JavaInteropValueManager` hierarchy to the new reflection-based base types and update type/value manager construction to match.
- **Change base type of value managers and type managers** so the runtime composes correctly with the new Java.Interop split.
- **Suppress reflection manager trim warnings only** — narrow the existing trim suppressions so they apply to the reflection-only managers and don't hide other warnings.
- **Suppress IL2068 on `ManagedTypeManager.GetTypeForSimpleReference`** — annotate the entry point that legitimately requires reflection so trim analysis is satisfied.
### Tests / apkdescs
- **Regenerate `BuildReleaseArm64SimpleDotNet.MonoVM.apkdesc`** to track size changes from the Java.Interop bump.
- **Regenerate Simple `BuildReleaseArm64` apkdescs** (`MonoVM` + `NativeAOT`) from a `Release` SDK so they match what CI produces.
- **Update NativeAOT warning expectations** — `Mono.Android` now produces fewer trim/AOT warnings, so loosen the strict `4 Warning(s)` checks in `SupportedOSPlatformVersion` and `CheckSignApk` to `AssertHasAtMostWarnings (2)` (new helper in `AssertionExtensions`) and drop the `BuildHasTrimmerWarnings` data counts (`3 → 2`, `4 → 3`) accordingly.
### Merges
- Two merges from `origin/main` to keep the branch current and resolve a conflict in `Microsoft.Android.Sdk.TypeMap.Trimmable.targets`.
Co-authored-by: Simon Rozsival <simon@rozsival.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-reviewThis PR is ready to review/merge, thanks!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@simonrozsival@jonathanpeppers
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content
This repository was archived by the owner on Aug 27, 2026. It is now read-only.

Remove legacy NET preprocessor paths - #1451

Merged
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define
Jun 9, 2026
Merged

Remove legacy NET preprocessor paths#1451
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

Draft experiment.

This removes legacy NET/non-NET preprocessor branches and stale legacy TFM references from Java.Interop now that the active repo targets are modern .NET or netstandard2.0 support libraries.

Changes:

  • Make modern .NET paths unconditional in Java.Interop and Java.Runtime.Environment.
  • Remove #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 guarded code outside external/.
  • Stop generated XAJavaInterop1 output from emitting dummy non-NET compatibility attributes.
  • Remove the empty generator support stub that only existed for !NET.
  • Remove stale net472/monoandroid/old .NET TFM references outside external/, including the invocation-overhead net472 run path.

Validation:

  • Remaining NET/version guard refs outside external/: 0
  • Remaining legacy TFM refs outside external/: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop-Tests/Java.Interop-Tests.csproj
    • Passed: 671, Failed: 0, Skipped: 4
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/generator-Tests/generator-Tests.csproj
    • Passed: 455, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers-Tests.csproj
    • Passed: 47, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet build tests/invocation-overhead/invocation-overhead.csproj
    • Build succeeded

Notes:

  • Full dotnet build Java.Interop.sln was attempted but still hits existing/baseline failures unrelated to this cleanup: the Kotlin Gradle fixture in Xamarin.Android.Tools.Bytecode-Tests, and the current Java.Base generated binding error that also reproduces on the untouched main worktree.

Make modern .NET code paths unconditional and remove obsolete non-NET/generated compatibility branches now that Java.Interop targets current .NET or netstandard2.0 only.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
simonrozsival marked this pull request as ready for review June 9, 2026 10:03
CopilotAI review requested due to automatic review settings June 9, 2026 10:03
@simonrozsivalsimonrozsival added the ready-to-review This PR is ready to review/merge, thanks! label Jun 9, 2026
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy NET/non-NET conditional compilation paths and stale TFM-specific branches across Java.Interop, Java.Runtime.Environment, generator tooling, and associated tests/fixtures, making the modern .NET code paths unconditional.

Changes:

  • Remove #if NET / #if !NET / version-guarded code paths and associated compatibility stubs (including generator-emitted dummy attributes).
  • Update generator and expected outputs to no longer emit legacy guards and to always include modern attributes/suppressions.
  • Simplify test and benchmark infrastructure by dropping old framework-specific branches (e.g., net472 run path).
Show a summary per file
FileDescription
tools/param-name-importer/param-name-importer.csprojAdjust comment to reflect current package-asset rationale.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/NamespaceMapping.csStop emitting legacy dummy SupportedOSPlatformAttribute for !NET.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/ClassGen.csMake trimming suppression attribute emission unconditional in generated registrations.
tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers/JavaNativeTypeManagerTests.csRemove legacy NET/non-NET expected values.
tests/Java.Interop-Tests/Java.Interop/JniRuntimeJniValueManagerContract.csRemove legacy Mono/non-core runtime contract fixture.
tests/Java.Interop-Tests/Java.Interop/JniPeerMembersTests.csRemove NET guards around tests and helper types.
tests/Java.Interop-Tests/Java.Interop/JavaVMFixture.csMake fallback/replacement type logic unconditional (remove NET guards).
tests/invocation-overhead/invocation-overhead.targetsDrop net472 run target and unify run path.
tests/invocation-overhead/invocation-overhead.csRemove NET-only compilation blocks and keep modern code path.
tests/generator-Tests/SupportFiles/JavaTypeParametersAttribute.csRemove legacy !NET stub support file.
tests/generator-Tests/Integration-Tests/Compiler.csAlways define NET and always reference System.Runtime.dll facade for compilation.
tests/generator-Tests/Integration-Tests/BaseGeneratorTest.csRemove NET-guarded execution of JavaInterop1 target runs.
tests/generator-Tests/expected.xaji/TestInterface/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/TestInterface/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Streams/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Streams/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/ParameterXPath/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/ParameterXPath/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NonStaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NonStaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NestedTypes/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NestedTypes/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.util.List/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.util.List/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.lang.Object/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/GenericArguments/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/GenericArguments/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/CSharpKeywords/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/CSharpKeywords/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_ClassParse/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_ClassParse/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Constructors/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Constructors/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Arrays/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Arrays/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Adapters/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Adapters/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/AccessModifiers/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/AccessModifiers/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
src/Java.Runtime.Environment/Java.Interop/JreTypeManager.csRemove NET-only compile guard to make JRE type manager unconditional.
src/Java.Runtime.Environment/Java.Interop/JreRuntime.csRemove NET/non-NET branching in type manager selection and loader implementation.
src/Java.Interop/Java.Interop/ManagedPeer.csRemove legacy string marshaling path and always use span-based registration.
src/Java.Interop/Java.Interop/JniTypeSignature.csRemove legacy hash code implementation branch and use modern overload.
src/Java.Interop/Java.Interop/JniType.csMake helper TryParse/TryGet*Method APIs unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniRuntime.JniTypeManager.csMake replacement/fallback APIs unconditional and remove NET-only obsolete guards.
src/Java.Interop/Java.Interop/JniRuntime.csRemove NET9+ conditional around Debugger.BreakForUserUnhandledException.
src/Java.Interop/Java.Interop/JniPeerMembers.JniStaticMethods.csMake replacement/fallback lookup paths unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods.csMake replacement lookup unconditional and update stack-trace comment path.
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods_Invoke.csRemove !NET short-circuiting and always enable static redirect invoke logic.
src/Java.Interop/Java.Interop/JniPeerMembers.csMake replacement type lookup unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMethodInfo.csMake redirect metadata fields unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMemberSignature.csRemove NET-only compilation guard for signature type.
src/Java.Interop/Java.Interop/JniEnvironment.Types.csMake TryFindClass unconditional and broaden DEBUG-only diagnostics.
src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaArray.csUpdate nullable-contract comment and remove trailing whitespace.
src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.csRemove NETSTANDARD2_0 conditional logic around IJavaPeerable checks.
Documentation/Motivation.mdUpdate motivation text to remove obsolete legacy framework references.

Copilot's findings

  • Files reviewed: 78/78 changed files
  • Comments generated: 1

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR correctly removes all legacy #if NET, #if !NET, #if NETCOREAPP, #if NET5_0_OR_GREATER, #if NET9_0_OR_GREATER, and #if NETSTANDARD2_0 preprocessor branches from files outside external/. Since all projects target net10.0, these guards were always-true (or always-false) dead code.

What I verified

  • Correctness: In every case, the kept code path matches what was already active under net10.0. No behavioral changes.
  • Debugger.BreakForUserUnhandledException (JniRuntime.cs): API introduced in .NET 9, safe to use unconditionally on net10.0.
  • JavaNativeTypeManager.cs: NETSTANDARD2_0 fallback removed — correct since the project now targets only net10.0, not netstandard2.0.
  • Generator codegen (ClassGen.cs, NamespaceMapping.cs): Dummy SupportedOSPlatformAttribute for !NET removed; #if NET5_0_OR_GREATER around [UnconditionalSuppressMessage] removed — both consistent with modern .NET only.
  • Expected test output files: All updated consistently with the generator changes.
  • JvmLibraryHandler.Create(): Default handler correctly remains NativeLibraryJvmLibraryHandler (the NET path).
  • invocation-overhead: net472 target removed; run target renamed from _Run_netcoreapp to _Run.
  • Zero remaining NET/version guards outside external/ confirmed via grep.

CI status

⏳ The dotnet.java-interop CI build is queued but has not run yet. The author reports manual test results (671 passed for Java.Interop-Tests, 455 for generator-Tests, 47 for JCW-Tests) which is encouraging, but CI should be green before merging.

Issues found

SeverityCountCategory
💡1Formatting (double blank lines artifact)

The only issue is minor double blank lines left behind in 8 files after removing #if/#endif directives — see inline comment for the full list.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 14.5M

@@ -1,4 +1,3 @@
#if NET

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 💡 Formatting — Removing #if NET / #endif guards left behind double consecutive blank lines (or a leading blank line) in several files. The repo convention says "Don't leave random empty lines." These are minor artifacts but easy to clean up in a follow-up pass.

Affected files:

  • src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs (lines 2–3)
  • src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.cs (lines 5–6)
  • src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.cs (lines 4–5)
  • src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.cs (lines 5–6)
  • src/Java.Runtime.Environment/Java.Interop/JreRuntime.cs (lines 216–217, 279–280, 337–338)
  • src/Java.Runtime.Environment/Java.Interop/JreTypeManager.cs (leading blank at line 1, lines 7–8)

Rule: Minimal diffs

@simonrozsival

Copy link
Copy Markdown
MemberAuthor

@copilot address the code review comments

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

CopilotAI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@copilot address the code review comments

Addressed in 94bafb1. I changed JavaNativeTypeManager to resolve Java.Interop.IJavaPeerable with throwOnError: false and added a fallback interface-name check when that type cannot be loaded, so netstandard consumers no longer fail at runtime.

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR does exactly what it says: mechanically removes #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 preprocessor guards from code that now targets only modern .NET (net10.0).

Verified:

  • All removed code paths were the inactive branches (the #if !NET / #else arms). The surviving code is what was already compiling and running.
  • Debugger.BreakForUserUnhandledException (previously #if NET9_0_OR_GREATER) — API available since .NET 9; safe to make unconditional on net10.0.
  • string.GetHashCode(StringComparison) (previously #if NETCOREAPP) — available since .NET Core 2.1; correct to make unconditional.
  • JreRuntime switch statement merge correctly preserves the modern .NET behavior (default → NativeLibraryJvmLibraryHandler).
  • ManagedPeer.RegisterNativeMembers correctly keeps the ReadOnlySpan<char> path and removes the string-based fallback.
  • Generator output changes (ClassGen.cs, NamespaceMapping.cs) are consistent with all 40+ expected test output file updates.
  • Zero remaining NET/NETCOREAPP/NETSTANDARD/version-guard references outside external/ — confirmed.
  • The removed JavaTypeParametersAttribute.cs test support file was a !NET-only stub duplicating the real type; correctly removed.

1 suggestion: A few files have double blank lines left from the mechanical removal (listed in the inline comment). Very minor — can be addressed in a follow-up.

CI note: Only license/cla check is reported (passing). No build/test CI results visible yet — those should be verified before merging.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 12.9M

Comment threadsrc/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs

@jonathanpeppersjonathanpeppers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anything in dotnet/android that uses netstandard2.0 versions of these files:

Image

@jonathanpeppers
jonathanpeppers merged commit 9ca7064 into mainJun 9, 2026
2 checks passed
@jonathanpeppers
jonathanpeppers deleted the dev/simonrozsival/remove-net-define branch June 9, 2026 16:02
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jun 16, 2026
Bumps [external/Java.Interop](https://github.com/dotnet/java-interop) from `b881d21` to [`6820a9cb`](dotnet/java-interop@6820a9c).
## Java.Interop changes pulled in
- [`6820a9c`](dotnet/java-interop@6820a9c) [Java.Interop] Make JavaProxyObject.RegisterNativeMembers private again ([#1468](dotnet/java-interop#1468))
- [`a2159d7`](dotnet/java-interop@a2159d70) Remove NuGet dependency grouping from Dependabot config ([#1459](dotnet/java-interop#1459))
- [`a0ca676`](dotnet/java-interop@a0ca6760) [ci] Update agentic workflows to claude-opus-4.8 ([#1461](dotnet/java-interop#1461))
- [`6d8aef7`](dotnet/java-interop@6d8aef7b) Bump to dotnet/android-tools@1fb68b6 ([#1457](dotnet/java-interop#1457))
- [`cfca8ad`](dotnet/java-interop@cfca8ad) Upgrade gh-aw to v0.79.6 and recompile workflows ([#1460](dotnet/java-interop#1460))
- [`0104236`](dotnet/java-interop@0104236e) [JniValueManager] Make TryConstructPeer virtual ([#1456](dotnet/java-interop#1456))
- [`d7dbad5`](dotnet/java-interop@d7dbad5) Remove Java.Interop.Dynamic ([#1449](dotnet/java-interop#1449))
- [`0244c10`](dotnet/java-interop@0244c10) Split reflection-based JniTypeManager and JniValueManager behavior ([#1441](dotnet/java-interop#1441))
- [`9ca7064`](dotnet/java-interop@9ca7064) [Java.Interop] Remove legacy `NET` preprocessor paths ([#1451](dotnet/java-interop#1451))
- [`cd2fc12`](dotnet/java-interop@cd2fc12) Remove Java.Interop.GenericMarshaler ([#1450](dotnet/java-interop#1450))
See full diff in [compare view](dotnet/java-interop@b881d21...6820a9c).
## Changes in this PR (beyond the submodule bump)
The Java.Interop bump — particularly [#1441](dotnet/java-interop#1441) (split reflection-based `JniTypeManager` and `JniValueManager`) and [#1449](dotnet/java-interop#1449) (removal of `Java.Interop.Dynamic`) — required a number of follow-on changes in `dotnet/android`:
### Runtime / `Mono.Android`
- **Adapt Android runtime to Java.Interop reflection managers** — switch the `JavaInteropTypeManager` / `JavaInteropValueManager` hierarchy to the new reflection-based base types and update type/value manager construction to match.
- **Change base type of value managers and type managers** so the runtime composes correctly with the new Java.Interop split.
- **Suppress reflection manager trim warnings only** — narrow the existing trim suppressions so they apply to the reflection-only managers and don't hide other warnings.
- **Suppress IL2068 on `ManagedTypeManager.GetTypeForSimpleReference`** — annotate the entry point that legitimately requires reflection so trim analysis is satisfied.
### Tests / apkdescs
- **Regenerate `BuildReleaseArm64SimpleDotNet.MonoVM.apkdesc`** to track size changes from the Java.Interop bump.
- **Regenerate Simple `BuildReleaseArm64` apkdescs** (`MonoVM` + `NativeAOT`) from a `Release` SDK so they match what CI produces.
- **Update NativeAOT warning expectations** — `Mono.Android` now produces fewer trim/AOT warnings, so loosen the strict `4 Warning(s)` checks in `SupportedOSPlatformVersion` and `CheckSignApk` to `AssertHasAtMostWarnings (2)` (new helper in `AssertionExtensions`) and drop the `BuildHasTrimmerWarnings` data counts (`3 → 2`, `4 → 3`) accordingly.
### Merges
- Two merges from `origin/main` to keep the branch current and resolve a conflict in `Microsoft.Android.Sdk.TypeMap.Trimmable.targets`.
Co-authored-by: Simon Rozsival <simon@rozsival.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-reviewThis PR is ready to review/merge, thanks!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@simonrozsival@jonathanpeppers
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content
This repository was archived by the owner on Aug 27, 2026. It is now read-only.

Remove legacy NET preprocessor paths - #1451

Merged
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define
Jun 9, 2026
Merged

Remove legacy NET preprocessor paths#1451
jonathanpeppers merged 5 commits into
mainfrom
dev/simonrozsival/remove-net-define

Conversation

@simonrozsival

Copy link
Copy Markdown
Member

Draft experiment.

This removes legacy NET/non-NET preprocessor branches and stale legacy TFM references from Java.Interop now that the active repo targets are modern .NET or netstandard2.0 support libraries.

Changes:

  • Make modern .NET paths unconditional in Java.Interop and Java.Runtime.Environment.
  • Remove #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 guarded code outside external/.
  • Stop generated XAJavaInterop1 output from emitting dummy non-NET compatibility attributes.
  • Remove the empty generator support stub that only existed for !NET.
  • Remove stale net472/monoandroid/old .NET TFM references outside external/, including the invocation-overhead net472 run path.

Validation:

  • Remaining NET/version guard refs outside external/: 0
  • Remaining legacy TFM refs outside external/: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop-Tests/Java.Interop-Tests.csproj
    • Passed: 671, Failed: 0, Skipped: 4
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/generator-Tests/generator-Tests.csproj
    • Passed: 455, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet test tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers-Tests.csproj
    • Passed: 47, Failed: 0
  • SDKROOT=$(xcrun --sdk macosx --show-sdk-path) dotnet build tests/invocation-overhead/invocation-overhead.csproj
    • Build succeeded

Notes:

  • Full dotnet build Java.Interop.sln was attempted but still hits existing/baseline failures unrelated to this cleanup: the Kotlin Gradle fixture in Xamarin.Android.Tools.Bytecode-Tests, and the current Java.Base generated binding error that also reproduces on the untouched main worktree.

Make modern .NET code paths unconditional and remove obsolete non-NET/generated compatibility branches now that Java.Interop targets current .NET or netstandard2.0 only.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@simonrozsival
simonrozsival marked this pull request as ready for review June 9, 2026 10:03
CopilotAI review requested due to automatic review settings June 9, 2026 10:03
@simonrozsivalsimonrozsival added the ready-to-review This PR is ready to review/merge, thanks! label Jun 9, 2026
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy NET/non-NET conditional compilation paths and stale TFM-specific branches across Java.Interop, Java.Runtime.Environment, generator tooling, and associated tests/fixtures, making the modern .NET code paths unconditional.

Changes:

  • Remove #if NET / #if !NET / version-guarded code paths and associated compatibility stubs (including generator-emitted dummy attributes).
  • Update generator and expected outputs to no longer emit legacy guards and to always include modern attributes/suppressions.
  • Simplify test and benchmark infrastructure by dropping old framework-specific branches (e.g., net472 run path).
Show a summary per file
FileDescription
tools/param-name-importer/param-name-importer.csprojAdjust comment to reflect current package-asset rationale.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/NamespaceMapping.csStop emitting legacy dummy SupportedOSPlatformAttribute for !NET.
tools/generator/Java.Interop.Tools.Generator.ObjectModel/ClassGen.csMake trimming suppression attribute emission unconditional in generated registrations.
tests/Java.Interop.Tools.JavaCallableWrappers-Tests/Java.Interop.Tools.JavaCallableWrappers/JavaNativeTypeManagerTests.csRemove legacy NET/non-NET expected values.
tests/Java.Interop-Tests/Java.Interop/JniRuntimeJniValueManagerContract.csRemove legacy Mono/non-core runtime contract fixture.
tests/Java.Interop-Tests/Java.Interop/JniPeerMembersTests.csRemove NET guards around tests and helper types.
tests/Java.Interop-Tests/Java.Interop/JavaVMFixture.csMake fallback/replacement type logic unconditional (remove NET guards).
tests/invocation-overhead/invocation-overhead.targetsDrop net472 run target and unify run path.
tests/invocation-overhead/invocation-overhead.csRemove NET-only compilation blocks and keep modern code path.
tests/generator-Tests/SupportFiles/JavaTypeParametersAttribute.csRemove legacy !NET stub support file.
tests/generator-Tests/Integration-Tests/Compiler.csAlways define NET and always reference System.Runtime.dll facade for compilation.
tests/generator-Tests/Integration-Tests/BaseGeneratorTest.csRemove NET-guarded execution of JavaInterop1 target runs.
tests/generator-Tests/expected.xaji/TestInterface/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/TestInterface/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Streams/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Streams/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/StaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/StaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/ParameterXPath/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/ParameterXPath/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalProperties/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalProperties/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NormalMethods/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NormalMethods/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NonStaticFields/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NonStaticFields/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/NestedTypes/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/NestedTypes/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.util.List/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.util.List/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/java.lang.Object/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/java.lang.Enum/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/InterfaceMethodsConflict/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/GenericArguments/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/GenericArguments/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/CSharpKeywords/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/CSharpKeywords/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_Jar2Xml/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Core_ClassParse/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Core_ClassParse/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Constructors/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Constructors/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Arrays/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Arrays/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Android.Graphics.Color/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/Adapters/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/Adapters/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
tests/generator-Tests/expected.xaji/AccessModifiers/Java.Interop.__TypeRegistrations.csUpdate expected generated output (remove NET5_0_OR_GREATER guard).
tests/generator-Tests/expected.xaji/AccessModifiers/NamespaceMapping.csUpdate expected generated output (remove legacy dummy attribute block).
src/Java.Runtime.Environment/Java.Interop/JreTypeManager.csRemove NET-only compile guard to make JRE type manager unconditional.
src/Java.Runtime.Environment/Java.Interop/JreRuntime.csRemove NET/non-NET branching in type manager selection and loader implementation.
src/Java.Interop/Java.Interop/ManagedPeer.csRemove legacy string marshaling path and always use span-based registration.
src/Java.Interop/Java.Interop/JniTypeSignature.csRemove legacy hash code implementation branch and use modern overload.
src/Java.Interop/Java.Interop/JniType.csMake helper TryParse/TryGet*Method APIs unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniRuntime.JniTypeManager.csMake replacement/fallback APIs unconditional and remove NET-only obsolete guards.
src/Java.Interop/Java.Interop/JniRuntime.csRemove NET9+ conditional around Debugger.BreakForUserUnhandledException.
src/Java.Interop/Java.Interop/JniPeerMembers.JniStaticMethods.csMake replacement/fallback lookup paths unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods.csMake replacement lookup unconditional and update stack-trace comment path.
src/Java.Interop/Java.Interop/JniPeerMembers.JniInstanceMethods_Invoke.csRemove !NET short-circuiting and always enable static redirect invoke logic.
src/Java.Interop/Java.Interop/JniPeerMembers.csMake replacement type lookup unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMethodInfo.csMake redirect metadata fields unconditional (remove NET guards).
src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JniMemberSignature.csRemove NET-only compilation guard for signature type.
src/Java.Interop/Java.Interop/JniEnvironment.Types.csMake TryFindClass unconditional and broaden DEBUG-only diagnostics.
src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.csRemove NET-only compilation guard for attribute type.
src/Java.Interop/Java.Interop/JavaArray.csUpdate nullable-contract comment and remove trailing whitespace.
src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.csRemove NETSTANDARD2_0 conditional logic around IJavaPeerable checks.
Documentation/Motivation.mdUpdate motivation text to remove obsolete legacy framework references.

Copilot's findings

  • Files reviewed: 78/78 changed files
  • Comments generated: 1

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR correctly removes all legacy #if NET, #if !NET, #if NETCOREAPP, #if NET5_0_OR_GREATER, #if NET9_0_OR_GREATER, and #if NETSTANDARD2_0 preprocessor branches from files outside external/. Since all projects target net10.0, these guards were always-true (or always-false) dead code.

What I verified

  • Correctness: In every case, the kept code path matches what was already active under net10.0. No behavioral changes.
  • Debugger.BreakForUserUnhandledException (JniRuntime.cs): API introduced in .NET 9, safe to use unconditionally on net10.0.
  • JavaNativeTypeManager.cs: NETSTANDARD2_0 fallback removed — correct since the project now targets only net10.0, not netstandard2.0.
  • Generator codegen (ClassGen.cs, NamespaceMapping.cs): Dummy SupportedOSPlatformAttribute for !NET removed; #if NET5_0_OR_GREATER around [UnconditionalSuppressMessage] removed — both consistent with modern .NET only.
  • Expected test output files: All updated consistently with the generator changes.
  • JvmLibraryHandler.Create(): Default handler correctly remains NativeLibraryJvmLibraryHandler (the NET path).
  • invocation-overhead: net472 target removed; run target renamed from _Run_netcoreapp to _Run.
  • Zero remaining NET/version guards outside external/ confirmed via grep.

CI status

⏳ The dotnet.java-interop CI build is queued but has not run yet. The author reports manual test results (671 passed for Java.Interop-Tests, 455 for generator-Tests, 47 for JCW-Tests) which is encouraging, but CI should be green before merging.

Issues found

SeverityCountCategory
💡1Formatting (double blank lines artifact)

The only issue is minor double blank lines left behind in 8 files after removing #if/#endif directives — see inline comment for the full list.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 14.5M

@@ -1,4 +1,3 @@
#if NET

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 💡 Formatting — Removing #if NET / #endif guards left behind double consecutive blank lines (or a leading blank line) in several files. The repo convention says "Don't leave random empty lines." These are minor artifacts but easy to clean up in a follow-up pass.

Affected files:

  • src/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs (lines 2–3)
  • src/Java.Interop/Java.Interop/JniConstructorSignatureAttribute.cs (lines 5–6)
  • src/Java.Interop/Java.Interop/JniMemberSignatureAttribute.cs (lines 4–5)
  • src/Java.Interop/Java.Interop/JniMethodSignatureAttribute.cs (lines 5–6)
  • src/Java.Runtime.Environment/Java.Interop/JreRuntime.cs (lines 216–217, 279–280, 337–338)
  • src/Java.Runtime.Environment/Java.Interop/JreTypeManager.cs (leading blank at line 1, lines 7–8)

Rule: Minimal diffs

@simonrozsival

Copy link
Copy Markdown
MemberAuthor

@copilot address the code review comments

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>

CopilotAI commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

@copilot address the code review comments

Addressed in 94bafb1. I changed JavaNativeTypeManager to resolve Java.Interop.IJavaPeerable with throwOnError: false and added a fallback interface-name check when that type cannot be loaded, so netstandard consumers no longer fail at runtime.

Co-authored-by: simonrozsival <374616+simonrozsival@users.noreply.github.com>
@simonrozsival

Copy link
Copy Markdown
MemberAuthor

/review

@github-actions

github-actionsBot commented Jun 9, 2026

Copy link
Copy Markdown

Java.Interop PR Reviewer completed successfully!

@github-actionsgithub-actionsBot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — Clean, well-scoped cleanup

This PR does exactly what it says: mechanically removes #if NET, #if !NET, NETCOREAPP, NET5_0_OR_GREATER, NET9_0_OR_GREATER, and NETSTANDARD2_0 preprocessor guards from code that now targets only modern .NET (net10.0).

Verified:

  • All removed code paths were the inactive branches (the #if !NET / #else arms). The surviving code is what was already compiling and running.
  • Debugger.BreakForUserUnhandledException (previously #if NET9_0_OR_GREATER) — API available since .NET 9; safe to make unconditional on net10.0.
  • string.GetHashCode(StringComparison) (previously #if NETCOREAPP) — available since .NET Core 2.1; correct to make unconditional.
  • JreRuntime switch statement merge correctly preserves the modern .NET behavior (default → NativeLibraryJvmLibraryHandler).
  • ManagedPeer.RegisterNativeMembers correctly keeps the ReadOnlySpan<char> path and removes the string-based fallback.
  • Generator output changes (ClassGen.cs, NamespaceMapping.cs) are consistent with all 40+ expected test output file updates.
  • Zero remaining NET/NETCOREAPP/NETSTANDARD/version-guard references outside external/ — confirmed.
  • The removed JavaTypeParametersAttribute.cs test support file was a !NET-only stub duplicating the real type; correctly removed.

1 suggestion: A few files have double blank lines left from the mechanical removal (listed in the inline comment). Very minor — can be addressed in a follow-up.

CI note: Only license/cla check is reported (passing). No build/test CI results visible yet — those should be verified before merging.

Generated by Java.Interop PR Reviewer for issue #1451 · ● 12.9M

Comment threadsrc/Java.Interop/Java.Interop/JavaTypeParametersAttribute.cs

@jonathanpeppersjonathanpeppers left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't find anything in dotnet/android that uses netstandard2.0 versions of these files:

Image

@jonathanpeppers
jonathanpeppers merged commit 9ca7064 into mainJun 9, 2026
2 checks passed
@jonathanpeppers
jonathanpeppers deleted the dev/simonrozsival/remove-net-define branch June 9, 2026 16:02
jonathanpeppers added a commit to dotnet/android that referenced this pull request Jun 16, 2026
Bumps [external/Java.Interop](https://github.com/dotnet/java-interop) from `b881d21` to [`6820a9cb`](dotnet/java-interop@6820a9c).
## Java.Interop changes pulled in
- [`6820a9c`](dotnet/java-interop@6820a9c) [Java.Interop] Make JavaProxyObject.RegisterNativeMembers private again ([#1468](dotnet/java-interop#1468))
- [`a2159d7`](dotnet/java-interop@a2159d70) Remove NuGet dependency grouping from Dependabot config ([#1459](dotnet/java-interop#1459))
- [`a0ca676`](dotnet/java-interop@a0ca6760) [ci] Update agentic workflows to claude-opus-4.8 ([#1461](dotnet/java-interop#1461))
- [`6d8aef7`](dotnet/java-interop@6d8aef7b) Bump to dotnet/android-tools@1fb68b6 ([#1457](dotnet/java-interop#1457))
- [`cfca8ad`](dotnet/java-interop@cfca8ad) Upgrade gh-aw to v0.79.6 and recompile workflows ([#1460](dotnet/java-interop#1460))
- [`0104236`](dotnet/java-interop@0104236e) [JniValueManager] Make TryConstructPeer virtual ([#1456](dotnet/java-interop#1456))
- [`d7dbad5`](dotnet/java-interop@d7dbad5) Remove Java.Interop.Dynamic ([#1449](dotnet/java-interop#1449))
- [`0244c10`](dotnet/java-interop@0244c10) Split reflection-based JniTypeManager and JniValueManager behavior ([#1441](dotnet/java-interop#1441))
- [`9ca7064`](dotnet/java-interop@9ca7064) [Java.Interop] Remove legacy `NET` preprocessor paths ([#1451](dotnet/java-interop#1451))
- [`cd2fc12`](dotnet/java-interop@cd2fc12) Remove Java.Interop.GenericMarshaler ([#1450](dotnet/java-interop#1450))
See full diff in [compare view](dotnet/java-interop@b881d21...6820a9c).
## Changes in this PR (beyond the submodule bump)
The Java.Interop bump — particularly [#1441](dotnet/java-interop#1441) (split reflection-based `JniTypeManager` and `JniValueManager`) and [#1449](dotnet/java-interop#1449) (removal of `Java.Interop.Dynamic`) — required a number of follow-on changes in `dotnet/android`:
### Runtime / `Mono.Android`
- **Adapt Android runtime to Java.Interop reflection managers** — switch the `JavaInteropTypeManager` / `JavaInteropValueManager` hierarchy to the new reflection-based base types and update type/value manager construction to match.
- **Change base type of value managers and type managers** so the runtime composes correctly with the new Java.Interop split.
- **Suppress reflection manager trim warnings only** — narrow the existing trim suppressions so they apply to the reflection-only managers and don't hide other warnings.
- **Suppress IL2068 on `ManagedTypeManager.GetTypeForSimpleReference`** — annotate the entry point that legitimately requires reflection so trim analysis is satisfied.
### Tests / apkdescs
- **Regenerate `BuildReleaseArm64SimpleDotNet.MonoVM.apkdesc`** to track size changes from the Java.Interop bump.
- **Regenerate Simple `BuildReleaseArm64` apkdescs** (`MonoVM` + `NativeAOT`) from a `Release` SDK so they match what CI produces.
- **Update NativeAOT warning expectations** — `Mono.Android` now produces fewer trim/AOT warnings, so loosen the strict `4 Warning(s)` checks in `SupportedOSPlatformVersion` and `CheckSignApk` to `AssertHasAtMostWarnings (2)` (new helper in `AssertionExtensions`) and drop the `BuildHasTrimmerWarnings` data counts (`3 → 2`, `4 → 3`) accordingly.
### Merges
- Two merges from `origin/main` to keep the branch current and resolve a conflict in `Microsoft.Android.Sdk.TypeMap.Trimmable.targets`.
Co-authored-by: Simon Rozsival <simon@rozsival.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Jonathan Peppers <jonathan.peppers@microsoft.com>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

ready-to-reviewThis PR is ready to review/merge, thanks!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@simonrozsival@jonathanpeppers