Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jul 6, 2026. It is now read-only.
[generator] Do not generate bindings for package-private nested types [#572] - #575
Merged
Conversation
jpobst
marked this pull request as ready for review
February 19, 2020 23:01
jonpryor pushed a commit
that referenced
this pull request
Feb 24, 2020
Fixes: #572 Do not bind ["package private"][0] nested types For example, given: public class OuterExample { /* package */ static class InnerExample { } } The type `OuterExample.InnerExample` *should not be bound*. Previously `OuterExample.InnerExample` *would* be bound as a *`public`* type (?!), which could result in later Java Callable Wrapper compilation errors, if/when they attempted to access the package-private types This change causes package-private nested types to behave the same as top-level package-private types, which were never bound. [0]: https://docs.oracle.com/javase/tutorial/java/javaOO/accesscontrol.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#572.
Do not generate bindings for
package-privatenested types to match logic for top level classes.