Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jul 6, 2026. It is now read-only.
Remove <Imports> now covered by Directory.Build.props. - #607
Merged
Conversation
jpobstforce-pushed
the
build-props-warnings
branch
from
March 19, 2020 19:43
8d52299 to
e2f2300Comparejpobst
marked this pull request as ready for review
March 19, 2020 19:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #605, we created a
Directory.Build.propsfile which automatically imports several things for all projects. The projects that are still manually importing these same files are creating duplicate warnings like:This doesn't fix the
jnienv-gen.csprojwarnings, they will be fixed when the project is converted to sdk-style.