Skip to content
This repository was archived by the owner on Jul 6, 2026. It is now read-only.

[jcw-gen] Make MSBuild warning/error strings localizable. - #695

Merged
jonpryor merged 2 commits into
masterfrom
jcw-localizable
Aug 27, 2020
Merged

[jcw-gen] Make MSBuild warning/error strings localizable.#695
jonpryor merged 2 commits into
masterfrom
jcw-localizable

Conversation

@jpobst

@jpobstjpobst commented Aug 24, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

Updates MSBuild warnings and errors in Java.Interop.Tools.JavaCallableWrappers and Java.Interop.Tools.Cecil to be localizable, building on work done in #689.

@jpobst
jpobst marked this pull request as ready for review August 24, 2020 16:56
brendanzagaeski
brendanzagaeski reviewed Aug 25, 2020
View reviewed changes

@brendanzagaeskibrendanzagaeski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I'll comment with just a few tiny wording ideas.

Comment threadsrc/Java.Interop.Localization/Resources.resx Outdated
Comment threadsrc/Java.Interop.Localization/Resources.resx Outdated
Comment threadsrc/Java.Interop.Localization/Resources.resx
Comment threadsrc/Java.Interop.Localization/Resources.resx
Comment threadsrc/Java.Interop.Localization/Resources.resx
Comment threadsrc/Java.Interop.Localization/Resources.resx Outdated
@jpobst
jpobst marked this pull request as draft August 26, 2020 18:44
@jpobst
jpobst marked this pull request as ready for review August 26, 2020 18:45
brendanzagaeski
brendanzagaeski approved these changes Aug 26, 2020
View reviewed changes
Comment threadsrc/Java.Interop.Localization/Resources.resx
</data>
<data name="JavaCallableWrappers_XA4203" xml:space="preserve">
<value>The 'Name' property must be a fully qualified 'package.TypeName' value, and no package was found for '{0}'.</value>
<value>The 'Name' property must be a fully qualified type like 'com.example.MyClass' and no package was found for '{0}'.</value>

@brendanzagaeskibrendanzagaeskiAug 26, 2020

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's fine to leave it as it is, but just to be excessively thorough, note that the English words example and My in com.example.MyClass will lose a tiny bit of special meaning in the translated versions of the message.

Although the Microsoft internal FAQ on fictitious names doesn't specifically mention example.com, I suspect that's because it's an even broader case that is accepted industry-wide (https://tools.ietf.org/html/rfc2606) and so doesn't require a specific mention in the FAQ.

@jonpryor
jonpryor merged commit c0fcc43 into masterAug 27, 2020
@jonpryor
jonpryor deleted the jcw-localizable branch August 27, 2020 19:03
@jpobstjpobst added this to the 11.1 (16.9 / 8.9) milestone Sep 3, 2020
@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@brendanzagaeskibrendanzagaeskibrendanzagaeski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

11.2 (16.9 / 8.9)

Development

Successfully merging this pull request may close these issues.

3 participants

@jpobst@brendanzagaeski@jonpryor