Skip to content
This repository was archived by the owner on Jul 6, 2026. It is now read-only.

Build with net5.0 TFM instead of netcoreapp3.1 - #747

Closed
radekdoulik wants to merge 13 commits into
dotnet:mainfrom
radekdoulik:pr-use-net50-tfm
Closed

Build with net5.0 TFM instead of netcoreapp3.1 #747
radekdoulik wants to merge 13 commits into
dotnet:mainfrom
radekdoulik:pr-use-net50-tfm

Conversation

@radekdoulik

@radekdoulikradekdoulik commented Nov 10, 2020

Copy link
Copy Markdown
Member

That would allow use of new NET5 API like the new dynamic dependency
attribute

@radekdoulik

radekdoulik commented Nov 10, 2020

Copy link
Copy Markdown
MemberAuthor

This PR is draft as it needs newer msbuild 16.8, which will be available in the next VS 2019 release.

@radekdoulikradekdoulik mentioned this pull request Nov 10, 2020
Closed
jonathanpeppers
jonathanpeppers reviewed Nov 12, 2020
View reviewed changes
Comment threadbuild-tools/automation/azure-pipelines.yaml Outdated
Comment threadsrc/Java.Interop/Java.Interop/JniTypeSignature.cs Outdated
@jpobst

jpobst commented Jan 7, 2021

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

azure-pipelinesBot commented Jan 7, 2021

Copy link
Copy Markdown
Pull request contains merge conflicts.

jonathanpeppers
jonathanpeppers reviewed Jan 7, 2021
View reviewed changes
Comment threadbuild-tools/automation/templates/core-build.yaml
Comment on lines +9 to +15
arguments: '-v:diag -c $(Build.Configuration) -target:Prepare'

- task: DotNetCoreCLI@2
displayName: Build Solution
inputs:
projects: Java.Interop.sln
arguments: '-c $(Build.Configuration) -m:1'
arguments: '-v:diag -c $(Build.Configuration) -m:1'

@jonathanpeppersjonathanpeppersJan 7, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might go ahead and add a -bl:prepare.binlog and -bl:build.binlog and upload these as artifacts.

@jpobst

jpobst commented Jan 7, 2021

Copy link
Copy Markdown
Contributor

Looks like this is blocked by mono/mono#20250. Given the lack of activity there, we may need to come up with a workaround.

@jonathanpeppers

jonathanpeppers commented Jan 7, 2021

Copy link
Copy Markdown
Member

@jpobst this is somewhat terrible, but you could try using VS Mac's MSBuild:

mono /Applications/Visual\ Studio.app/Contents/Resources/lib/monodevelop/bin/MSBuild/Current/bin/MSBuild.dll -version

I have VS Mac 8.9 Preview, and it has MSBuild 16.8.

Otherwise, you'll have to use dotnet build for net5.0 on Mac.

@jpobst

jpobst commented Jan 7, 2021

Copy link
Copy Markdown
Contributor

We have dotnet build working for .net5.0 on Mac for Java.Interop, so that's not a problem. (It's one of the build lanes.)

However, that isn't going to help when Java.Interop gets built as part of XA on Mac. We're going to have to port all of the XA build system to get that to work. 😞

Base automatically changed from master to mainJanuary 22, 2021 20:46
@jonathanpeppers

jonathanpeppers commented Apr 30, 2021

Copy link
Copy Markdown
Member

Closing this in favor of #829, I think we have a version of Mono we'll be able to do this now, but we should go straight to net6.0.

@github-actionsgithub-actionsBot locked and limited conversation to collaborators Apr 13, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pjcollinspjcollinsAwaiting requested review from pjcollins
Copilot code reviewCopilot
Copilot will automatically review once the pull request is marked ready for review
1 more reviewer
@jonathanpeppersjonathanpeppersjonathanpeppers left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@radekdoulik@jpobst@jonathanpeppers