Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Jul 6, 2026. It is now read-only.
[xamarin-android-tools] Bump to version main@34e98e2b - #887
Merged
Conversation
jpobst
marked this pull request as ready for review
October 1, 2021 20:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moving the Roslyn Analyzers initialization code from
Directory.Build.propstoDirectory.Build.targetscaused it to be applied to code imported fromxamarin-android-tools. Previously this did not affect that code because it had its ownDirectory.Build.propsfile so it did not traverse the file system upwards any further to find the Java.Interop file.Fixes for Roslyn issues has not been applied to
xamarin-android-toolscode, so it adds ~150 warnings to the JI build.The latest XAT has a
Directory.Build.targets, so updating to the latest version will prevent JI'sDirectory.Build.targetsfrom being used, excluding XAT from the Roslyn Analyzers.Changes:
dotnet/android-tools@d92fc3e...34e98e2