Uh oh!
There was an error while loading. Please reload this page.
Conversation
| per-TFM, that causes a problem because the package can't have multiple versions in it. | ||
| Set a dummy PackageVersion because we don't actually need it. | ||
| --> | ||
| <PackageVersion>1.0.0.0</PackageVersion> |
There was a problem hiding this comment.
I guess we'd change this if we ever ship a NuGet package from this repo? Maybe wouldn't happen.
There was a problem hiding this comment.
I guess we could drop this hack when we no longer target classic.
There was a problem hiding this comment.
If (when?) we ever ship a NuGet package from this repo, it should presumably match the version of Java.Interop.dll, which will match the .NET version it's shipping with (6.0.0.0, 7.0.0.0, etc.).
Thus, perhaps we should set $(PackageVersion)=6.0.0.0?
There was a problem hiding this comment.
Given that we have no intentions of releasing a NuGet package from this repo, I suspect a 6.0.0.0 version number will be just as obsolete as 1.0.0.0 if we ever do ship a package. 😁
Context: NuGet/Home#6461
Trying to build
Java.Interop.csprojin Visual Studio currently fails with several errors like:Even though we don't build NuGet packages, it still attempts to calculate the NuGet package name, which includes the assembly
$(Version)if$(PackageVersion)isn't specified. Because our assemblies have different versions per-TFM, that causes a problem because the package can't have multiple versions in it.We can set a dummy
$(PackageVersion)because we don't actually need it.Also updates the
generator.slnffor additional needed projects to buildgenerator.