Uh oh!
There was an error while loading. Please reload this page.
Counterpart fix for #44973 - remove extra "src" folder level - #308
Merged
Conversation
As discussed about two weeks back in context of dotnet#304 this change complements the runtime repo PR dotnet/runtime#44973 by fixing the correlated code in jitutils dealing with coreclr paths. Thanks Tomas
kunalspathak
approved these changes
Dec 7, 2020
BruceForstall
approved these changes
Dec 7, 2020
BruceForstall
left a comment
Contributor
There was a problem hiding this comment.
There are a couple other places that might need changing:
(option.Contains("src/jit")
and:
"-header-filter=src/jit/.*",
I don't know what those do, but they look to assume a "src" directory immediate parent to "jit".
kunalspathak
commented
Dec 7, 2020
Contributor
Good catch @BruceForstall. |
trylek
commented
Dec 7, 2020
MemberAuthor
Thanks Bruce, I have updated the two places you pointed out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed about two weeks back in context of
#304
this change complements the runtime repo PR
dotnet/runtime#44973
by fixing the correlated code in jitutils dealing with coreclr paths.
Thanks
Tomas