Skip to content

Fix "error: invalid option --metric" error - #316

Merged
sandreenko merged 1 commit into
dotnet:masterfrom
EgorBo:fix-jitutils
Feb 16, 2021
Merged

Fix "error: invalid option --metric" error#316
sandreenko merged 1 commit into
dotnet:masterfrom
EgorBo:fix-jitutils

Conversation

@EgorBo

Copy link
Copy Markdown
Member

jit-diff diff executes jit-analyze after running the diffs and always fail with error: invalid option --metric
I guess it was introduced in #312

@AndyAyersMSAndyAyersMS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Suspect many folks have shifted over to using SPMI for diffs.

@sandreenko
sandreenko merged commit e2d836e into dotnet:masterFeb 16, 2021
@JulieLeeMSFT

Copy link
Copy Markdown
Member

I had this error too. Will use this fix.

@kunalspathak

Copy link
Copy Markdown
Contributor

Thanks for fixing this.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@EgorBo@JulieLeeMSFT@kunalspathak@AndyAyersMS@sandreenko