Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic#133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomFinley merged 6 commits into from
May 12, 2018
Merged

Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
791444b
Removed calls to DateTime.Now
May 11, 2018
030fa6f
Replaced DateTime reference with UtcDatetime
May 11, 2018
0587855
Replace DateTime with DateTimeOffset
May 11, 2018
da92df9
Revert "Replace DateTime with DateTimeOffset"
May 11, 2018
b6c5d50
Replaced starttime measurement with stopwatch and reverted change tha…
Sorrien May 11, 2018
4266612
opted for the one liner version instantiating and starting the stopwatch
Sorrien May 12, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/Microsoft.ML.Core/Data/ProgressReporter.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -359,7 +359,7 @@ public CalculationInfo(int index, string name, ProgressChannel channel)
Index = index;
Name = name;
PendingCheckpoints = new ConcurrentQueue<KeyValuePair<DateTime, ProgressEntry>>();
StartTime = DateTime.Now;
StartTime = DateTime.UtcNow;
Channel = channel;
}
}
Expand DownExpand Up@@ -584,7 +584,7 @@ public ProgressEvent(int index, string name, DateTime startTime, ProgressEntry e
Index = index;
Name = name;
StartTime = startTime;
EventTime = DateTime.Now;
EventTime = DateTime.UtcNow;
Kind = EventKind.Progress;
ProgressEntry = entry;
}
Expand All@@ -597,7 +597,7 @@ public ProgressEvent(int index, string name, DateTime startTime, EventKind kind)
Index = index;
Name = name;
StartTime = startTime;
EventTime = DateTime.Now;
EventTime = DateTime.UtcNow;
Kind = kind;
ProgressEntry = null;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.Data/Utilities/TimerScope.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ public void Dispose()

// REVIEW: This is \n\n is to prevent changes across bunch of baseline files.
// Ideally we should change our comparison method to ignore empty lines.
_ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.Now, elapsedSeconds);
_ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.UtcNow, elapsedSeconds);

using (var pipe = _host.StartPipe<TelemetryMessage>("TelemetryPipe"))
{
Expand Down
7 changes: 4 additions & 3 deletions src/Microsoft.ML.FastTree/Training/EnsembleCompression/LassoBasedEnsembleCompressor.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@

using System;
using System.Collections.Generic;
using System.Diagnostics;

namespace Microsoft.ML.Runtime.FastTree.Internal
{
Expand DownExpand Up@@ -164,7 +165,7 @@ public unsafe void SetTreeScores(int idx, double[] scores)

private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
{
DateTime startTime = DateTime.Now;
Stopwatch stopWatch = Stopwatch.StartNew();

if (maxAllowedFeaturesPerModel < 0)
{
Expand DownExpand Up@@ -450,8 +451,8 @@ private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
// First lambda was infinity; fixing it
fit.Lambdas[0] = Math.Exp(2 * Math.Log(fit.Lambdas[1]) - Math.Log(fit.Lambdas[2]));

TimeSpan duration = DateTime.Now - startTime;
ch.Info("Elapsed time for compression: {0}", duration);
stopWatch.Stop();
ch.Info("Elapsed time for compression: {0}", stopWatch.Elapsed);

return fit;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.FastTree/TreeEnsemble/Ensemble.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -193,7 +193,7 @@ public string ToTreeEnsembleIni(FeaturesToContentMap fmap,

protected int AppendComments(StringBuilder sb, string trainingParams)
{
sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.Now);
sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.UtcNow);

string[] trainingParamsList = trainingParams.Split(new char[] { '\n' });
int i = 0;
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.Maml/MAML.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -145,7 +145,7 @@ internal static int MainCore(TlcEnvironment env, string args, bool alwaysPrintSt
Path.GetTempPath(),
"TLC");
var dumpFilePath = Path.Combine(dumpFileDir,
string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.Now, Guid.NewGuid()));
string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.UtcNow, Guid.NewGuid()));
bool isDumpSaved = false;
try
{
Expand Down
2 changes: 1 addition & 1 deletion src/Microsoft.ML.ResultProcessor/ResultProcessor.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -584,7 +584,7 @@ private static bool ValidateMamlOutput(string filename, string[] rawLines, out L
Results = runResults,
PerFoldResults = foldResults,
Time = 0,
ExecutionDate = DateTime.Now.ToString()
ExecutionDate = DateTime.UtcNow.ToString()
};
}

Expand Down
10 changes: 5 additions & 5 deletions src/Microsoft.ML.StandardLearners/Standard/Online/OnlineLinear.cs
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -206,7 +206,7 @@ protected virtual void InitCore(IChannel ch, int numFeatures, LinearPredictor pr
Contracts.Assert(Iteration == 0);
Contracts.Assert(Bias == 0);

ch.Trace("{0} Initializing {1} on {2} features", DateTime.Now, Name, numFeatures);
ch.Trace("{0} Initializing {1} on {2} features", DateTime.UtcNow, Name, numFeatures);
NumFeatures = numFeatures;

// We want a dense vector, to prevent memory creation during training
Expand DownExpand Up@@ -253,13 +253,13 @@ protected virtual void BeginIteration(IChannel ch)
Iteration++;
NumIterExamples = 0;

ch.Trace("{0} Starting training iteration {1}", DateTime.Now, Iteration);
ch.Trace("{0} Starting training iteration {1}", DateTime.UtcNow, Iteration);
// #if OLD_TRACING // REVIEW: How should this be ported?
if (Iteration % 20 == 0)
{
Console.Write('.');
if (Iteration % 1000 == 0)
Console.WriteLine(" {0} \t{1}", Iteration, DateTime.Now);
Console.WriteLine(" {0} \t{1}", Iteration, DateTime.UtcNow);
}
// #endif
}
Expand All@@ -269,7 +269,7 @@ protected virtual void FinishIteration(IChannel ch)
Contracts.Check(NumIterExamples > 0, NoTrainingInstancesMessage);

ch.Trace("{0} Finished training iteration {1}; iterated over {2} examples.",
DateTime.Now, Iteration, NumIterExamples);
DateTime.UtcNow, Iteration, NumIterExamples);

ScaleWeights();
#if OLD_TRACING // REVIEW: How should this be ported?
Expand DownExpand Up@@ -378,7 +378,7 @@ protected virtual void ProcessDataInstance(IChannel ch, ref VBuffer<Float> feat,
if (_numIterExamples % 5000000 == 0)
{
Host.StdOut.Write(" ");
Host.StdOut.Write(DateTime.Now);
Host.StdOut.Write(DateTime.UtcNow);
}
Host.StdOut.WriteLine();
}
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic#133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TomFinley
merged 6 commits into

from

May 12, 2018
 Merged


Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic
#133
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
791444b

Removed calls to DateTime.Now

May 11, 2018
030fa6f

Replaced DateTime reference with UtcDatetime

May 11, 2018
0587855

Replace DateTime with DateTimeOffset

May 11, 2018
da92df9

Revert "Replace DateTime with DateTimeOffset"

May 11, 2018
b6c5d50

Replaced starttime measurement with stopwatch and reverted change tha…


Sorrien May 11, 2018
4266612

opted for the one liner version instantiating and starting the stopwatch


Sorrien May 12, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/Microsoft.ML.Core/Data/ProgressReporter.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -359,7 +359,7 @@ public CalculationInfo(int index, string name, ProgressChannel channel)
 Index = index;
 Name = name;
 PendingCheckpoints = new ConcurrentQueue<KeyValuePair<DateTime, ProgressEntry>>();
 StartTime = DateTime.Now;
 StartTime = DateTime.UtcNow;
 Channel = channel;
 }
 }
Expand DownExpand Up@@ -584,7 +584,7 @@ public ProgressEvent(int index, string name, DateTime startTime, ProgressEntry e
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = EventKind.Progress;
 ProgressEntry = entry;
 }
Expand All@@ -597,7 +597,7 @@ public ProgressEvent(int index, string name, DateTime startTime, EventKind kind)
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = kind;
 ProgressEntry = null;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Data/Utilities/TimerScope.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ public void Dispose()

 // REVIEW: This is \n\n is to prevent changes across bunch of baseline files.
 // Ideally we should change our comparison method to ignore empty lines.
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.Now, elapsedSeconds);
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.UtcNow, elapsedSeconds);

 using (var pipe = _host.StartPipe<TelemetryMessage>("TelemetryPipe"))
 {
Expand Down

7 changes: 4 additions & 3 deletions
src/Microsoft.ML.FastTree/Training/EnsembleCompression/LassoBasedEnsembleCompressor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@

using System;
using System.Collections.Generic;
using System.Diagnostics;

namespace Microsoft.ML.Runtime.FastTree.Internal
{
Expand DownExpand Up@@ -164,7 +165,7 @@ public unsafe void SetTreeScores(int idx, double[] scores)

 private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 {
DateTime startTime = DateTime.Now;
Stopwatch stopWatch = Stopwatch.StartNew();

 if (maxAllowedFeaturesPerModel < 0)
 {
Expand DownExpand Up@@ -450,8 +451,8 @@ private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 // First lambda was infinity; fixing it
 fit.Lambdas[0] = Math.Exp(2 * Math.Log(fit.Lambdas[1]) - Math.Log(fit.Lambdas[2]));

TimeSpan duration = DateTime.Now - startTime;
 ch.Info("Elapsed time for compression: {0}", duration);
stopWatch.Stop();
 ch.Info("Elapsed time for compression: {0}", stopWatch.Elapsed);

 return fit;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.FastTree/TreeEnsemble/Ensemble.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -193,7 +193,7 @@ public string ToTreeEnsembleIni(FeaturesToContentMap fmap,

 protected int AppendComments(StringBuilder sb, string trainingParams)
 {
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.Now);
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.UtcNow);

 string[] trainingParamsList = trainingParams.Split(new char[] { '\n' });
 int i = 0;
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Maml/MAML.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,7 +145,7 @@ internal static int MainCore(TlcEnvironment env, string args, bool alwaysPrintSt
 Path.GetTempPath(),
 "TLC");
 var dumpFilePath = Path.Combine(dumpFileDir,
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.Now, Guid.NewGuid()));
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.UtcNow, Guid.NewGuid()));
 bool isDumpSaved = false;
 try
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.ResultProcessor/ResultProcessor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -584,7 +584,7 @@ private static bool ValidateMamlOutput(string filename, string[] rawLines, out L
 Results = runResults,
 PerFoldResults = foldResults,
 Time = 0,
 ExecutionDate = DateTime.Now.ToString()
 ExecutionDate = DateTime.UtcNow.ToString()
 };
 }

Expand Down

10 changes: 5 additions & 5 deletions
src/Microsoft.ML.StandardLearners/Standard/Online/OnlineLinear.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -206,7 +206,7 @@ protected virtual void InitCore(IChannel ch, int numFeatures, LinearPredictor pr
 Contracts.Assert(Iteration == 0);
 Contracts.Assert(Bias == 0);

 ch.Trace("{0} Initializing {1} on {2} features", DateTime.Now, Name, numFeatures);
 ch.Trace("{0} Initializing {1} on {2} features", DateTime.UtcNow, Name, numFeatures);
 NumFeatures = numFeatures;

 // We want a dense vector, to prevent memory creation during training
Expand DownExpand Up@@ -253,13 +253,13 @@ protected virtual void BeginIteration(IChannel ch)
 Iteration++;
 NumIterExamples = 0;

 ch.Trace("{0} Starting training iteration {1}", DateTime.Now, Iteration);
 ch.Trace("{0} Starting training iteration {1}", DateTime.UtcNow, Iteration);
 // #if OLD_TRACING // REVIEW: How should this be ported?
 if (Iteration % 20 == 0)
 {
 Console.Write('.');
 if (Iteration % 1000 == 0)
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.Now);
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.UtcNow);
 }
 // #endif
 }
Expand All@@ -269,7 +269,7 @@ protected virtual void FinishIteration(IChannel ch)
 Contracts.Check(NumIterExamples > 0, NoTrainingInstancesMessage);

 ch.Trace("{0} Finished training iteration {1}; iterated over {2} examples.",
 DateTime.Now, Iteration, NumIterExamples);
 DateTime.UtcNow, Iteration, NumIterExamples);

 ScaleWeights();
#if OLD_TRACING // REVIEW: How should this be ported?
Expand DownExpand Up@@ -378,7 +378,7 @@ protected virtual void ProcessDataInstance(IChannel ch, ref VBuffer<Float> feat,
 if (_numIterExamples % 5000000 == 0)
 {
 Host.StdOut.Write(" ");
 Host.StdOut.Write(DateTime.Now);
 Host.StdOut.Write(DateTime.UtcNow);
 }
 Host.StdOut.WriteLine();
 }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic#133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TomFinley
merged 6 commits into

from

May 12, 2018
 Merged


Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic
#133
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
791444b

Removed calls to DateTime.Now

May 11, 2018
030fa6f

Replaced DateTime reference with UtcDatetime

May 11, 2018
0587855

Replace DateTime with DateTimeOffset

May 11, 2018
da92df9

Revert "Replace DateTime with DateTimeOffset"

May 11, 2018
b6c5d50

Replaced starttime measurement with stopwatch and reverted change tha…


Sorrien May 11, 2018
4266612

opted for the one liner version instantiating and starting the stopwatch


Sorrien May 12, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/Microsoft.ML.Core/Data/ProgressReporter.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -359,7 +359,7 @@ public CalculationInfo(int index, string name, ProgressChannel channel)
 Index = index;
 Name = name;
 PendingCheckpoints = new ConcurrentQueue<KeyValuePair<DateTime, ProgressEntry>>();
 StartTime = DateTime.Now;
 StartTime = DateTime.UtcNow;
 Channel = channel;
 }
 }
Expand DownExpand Up@@ -584,7 +584,7 @@ public ProgressEvent(int index, string name, DateTime startTime, ProgressEntry e
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = EventKind.Progress;
 ProgressEntry = entry;
 }
Expand All@@ -597,7 +597,7 @@ public ProgressEvent(int index, string name, DateTime startTime, EventKind kind)
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = kind;
 ProgressEntry = null;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Data/Utilities/TimerScope.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ public void Dispose()

 // REVIEW: This is \n\n is to prevent changes across bunch of baseline files.
 // Ideally we should change our comparison method to ignore empty lines.
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.Now, elapsedSeconds);
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.UtcNow, elapsedSeconds);

 using (var pipe = _host.StartPipe<TelemetryMessage>("TelemetryPipe"))
 {
Expand Down

7 changes: 4 additions & 3 deletions
src/Microsoft.ML.FastTree/Training/EnsembleCompression/LassoBasedEnsembleCompressor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@

using System;
using System.Collections.Generic;
using System.Diagnostics;

namespace Microsoft.ML.Runtime.FastTree.Internal
{
Expand DownExpand Up@@ -164,7 +165,7 @@ public unsafe void SetTreeScores(int idx, double[] scores)

 private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 {
DateTime startTime = DateTime.Now;
Stopwatch stopWatch = Stopwatch.StartNew();

 if (maxAllowedFeaturesPerModel < 0)
 {
Expand DownExpand Up@@ -450,8 +451,8 @@ private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 // First lambda was infinity; fixing it
 fit.Lambdas[0] = Math.Exp(2 * Math.Log(fit.Lambdas[1]) - Math.Log(fit.Lambdas[2]));

TimeSpan duration = DateTime.Now - startTime;
 ch.Info("Elapsed time for compression: {0}", duration);
stopWatch.Stop();
 ch.Info("Elapsed time for compression: {0}", stopWatch.Elapsed);

 return fit;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.FastTree/TreeEnsemble/Ensemble.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -193,7 +193,7 @@ public string ToTreeEnsembleIni(FeaturesToContentMap fmap,

 protected int AppendComments(StringBuilder sb, string trainingParams)
 {
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.Now);
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.UtcNow);

 string[] trainingParamsList = trainingParams.Split(new char[] { '\n' });
 int i = 0;
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Maml/MAML.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,7 +145,7 @@ internal static int MainCore(TlcEnvironment env, string args, bool alwaysPrintSt
 Path.GetTempPath(),
 "TLC");
 var dumpFilePath = Path.Combine(dumpFileDir,
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.Now, Guid.NewGuid()));
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.UtcNow, Guid.NewGuid()));
 bool isDumpSaved = false;
 try
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.ResultProcessor/ResultProcessor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -584,7 +584,7 @@ private static bool ValidateMamlOutput(string filename, string[] rawLines, out L
 Results = runResults,
 PerFoldResults = foldResults,
 Time = 0,
 ExecutionDate = DateTime.Now.ToString()
 ExecutionDate = DateTime.UtcNow.ToString()
 };
 }

Expand Down

10 changes: 5 additions & 5 deletions
src/Microsoft.ML.StandardLearners/Standard/Online/OnlineLinear.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -206,7 +206,7 @@ protected virtual void InitCore(IChannel ch, int numFeatures, LinearPredictor pr
 Contracts.Assert(Iteration == 0);
 Contracts.Assert(Bias == 0);

 ch.Trace("{0} Initializing {1} on {2} features", DateTime.Now, Name, numFeatures);
 ch.Trace("{0} Initializing {1} on {2} features", DateTime.UtcNow, Name, numFeatures);
 NumFeatures = numFeatures;

 // We want a dense vector, to prevent memory creation during training
Expand DownExpand Up@@ -253,13 +253,13 @@ protected virtual void BeginIteration(IChannel ch)
 Iteration++;
 NumIterExamples = 0;

 ch.Trace("{0} Starting training iteration {1}", DateTime.Now, Iteration);
 ch.Trace("{0} Starting training iteration {1}", DateTime.UtcNow, Iteration);
 // #if OLD_TRACING // REVIEW: How should this be ported?
 if (Iteration % 20 == 0)
 {
 Console.Write('.');
 if (Iteration % 1000 == 0)
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.Now);
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.UtcNow);
 }
 // #endif
 }
Expand All@@ -269,7 +269,7 @@ protected virtual void FinishIteration(IChannel ch)
 Contracts.Check(NumIterExamples > 0, NoTrainingInstancesMessage);

 ch.Trace("{0} Finished training iteration {1}; iterated over {2} examples.",
 DateTime.Now, Iteration, NumIterExamples);
 DateTime.UtcNow, Iteration, NumIterExamples);

 ScaleWeights();
#if OLD_TRACING // REVIEW: How should this be ported?
Expand DownExpand Up@@ -378,7 +378,7 @@ protected virtual void ProcessDataInstance(IChannel ch, ref VBuffer<Float> feat,
 if (_numIterExamples % 5000000 == 0)
 {
 Host.StdOut.Write(" ");
 Host.StdOut.Write(DateTime.Now);
 Host.StdOut.Write(DateTime.UtcNow);
 }
 Host.StdOut.WriteLine();
 }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic#133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TomFinley
merged 6 commits into

from

May 12, 2018
 Merged


Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic
#133
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
791444b

Removed calls to DateTime.Now

May 11, 2018
030fa6f

Replaced DateTime reference with UtcDatetime

May 11, 2018
0587855

Replace DateTime with DateTimeOffset

May 11, 2018
da92df9

Revert "Replace DateTime with DateTimeOffset"

May 11, 2018
b6c5d50

Replaced starttime measurement with stopwatch and reverted change tha…


Sorrien May 11, 2018
4266612

opted for the one liner version instantiating and starting the stopwatch


Sorrien May 12, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/Microsoft.ML.Core/Data/ProgressReporter.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -359,7 +359,7 @@ public CalculationInfo(int index, string name, ProgressChannel channel)
 Index = index;
 Name = name;
 PendingCheckpoints = new ConcurrentQueue<KeyValuePair<DateTime, ProgressEntry>>();
 StartTime = DateTime.Now;
 StartTime = DateTime.UtcNow;
 Channel = channel;
 }
 }
Expand DownExpand Up@@ -584,7 +584,7 @@ public ProgressEvent(int index, string name, DateTime startTime, ProgressEntry e
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = EventKind.Progress;
 ProgressEntry = entry;
 }
Expand All@@ -597,7 +597,7 @@ public ProgressEvent(int index, string name, DateTime startTime, EventKind kind)
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = kind;
 ProgressEntry = null;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Data/Utilities/TimerScope.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ public void Dispose()

 // REVIEW: This is \n\n is to prevent changes across bunch of baseline files.
 // Ideally we should change our comparison method to ignore empty lines.
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.Now, elapsedSeconds);
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.UtcNow, elapsedSeconds);

 using (var pipe = _host.StartPipe<TelemetryMessage>("TelemetryPipe"))
 {
Expand Down

7 changes: 4 additions & 3 deletions
src/Microsoft.ML.FastTree/Training/EnsembleCompression/LassoBasedEnsembleCompressor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@

using System;
using System.Collections.Generic;
using System.Diagnostics;

namespace Microsoft.ML.Runtime.FastTree.Internal
{
Expand DownExpand Up@@ -164,7 +165,7 @@ public unsafe void SetTreeScores(int idx, double[] scores)

 private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 {
DateTime startTime = DateTime.Now;
Stopwatch stopWatch = Stopwatch.StartNew();

 if (maxAllowedFeaturesPerModel < 0)
 {
Expand DownExpand Up@@ -450,8 +451,8 @@ private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 // First lambda was infinity; fixing it
 fit.Lambdas[0] = Math.Exp(2 * Math.Log(fit.Lambdas[1]) - Math.Log(fit.Lambdas[2]));

TimeSpan duration = DateTime.Now - startTime;
 ch.Info("Elapsed time for compression: {0}", duration);
stopWatch.Stop();
 ch.Info("Elapsed time for compression: {0}", stopWatch.Elapsed);

 return fit;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.FastTree/TreeEnsemble/Ensemble.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -193,7 +193,7 @@ public string ToTreeEnsembleIni(FeaturesToContentMap fmap,

 protected int AppendComments(StringBuilder sb, string trainingParams)
 {
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.Now);
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.UtcNow);

 string[] trainingParamsList = trainingParams.Split(new char[] { '\n' });
 int i = 0;
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Maml/MAML.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,7 +145,7 @@ internal static int MainCore(TlcEnvironment env, string args, bool alwaysPrintSt
 Path.GetTempPath(),
 "TLC");
 var dumpFilePath = Path.Combine(dumpFileDir,
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.Now, Guid.NewGuid()));
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.UtcNow, Guid.NewGuid()));
 bool isDumpSaved = false;
 try
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.ResultProcessor/ResultProcessor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -584,7 +584,7 @@ private static bool ValidateMamlOutput(string filename, string[] rawLines, out L
 Results = runResults,
 PerFoldResults = foldResults,
 Time = 0,
 ExecutionDate = DateTime.Now.ToString()
 ExecutionDate = DateTime.UtcNow.ToString()
 };
 }

Expand Down

10 changes: 5 additions & 5 deletions
src/Microsoft.ML.StandardLearners/Standard/Online/OnlineLinear.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -206,7 +206,7 @@ protected virtual void InitCore(IChannel ch, int numFeatures, LinearPredictor pr
 Contracts.Assert(Iteration == 0);
 Contracts.Assert(Bias == 0);

 ch.Trace("{0} Initializing {1} on {2} features", DateTime.Now, Name, numFeatures);
 ch.Trace("{0} Initializing {1} on {2} features", DateTime.UtcNow, Name, numFeatures);
 NumFeatures = numFeatures;

 // We want a dense vector, to prevent memory creation during training
Expand DownExpand Up@@ -253,13 +253,13 @@ protected virtual void BeginIteration(IChannel ch)
 Iteration++;
 NumIterExamples = 0;

 ch.Trace("{0} Starting training iteration {1}", DateTime.Now, Iteration);
 ch.Trace("{0} Starting training iteration {1}", DateTime.UtcNow, Iteration);
 // #if OLD_TRACING // REVIEW: How should this be ported?
 if (Iteration % 20 == 0)
 {
 Console.Write('.');
 if (Iteration % 1000 == 0)
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.Now);
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.UtcNow);
 }
 // #endif
 }
Expand All@@ -269,7 +269,7 @@ protected virtual void FinishIteration(IChannel ch)
 Contracts.Check(NumIterExamples > 0, NoTrainingInstancesMessage);

 ch.Trace("{0} Finished training iteration {1}; iterated over {2} examples.",
 DateTime.Now, Iteration, NumIterExamples);
 DateTime.UtcNow, Iteration, NumIterExamples);

 ScaleWeights();
#if OLD_TRACING // REVIEW: How should this be ported?
Expand DownExpand Up@@ -378,7 +378,7 @@ protected virtual void ProcessDataInstance(IChannel ch, ref VBuffer<Float> feat,
 if (_numIterExamples % 5000000 == 0)
 {
 Host.StdOut.Write(" ");
 Host.StdOut.Write(DateTime.Now);
 Host.StdOut.Write(DateTime.UtcNow);
 }
 Host.StdOut.WriteLine();
 }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic#133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TomFinley
merged 6 commits into

from

May 12, 2018
 Merged


Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic
#133
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
791444b

Removed calls to DateTime.Now

May 11, 2018
030fa6f

Replaced DateTime reference with UtcDatetime

May 11, 2018
0587855

Replace DateTime with DateTimeOffset

May 11, 2018
da92df9

Revert "Replace DateTime with DateTimeOffset"

May 11, 2018
b6c5d50

Replaced starttime measurement with stopwatch and reverted change tha…


Sorrien May 11, 2018
4266612

opted for the one liner version instantiating and starting the stopwatch


Sorrien May 12, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/Microsoft.ML.Core/Data/ProgressReporter.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -359,7 +359,7 @@ public CalculationInfo(int index, string name, ProgressChannel channel)
 Index = index;
 Name = name;
 PendingCheckpoints = new ConcurrentQueue<KeyValuePair<DateTime, ProgressEntry>>();
 StartTime = DateTime.Now;
 StartTime = DateTime.UtcNow;
 Channel = channel;
 }
 }
Expand DownExpand Up@@ -584,7 +584,7 @@ public ProgressEvent(int index, string name, DateTime startTime, ProgressEntry e
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = EventKind.Progress;
 ProgressEntry = entry;
 }
Expand All@@ -597,7 +597,7 @@ public ProgressEvent(int index, string name, DateTime startTime, EventKind kind)
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = kind;
 ProgressEntry = null;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Data/Utilities/TimerScope.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ public void Dispose()

 // REVIEW: This is \n\n is to prevent changes across bunch of baseline files.
 // Ideally we should change our comparison method to ignore empty lines.
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.Now, elapsedSeconds);
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.UtcNow, elapsedSeconds);

 using (var pipe = _host.StartPipe<TelemetryMessage>("TelemetryPipe"))
 {
Expand Down

7 changes: 4 additions & 3 deletions
src/Microsoft.ML.FastTree/Training/EnsembleCompression/LassoBasedEnsembleCompressor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@

using System;
using System.Collections.Generic;
using System.Diagnostics;

namespace Microsoft.ML.Runtime.FastTree.Internal
{
Expand DownExpand Up@@ -164,7 +165,7 @@ public unsafe void SetTreeScores(int idx, double[] scores)

 private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 {
DateTime startTime = DateTime.Now;
Stopwatch stopWatch = Stopwatch.StartNew();

 if (maxAllowedFeaturesPerModel < 0)
 {
Expand DownExpand Up@@ -450,8 +451,8 @@ private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 // First lambda was infinity; fixing it
 fit.Lambdas[0] = Math.Exp(2 * Math.Log(fit.Lambdas[1]) - Math.Log(fit.Lambdas[2]));

TimeSpan duration = DateTime.Now - startTime;
 ch.Info("Elapsed time for compression: {0}", duration);
stopWatch.Stop();
 ch.Info("Elapsed time for compression: {0}", stopWatch.Elapsed);

 return fit;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.FastTree/TreeEnsemble/Ensemble.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -193,7 +193,7 @@ public string ToTreeEnsembleIni(FeaturesToContentMap fmap,

 protected int AppendComments(StringBuilder sb, string trainingParams)
 {
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.Now);
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.UtcNow);

 string[] trainingParamsList = trainingParams.Split(new char[] { '\n' });
 int i = 0;
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Maml/MAML.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,7 +145,7 @@ internal static int MainCore(TlcEnvironment env, string args, bool alwaysPrintSt
 Path.GetTempPath(),
 "TLC");
 var dumpFilePath = Path.Combine(dumpFileDir,
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.Now, Guid.NewGuid()));
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.UtcNow, Guid.NewGuid()));
 bool isDumpSaved = false;
 try
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.ResultProcessor/ResultProcessor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -584,7 +584,7 @@ private static bool ValidateMamlOutput(string filename, string[] rawLines, out L
 Results = runResults,
 PerFoldResults = foldResults,
 Time = 0,
 ExecutionDate = DateTime.Now.ToString()
 ExecutionDate = DateTime.UtcNow.ToString()
 };
 }

Expand Down

10 changes: 5 additions & 5 deletions
src/Microsoft.ML.StandardLearners/Standard/Online/OnlineLinear.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -206,7 +206,7 @@ protected virtual void InitCore(IChannel ch, int numFeatures, LinearPredictor pr
 Contracts.Assert(Iteration == 0);
 Contracts.Assert(Bias == 0);

 ch.Trace("{0} Initializing {1} on {2} features", DateTime.Now, Name, numFeatures);
 ch.Trace("{0} Initializing {1} on {2} features", DateTime.UtcNow, Name, numFeatures);
 NumFeatures = numFeatures;

 // We want a dense vector, to prevent memory creation during training
Expand DownExpand Up@@ -253,13 +253,13 @@ protected virtual void BeginIteration(IChannel ch)
 Iteration++;
 NumIterExamples = 0;

 ch.Trace("{0} Starting training iteration {1}", DateTime.Now, Iteration);
 ch.Trace("{0} Starting training iteration {1}", DateTime.UtcNow, Iteration);
 // #if OLD_TRACING // REVIEW: How should this be ported?
 if (Iteration % 20 == 0)
 {
 Console.Write('.');
 if (Iteration % 1000 == 0)
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.Now);
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.UtcNow);
 }
 // #endif
 }
Expand All@@ -269,7 +269,7 @@ protected virtual void FinishIteration(IChannel ch)
 Contracts.Check(NumIterExamples > 0, NoTrainingInstancesMessage);

 ch.Trace("{0} Finished training iteration {1}; iterated over {2} examples.",
 DateTime.Now, Iteration, NumIterExamples);
 DateTime.UtcNow, Iteration, NumIterExamples);

 ScaleWeights();
#if OLD_TRACING // REVIEW: How should this be ported?
Expand DownExpand Up@@ -378,7 +378,7 @@ protected virtual void ProcessDataInstance(IChannel ch, ref VBuffer<Float> feat,
 if (_numIterExamples % 5000000 == 0)
 {
 Host.StdOut.Write(" ");
 Host.StdOut.Write(DateTime.Now);
 Host.StdOut.Write(DateTime.UtcNow);
 }
 Host.StdOut.WriteLine();
 }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic#133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TomFinley
merged 6 commits into

from

May 12, 2018
 Merged


Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic
#133
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
791444b

Removed calls to DateTime.Now

May 11, 2018
030fa6f

Replaced DateTime reference with UtcDatetime

May 11, 2018
0587855

Replace DateTime with DateTimeOffset

May 11, 2018
da92df9

Revert "Replace DateTime with DateTimeOffset"

May 11, 2018
b6c5d50

Replaced starttime measurement with stopwatch and reverted change tha…


Sorrien May 11, 2018
4266612

opted for the one liner version instantiating and starting the stopwatch


Sorrien May 12, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/Microsoft.ML.Core/Data/ProgressReporter.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -359,7 +359,7 @@ public CalculationInfo(int index, string name, ProgressChannel channel)
 Index = index;
 Name = name;
 PendingCheckpoints = new ConcurrentQueue<KeyValuePair<DateTime, ProgressEntry>>();
 StartTime = DateTime.Now;
 StartTime = DateTime.UtcNow;
 Channel = channel;
 }
 }
Expand DownExpand Up@@ -584,7 +584,7 @@ public ProgressEvent(int index, string name, DateTime startTime, ProgressEntry e
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = EventKind.Progress;
 ProgressEntry = entry;
 }
Expand All@@ -597,7 +597,7 @@ public ProgressEvent(int index, string name, DateTime startTime, EventKind kind)
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = kind;
 ProgressEntry = null;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Data/Utilities/TimerScope.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ public void Dispose()

 // REVIEW: This is \n\n is to prevent changes across bunch of baseline files.
 // Ideally we should change our comparison method to ignore empty lines.
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.Now, elapsedSeconds);
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.UtcNow, elapsedSeconds);

 using (var pipe = _host.StartPipe<TelemetryMessage>("TelemetryPipe"))
 {
Expand Down

7 changes: 4 additions & 3 deletions
src/Microsoft.ML.FastTree/Training/EnsembleCompression/LassoBasedEnsembleCompressor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@

using System;
using System.Collections.Generic;
using System.Diagnostics;

namespace Microsoft.ML.Runtime.FastTree.Internal
{
Expand DownExpand Up@@ -164,7 +165,7 @@ public unsafe void SetTreeScores(int idx, double[] scores)

 private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 {
DateTime startTime = DateTime.Now;
Stopwatch stopWatch = Stopwatch.StartNew();

 if (maxAllowedFeaturesPerModel < 0)
 {
Expand DownExpand Up@@ -450,8 +451,8 @@ private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 // First lambda was infinity; fixing it
 fit.Lambdas[0] = Math.Exp(2 * Math.Log(fit.Lambdas[1]) - Math.Log(fit.Lambdas[2]));

TimeSpan duration = DateTime.Now - startTime;
 ch.Info("Elapsed time for compression: {0}", duration);
stopWatch.Stop();
 ch.Info("Elapsed time for compression: {0}", stopWatch.Elapsed);

 return fit;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.FastTree/TreeEnsemble/Ensemble.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -193,7 +193,7 @@ public string ToTreeEnsembleIni(FeaturesToContentMap fmap,

 protected int AppendComments(StringBuilder sb, string trainingParams)
 {
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.Now);
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.UtcNow);

 string[] trainingParamsList = trainingParams.Split(new char[] { '\n' });
 int i = 0;
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Maml/MAML.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,7 +145,7 @@ internal static int MainCore(TlcEnvironment env, string args, bool alwaysPrintSt
 Path.GetTempPath(),
 "TLC");
 var dumpFilePath = Path.Combine(dumpFileDir,
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.Now, Guid.NewGuid()));
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.UtcNow, Guid.NewGuid()));
 bool isDumpSaved = false;
 try
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.ResultProcessor/ResultProcessor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -584,7 +584,7 @@ private static bool ValidateMamlOutput(string filename, string[] rawLines, out L
 Results = runResults,
 PerFoldResults = foldResults,
 Time = 0,
 ExecutionDate = DateTime.Now.ToString()
 ExecutionDate = DateTime.UtcNow.ToString()
 };
 }

Expand Down

10 changes: 5 additions & 5 deletions
src/Microsoft.ML.StandardLearners/Standard/Online/OnlineLinear.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -206,7 +206,7 @@ protected virtual void InitCore(IChannel ch, int numFeatures, LinearPredictor pr
 Contracts.Assert(Iteration == 0);
 Contracts.Assert(Bias == 0);

 ch.Trace("{0} Initializing {1} on {2} features", DateTime.Now, Name, numFeatures);
 ch.Trace("{0} Initializing {1} on {2} features", DateTime.UtcNow, Name, numFeatures);
 NumFeatures = numFeatures;

 // We want a dense vector, to prevent memory creation during training
Expand DownExpand Up@@ -253,13 +253,13 @@ protected virtual void BeginIteration(IChannel ch)
 Iteration++;
 NumIterExamples = 0;

 ch.Trace("{0} Starting training iteration {1}", DateTime.Now, Iteration);
 ch.Trace("{0} Starting training iteration {1}", DateTime.UtcNow, Iteration);
 // #if OLD_TRACING // REVIEW: How should this be ported?
 if (Iteration % 20 == 0)
 {
 Console.Write('.');
 if (Iteration % 1000 == 0)
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.Now);
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.UtcNow);
 }
 // #endif
 }
Expand All@@ -269,7 +269,7 @@ protected virtual void FinishIteration(IChannel ch)
 Contracts.Check(NumIterExamples > 0, NoTrainingInstancesMessage);

 ch.Trace("{0} Finished training iteration {1}; iterated over {2} examples.",
 DateTime.Now, Iteration, NumIterExamples);
 DateTime.UtcNow, Iteration, NumIterExamples);

 ScaleWeights();
#if OLD_TRACING // REVIEW: How should this be ported?
Expand DownExpand Up@@ -378,7 +378,7 @@ protected virtual void ProcessDataInstance(IChannel ch, ref VBuffer<Float> feat,
 if (_numIterExamples % 5000000 == 0)
 {
 Host.StdOut.Write(" ");
 Host.StdOut.Write(DateTime.Now);
 Host.StdOut.Write(DateTime.UtcNow);
 }
 Host.StdOut.WriteLine();
 }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic#133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TomFinley
merged 6 commits into

from

May 12, 2018
 Merged


Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic
#133
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
791444b

Removed calls to DateTime.Now

May 11, 2018
030fa6f

Replaced DateTime reference with UtcDatetime

May 11, 2018
0587855

Replace DateTime with DateTimeOffset

May 11, 2018
da92df9

Revert "Replace DateTime with DateTimeOffset"

May 11, 2018
b6c5d50

Replaced starttime measurement with stopwatch and reverted change tha…


Sorrien May 11, 2018
4266612

opted for the one liner version instantiating and starting the stopwatch


Sorrien May 12, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/Microsoft.ML.Core/Data/ProgressReporter.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -359,7 +359,7 @@ public CalculationInfo(int index, string name, ProgressChannel channel)
 Index = index;
 Name = name;
 PendingCheckpoints = new ConcurrentQueue<KeyValuePair<DateTime, ProgressEntry>>();
 StartTime = DateTime.Now;
 StartTime = DateTime.UtcNow;
 Channel = channel;
 }
 }
Expand DownExpand Up@@ -584,7 +584,7 @@ public ProgressEvent(int index, string name, DateTime startTime, ProgressEntry e
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = EventKind.Progress;
 ProgressEntry = entry;
 }
Expand All@@ -597,7 +597,7 @@ public ProgressEvent(int index, string name, DateTime startTime, EventKind kind)
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = kind;
 ProgressEntry = null;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Data/Utilities/TimerScope.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ public void Dispose()

 // REVIEW: This is \n\n is to prevent changes across bunch of baseline files.
 // Ideally we should change our comparison method to ignore empty lines.
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.Now, elapsedSeconds);
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.UtcNow, elapsedSeconds);

 using (var pipe = _host.StartPipe<TelemetryMessage>("TelemetryPipe"))
 {
Expand Down

7 changes: 4 additions & 3 deletions
src/Microsoft.ML.FastTree/Training/EnsembleCompression/LassoBasedEnsembleCompressor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@

using System;
using System.Collections.Generic;
using System.Diagnostics;

namespace Microsoft.ML.Runtime.FastTree.Internal
{
Expand DownExpand Up@@ -164,7 +165,7 @@ public unsafe void SetTreeScores(int idx, double[] scores)

 private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 {
DateTime startTime = DateTime.Now;
Stopwatch stopWatch = Stopwatch.StartNew();

 if (maxAllowedFeaturesPerModel < 0)
 {
Expand DownExpand Up@@ -450,8 +451,8 @@ private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 // First lambda was infinity; fixing it
 fit.Lambdas[0] = Math.Exp(2 * Math.Log(fit.Lambdas[1]) - Math.Log(fit.Lambdas[2]));

TimeSpan duration = DateTime.Now - startTime;
 ch.Info("Elapsed time for compression: {0}", duration);
stopWatch.Stop();
 ch.Info("Elapsed time for compression: {0}", stopWatch.Elapsed);

 return fit;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.FastTree/TreeEnsemble/Ensemble.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -193,7 +193,7 @@ public string ToTreeEnsembleIni(FeaturesToContentMap fmap,

 protected int AppendComments(StringBuilder sb, string trainingParams)
 {
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.Now);
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.UtcNow);

 string[] trainingParamsList = trainingParams.Split(new char[] { '\n' });
 int i = 0;
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Maml/MAML.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,7 +145,7 @@ internal static int MainCore(TlcEnvironment env, string args, bool alwaysPrintSt
 Path.GetTempPath(),
 "TLC");
 var dumpFilePath = Path.Combine(dumpFileDir,
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.Now, Guid.NewGuid()));
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.UtcNow, Guid.NewGuid()));
 bool isDumpSaved = false;
 try
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.ResultProcessor/ResultProcessor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -584,7 +584,7 @@ private static bool ValidateMamlOutput(string filename, string[] rawLines, out L
 Results = runResults,
 PerFoldResults = foldResults,
 Time = 0,
 ExecutionDate = DateTime.Now.ToString()
 ExecutionDate = DateTime.UtcNow.ToString()
 };
 }

Expand Down

10 changes: 5 additions & 5 deletions
src/Microsoft.ML.StandardLearners/Standard/Online/OnlineLinear.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -206,7 +206,7 @@ protected virtual void InitCore(IChannel ch, int numFeatures, LinearPredictor pr
 Contracts.Assert(Iteration == 0);
 Contracts.Assert(Bias == 0);

 ch.Trace("{0} Initializing {1} on {2} features", DateTime.Now, Name, numFeatures);
 ch.Trace("{0} Initializing {1} on {2} features", DateTime.UtcNow, Name, numFeatures);
 NumFeatures = numFeatures;

 // We want a dense vector, to prevent memory creation during training
Expand DownExpand Up@@ -253,13 +253,13 @@ protected virtual void BeginIteration(IChannel ch)
 Iteration++;
 NumIterExamples = 0;

 ch.Trace("{0} Starting training iteration {1}", DateTime.Now, Iteration);
 ch.Trace("{0} Starting training iteration {1}", DateTime.UtcNow, Iteration);
 // #if OLD_TRACING // REVIEW: How should this be ported?
 if (Iteration % 20 == 0)
 {
 Console.Write('.');
 if (Iteration % 1000 == 0)
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.Now);
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.UtcNow);
 }
 // #endif
 }
Expand All@@ -269,7 +269,7 @@ protected virtual void FinishIteration(IChannel ch)
 Contracts.Check(NumIterExamples > 0, NoTrainingInstancesMessage);

 ch.Trace("{0} Finished training iteration {1}; iterated over {2} examples.",
 DateTime.Now, Iteration, NumIterExamples);
 DateTime.UtcNow, Iteration, NumIterExamples);

 ScaleWeights();
#if OLD_TRACING // REVIEW: How should this be ported?
Expand DownExpand Up@@ -378,7 +378,7 @@ protected virtual void ProcessDataInstance(IChannel ch, ref VBuffer<Float> feat,
 if (_numIterExamples % 5000000 == 0)
 {
 Host.StdOut.Write(" ");
 Host.StdOut.Write(DateTime.Now);
 Host.StdOut.Write(DateTime.UtcNow);
 }
 Host.StdOut.WriteLine();
 }
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic#133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

TomFinley
merged 6 commits into

from

May 12, 2018
 Merged


Replaced calls to DateTime.Now with DateTime.UtcNow to be locale agnostic
#133
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


6 commits


Select commit
Hold shift + click to select a range
791444b

Removed calls to DateTime.Now

May 11, 2018
030fa6f

Replaced DateTime reference with UtcDatetime

May 11, 2018
0587855

Replace DateTime with DateTimeOffset

May 11, 2018
da92df9

Revert "Replace DateTime with DateTimeOffset"

May 11, 2018
b6c5d50

Replaced starttime measurement with stopwatch and reverted change tha…


Sorrien May 11, 2018
4266612

opted for the one liner version instantiating and starting the stopwatch


Sorrien May 12, 2018

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


6 changes: 3 additions & 3 deletions
src/Microsoft.ML.Core/Data/ProgressReporter.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -359,7 +359,7 @@ public CalculationInfo(int index, string name, ProgressChannel channel)
 Index = index;
 Name = name;
 PendingCheckpoints = new ConcurrentQueue<KeyValuePair<DateTime, ProgressEntry>>();
 StartTime = DateTime.Now;
 StartTime = DateTime.UtcNow;
 Channel = channel;
 }
 }
Expand DownExpand Up@@ -584,7 +584,7 @@ public ProgressEvent(int index, string name, DateTime startTime, ProgressEntry e
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = EventKind.Progress;
 ProgressEntry = entry;
 }
Expand All@@ -597,7 +597,7 @@ public ProgressEvent(int index, string name, DateTime startTime, EventKind kind)
 Index = index;
 Name = name;
 StartTime = startTime;
 EventTime = DateTime.Now;
 EventTime = DateTime.UtcNow;
 Kind = kind;
 ProgressEntry = null;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Data/Utilities/TimerScope.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -46,7 +46,7 @@ public void Dispose()

 // REVIEW: This is \n\n is to prevent changes across bunch of baseline files.
 // Ideally we should change our comparison method to ignore empty lines.
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.Now, elapsedSeconds);
 _ch.Info("{0}\t Time elapsed(s): {1}\n\n", DateTime.UtcNow, elapsedSeconds);

 using (var pipe = _host.StartPipe<TelemetryMessage>("TelemetryPipe"))
 {
Expand Down

7 changes: 4 additions & 3 deletions
src/Microsoft.ML.FastTree/Training/EnsembleCompression/LassoBasedEnsembleCompressor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,7 @@

using System;
using System.Collections.Generic;
using System.Diagnostics;

namespace Microsoft.ML.Runtime.FastTree.Internal
{
Expand DownExpand Up@@ -164,7 +165,7 @@ public unsafe void SetTreeScores(int idx, double[] scores)

 private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 {
DateTime startTime = DateTime.Now;
Stopwatch stopWatch = Stopwatch.StartNew();

 if (maxAllowedFeaturesPerModel < 0)
 {
Expand DownExpand Up@@ -450,8 +451,8 @@ private LassoFit GetLassoFit(IChannel ch, int maxAllowedFeaturesPerModel)
 // First lambda was infinity; fixing it
 fit.Lambdas[0] = Math.Exp(2 * Math.Log(fit.Lambdas[1]) - Math.Log(fit.Lambdas[2]));

TimeSpan duration = DateTime.Now - startTime;
 ch.Info("Elapsed time for compression: {0}", duration);
stopWatch.Stop();
 ch.Info("Elapsed time for compression: {0}", stopWatch.Elapsed);

 return fit;
 }
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.FastTree/TreeEnsemble/Ensemble.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -193,7 +193,7 @@ public string ToTreeEnsembleIni(FeaturesToContentMap fmap,

 protected int AppendComments(StringBuilder sb, string trainingParams)
 {
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.Now);
 sb.AppendFormat("\n\n[Comments]\nC:0=Regression Tree Ensemble\nC:1=Generated using FastTree\nC:2=Created on {0}\n", DateTime.UtcNow);

 string[] trainingParamsList = trainingParams.Split(new char[] { '\n' });
 int i = 0;
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.Maml/MAML.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -145,7 +145,7 @@ internal static int MainCore(TlcEnvironment env, string args, bool alwaysPrintSt
 Path.GetTempPath(),
 "TLC");
 var dumpFilePath = Path.Combine(dumpFileDir,
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.Now, Guid.NewGuid()));
 string.Format(CultureInfo.InvariantCulture, "Error_{0:yyyyMMdd_HHmmss}_{1}.log", DateTime.UtcNow, Guid.NewGuid()));
 bool isDumpSaved = false;
 try
 {
Expand Down

2 changes: 1 addition & 1 deletion
src/Microsoft.ML.ResultProcessor/ResultProcessor.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -584,7 +584,7 @@ private static bool ValidateMamlOutput(string filename, string[] rawLines, out L
 Results = runResults,
 PerFoldResults = foldResults,
 Time = 0,
 ExecutionDate = DateTime.Now.ToString()
 ExecutionDate = DateTime.UtcNow.ToString()
 };
 }

Expand Down

10 changes: 5 additions & 5 deletions
src/Microsoft.ML.StandardLearners/Standard/Online/OnlineLinear.cs

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -206,7 +206,7 @@ protected virtual void InitCore(IChannel ch, int numFeatures, LinearPredictor pr
 Contracts.Assert(Iteration == 0);
 Contracts.Assert(Bias == 0);

 ch.Trace("{0} Initializing {1} on {2} features", DateTime.Now, Name, numFeatures);
 ch.Trace("{0} Initializing {1} on {2} features", DateTime.UtcNow, Name, numFeatures);
 NumFeatures = numFeatures;

 // We want a dense vector, to prevent memory creation during training
Expand DownExpand Up@@ -253,13 +253,13 @@ protected virtual void BeginIteration(IChannel ch)
 Iteration++;
 NumIterExamples = 0;

 ch.Trace("{0} Starting training iteration {1}", DateTime.Now, Iteration);
 ch.Trace("{0} Starting training iteration {1}", DateTime.UtcNow, Iteration);
 // #if OLD_TRACING // REVIEW: How should this be ported?
 if (Iteration % 20 == 0)
 {
 Console.Write('.');
 if (Iteration % 1000 == 0)
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.Now);
 Console.WriteLine(" {0} \t{1}", Iteration, DateTime.UtcNow);
 }
 // #endif
 }
Expand All@@ -269,7 +269,7 @@ protected virtual void FinishIteration(IChannel ch)
 Contracts.Check(NumIterExamples > 0, NoTrainingInstancesMessage);

 ch.Trace("{0} Finished training iteration {1}; iterated over {2} examples.",
 DateTime.Now, Iteration, NumIterExamples);
 DateTime.UtcNow, Iteration, NumIterExamples);

 ScaleWeights();
#if OLD_TRACING // REVIEW: How should this be ported?
Expand DownExpand Up@@ -378,7 +378,7 @@ protected virtual void ProcessDataInstance(IChannel ch, ref VBuffer<Float> feat,
 if (_numIterExamples % 5000000 == 0)
 {
 Host.StdOut.Write(" ");
 Host.StdOut.Write(DateTime.Now);
 Host.StdOut.Write(DateTime.UtcNow);
 }
 Host.StdOut.WriteLine();
 }
Expand Down