switch housing dataset to wine - #170

Merged
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
May 23, 2018
Merged

switch housing dataset to wine#170
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine

Conversation

@Ivanidzo4ka

@Ivanidzo4kaIvanidzo4ka commented May 16, 2018

Copy link
Copy Markdown
Contributor

This commit replaces housing dataset to wine dataset which we download during build from external source

@Ivanidzo4kaIvanidzo4ka mentioned this pull request May 16, 2018
Closed
@Ivanidzo4ka

Ivanidzo4ka commented May 16, 2018

Copy link
Copy Markdown
ContributorAuthor

address #3

eerhardt
eerhardt reviewed May 16, 2018
View reviewed changes
Comment threadbuild.proj Outdated
</TestFile>
</ItemGroup>

<Target Name="DownloadExternalTestFiles" Inputs="@(TestFile)" Outputs="%(TestFile.Result)">

@eerhardteerhardtMay 16, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do me a favor and test this with 2 or 3 datasets downloaded from the internet? (I guess it can be any file, it doesn't have to be a .csv file) I just want to ensure this works with more than 1 file, and it works correctly when doing it a 2nd time that the data sets aren't downloaded on subsequent builds.

That way the next person who needs to add a dataset isn't bit by a bug here.

@Ivanidzo4kaIvanidzo4kaMay 16, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<ItemGroup> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/image.png" Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/logo.png" Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile> </TestFile> </ItemGroup>
test it with this. tried different combinations, they all work
Is there are any way to format it properly?

@eerhardteerhardtMay 17, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! nice to hear it works for many items.

As for the formatting, if you use triple back-ticks ``` at the start of a line, markdown will show exactly what you type until the next set of triple back-ticks. This is useful for displaying code. You can even put a code hint after the triple back-ticks XML, and markdown will syntax highlight. So if I take your comment above it looks like this:

<ItemGroup>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/image.png"Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/logo.png"Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile>
</TestFile>
</ItemGroup>

See https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markdown for more info.

@eerhardt

eerhardt commented May 16, 2018

Copy link
Copy Markdown
Member

I see a few more references to housing.txt in the test code:

F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestCSharpApi.cs(275): var dataPath = GetDataPath(@"housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(861): var dataPath = GetDataPath("housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(893): TestEntryPointRoutine("housing.txt", "Trainers.StochasticDualCoordinateAscentRegressor");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(967): TestEntryPointRoutine("housing.txt", "Trainers.PoissonRegressor");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(151): trainFilename = "housing.txt",
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(152): testFilename = "housing.txt"
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1496): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1536): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1608): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1649): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");

Can you update them all?

danmoseley
danmoseley reviewed May 17, 2018
View reviewed changes
Comment threadbuild.proj Outdated


<ItemGroup>
<TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">

@danmoseleydanmoseleyMay 17, 2018•
edited by Ivanidzo4ka
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, I believe the attribute and subelement formats are equivalent, you might want to pick one or the other. #Resolved

@Ivanidzo4kaIvanidzo4kaMay 18, 2018

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't move Include to subelement, but I can move Url to it. having everything as attribute is looks too long

In reply to: 189065564 [](ancestors = 189065564)

@eerhardteerhardtMay 22, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a requesting change here, just giving some information for future reference.

The Include attribute on an MSBuild Item is "special". It has to be an XML attribute. Before MSBuild v15, all "custom" metadata (like your Url attribute) could NOT be put as an XML attribute - instead it had to be a sub-element. In v15, they changed it so custom metadata now can be in either an attribute or sub-element.

A format I like and use regularly is the following:

 <TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"DestinationFile="$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv" />

I think it is compact, reads easy, and is easy to maintain/update.

@Ivanidzo4ka

Ivanidzo4ka commented May 18, 2018

Copy link
Copy Markdown
ContributorAuthor

We don't run any of these tests. #78 Anirudh has PR to enable them, and it should be resolved in that PR. (Either by Anirudh, or me)

In reply to: 389680637 [](ancestors = 389680637)

@Ivanidzo4ka

Ivanidzo4ka commented May 18, 2018

Copy link
Copy Markdown
ContributorAuthor

@dotnet-bot test Windows_NT Debug

eerhardt
eerhardt approved these changes May 22, 2018
View reviewed changes

@eerhardteerhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4kaIvanidzo4ka mentioned this pull request May 22, 2018
Closed
@Ivanidzo4ka

Ivanidzo4ka commented May 22, 2018

Copy link
Copy Markdown
ContributorAuthor

Anyone other than Eric can look on this? @glebuk

@glebuk

glebuk commented May 22, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor
 using (var loader = new BinaryLoader(Env, new BinaryLoader.Arguments(), confusionMatrixPath))

Missing TestCSarpAPI?
#Closed

Refers to: test/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs:1037 in 45478c2. [](commit_id = 45478c2, deletion_comment = False)

glebuk
glebuk reviewed May 22, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs Outdated
public void EntryPointEvaluateRegression()
{
var dataPath = GetDataPath("housing.txt");
var dataPath = GetDataPath(@"external/winequality-white.csv");

@glebukglebukMay 22, 2018•
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@"external/winequality-white.csv [](start = 39, length = 32)

Extract dataset info into static dataset classes so that no need to repeat paths and schemas. Ideally you can even just return a new loader for each dataset. #Closed

glebuk
glebuk approved these changes May 23, 2018
View reviewed changes

@glebukglebuk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Ivanidzo4ka
Ivanidzo4ka merged commit d51321c into dotnet:masterMay 23, 2018
eerhardt pushed a commit to eerhardt/machinelearning that referenced this pull request Jul 27, 2018
@Ivanidzo4ka@eerhardt
switch housing dataset to wine (dotnet#170)
5a454ab
* replace housing uci dataset to wine quality
@ghostghost locked as resolved and limited conversation to collaborators Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

3 more reviewers
@danmoseleydanmoseleydanmoseley left review comments
@eerhardteerhardteerhardt approved these changes
@glebukglebukglebuk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Ivanidzo4ka@eerhardt@glebuk@danmoseley
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
switch housing dataset to wine - #170
Merged
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
May 23, 2018
Merged
switch housing dataset to wine#170
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
Conversation
@Ivanidzo4ka
@Ivanidzo4kaIvanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

Contributor
This commit replaces housing dataset to wine dataset which we download during build from external source
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 16, 2018
 Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

ContributorAuthor
address #3
eerhardt
eerhardt
reviewed
May 16, 2018
View reviewed changes
Comment threadbuild.proj
Outdated

 </TestFile>
 </ItemGroup>

 <Target Name="DownloadExternalTestFiles" Inputs="@(TestFile)" Outputs="%(TestFile.Result)">
@eerhardteerhardtMay 16, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do me a favor and test this with 2 or 3 datasets downloaded from the internet? (I guess it can be any file, it doesn't have to be a .csv file) I just want to ensure this works with more than 1 file, and it works correctly when doing it a 2nd time that the data sets aren't downloaded on subsequent builds.
That way the next person who needs to add a dataset isn't bit by a bug here.
@Ivanidzo4kaIvanidzo4kaMay 16, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 <ItemGroup> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/image.png" Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/logo.png" Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile> </TestFile> </ItemGroup>

test it with this. tried different combinations, they all work

Is there are any way to format it properly?
@eerhardteerhardtMay 17, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! nice to hear it works for many items.
As for the formatting, if you use triple back-ticks ``` at the start of a line, markdown will show exactly what you type until the next set of triple back-ticks. This is useful for displaying code. You can even put a code hint after the triple back-ticks XML, and markdown will syntax highlight. So if I take your comment above it looks like this:
<ItemGroup>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/image.png"Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/logo.png"Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile>
</TestFile>
</ItemGroup>
See https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markdown for more info.
@eerhardt
eerhardt
commented
May 16, 2018

Copy link


Copy Markdown

Member
I see a few more references to housing.txt in the test code:
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestCSharpApi.cs(275): var dataPath = GetDataPath(@"housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(861): var dataPath = GetDataPath("housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(893): TestEntryPointRoutine("housing.txt", "Trainers.StochasticDualCoordinateAscentRegressor");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(967): TestEntryPointRoutine("housing.txt", "Trainers.PoissonRegressor");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(151): trainFilename = "housing.txt",
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(152): testFilename = "housing.txt"
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1496): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1536): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1608): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1649): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");

Can you update them all?
danmoseley
danmoseley
reviewed
May 17, 2018
View reviewed changes
Comment threadbuild.proj
Outdated



 <ItemGroup>
 <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
@danmoseleydanmoseleyMay 17, 2018•

edited by Ivanidzo4ka

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, I believe the attribute and subelement formats are equivalent, you might want to pick one or the other. #Resolved
@Ivanidzo4kaIvanidzo4kaMay 18, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't move Include to subelement, but I can move Url to it. having everything as attribute is looks too long
In reply to: 189065564 [](ancestors = 189065564)
@eerhardteerhardtMay 22, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a requesting change here, just giving some information for future reference.
The Include attribute on an MSBuild Item is "special". It has to be an XML attribute. Before MSBuild v15, all "custom" metadata (like your Url attribute) could NOT be put as an XML attribute - instead it had to be a sub-element. In v15, they changed it so custom metadata now can be in either an attribute or sub-element.
A format I like and use regularly is the following:
 <TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"DestinationFile="$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv" />
I think it is compact, reads easy, and is easy to maintain/update.
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
We don't run any of these tests. #78 Anirudh has PR to enable them, and it should be resolved in that PR. (Either by Anirudh, or me)
In reply to: 389680637 [](ancestors = 389680637)
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
@dotnet-bot test Windows_NT Debug
eerhardt
eerhardt
approved these changes
May 22, 2018
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 22, 2018

Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 22, 2018

Copy link


Copy Markdown

ContributorAuthor
Anyone other than Eric can look on this? @glebuk
@glebuk
glebuk
commented
May 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 using (var loader = new BinaryLoader(Env, new BinaryLoader.Arguments(), confusionMatrixPath))

Missing TestCSarpAPI?

#Closed
Refers to: test/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs:1037 in 45478c2. [](commit_id = 45478c2, deletion_comment = False)
glebuk
glebuk
reviewed
May 22, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
Outdated

 public void EntryPointEvaluateRegression()
 {
 var dataPath = GetDataPath("housing.txt");
 var dataPath = GetDataPath(@"external/winequality-white.csv");
@glebukglebukMay 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@"external/winequality-white.csv [](start = 39, length = 32)
Extract dataset info into static dataset classes so that no need to repeat paths and schemas. Ideally you can even just return a new loader for each dataset. #Closed
glebuk
glebuk
approved these changes
May 23, 2018
View reviewed changes
@glebukglebuk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit d51321c
into
dotnet:masterMay 23, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@Ivanidzo4ka@eerhardt
switch housing dataset to wine (dotnet#170)
5a454ab
* replace housing uci dataset to wine quality
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@eerhardteerhardteerhardt approved these changes
@glebukglebukglebuk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ivanidzo4ka@eerhardt@glebuk@danmoseley

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
switch housing dataset to wine - #170
Merged
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
May 23, 2018
Merged
switch housing dataset to wine#170
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
Conversation
@Ivanidzo4ka
@Ivanidzo4kaIvanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

Contributor
This commit replaces housing dataset to wine dataset which we download during build from external source
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 16, 2018
 Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

ContributorAuthor
address #3
eerhardt
eerhardt
reviewed
May 16, 2018
View reviewed changes
Comment threadbuild.proj
Outdated

 </TestFile>
 </ItemGroup>

 <Target Name="DownloadExternalTestFiles" Inputs="@(TestFile)" Outputs="%(TestFile.Result)">
@eerhardteerhardtMay 16, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do me a favor and test this with 2 or 3 datasets downloaded from the internet? (I guess it can be any file, it doesn't have to be a .csv file) I just want to ensure this works with more than 1 file, and it works correctly when doing it a 2nd time that the data sets aren't downloaded on subsequent builds.
That way the next person who needs to add a dataset isn't bit by a bug here.
@Ivanidzo4kaIvanidzo4kaMay 16, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 <ItemGroup> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/image.png" Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/logo.png" Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile> </TestFile> </ItemGroup>

test it with this. tried different combinations, they all work

Is there are any way to format it properly?
@eerhardteerhardtMay 17, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! nice to hear it works for many items.
As for the formatting, if you use triple back-ticks ``` at the start of a line, markdown will show exactly what you type until the next set of triple back-ticks. This is useful for displaying code. You can even put a code hint after the triple back-ticks XML, and markdown will syntax highlight. So if I take your comment above it looks like this:
<ItemGroup>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/image.png"Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/logo.png"Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile>
</TestFile>
</ItemGroup>
See https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markdown for more info.
@eerhardt
eerhardt
commented
May 16, 2018

Copy link


Copy Markdown

Member
I see a few more references to housing.txt in the test code:
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestCSharpApi.cs(275): var dataPath = GetDataPath(@"housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(861): var dataPath = GetDataPath("housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(893): TestEntryPointRoutine("housing.txt", "Trainers.StochasticDualCoordinateAscentRegressor");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(967): TestEntryPointRoutine("housing.txt", "Trainers.PoissonRegressor");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(151): trainFilename = "housing.txt",
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(152): testFilename = "housing.txt"
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1496): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1536): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1608): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1649): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");

Can you update them all?
danmoseley
danmoseley
reviewed
May 17, 2018
View reviewed changes
Comment threadbuild.proj
Outdated



 <ItemGroup>
 <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
@danmoseleydanmoseleyMay 17, 2018•

edited by Ivanidzo4ka

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, I believe the attribute and subelement formats are equivalent, you might want to pick one or the other. #Resolved
@Ivanidzo4kaIvanidzo4kaMay 18, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't move Include to subelement, but I can move Url to it. having everything as attribute is looks too long
In reply to: 189065564 [](ancestors = 189065564)
@eerhardteerhardtMay 22, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a requesting change here, just giving some information for future reference.
The Include attribute on an MSBuild Item is "special". It has to be an XML attribute. Before MSBuild v15, all "custom" metadata (like your Url attribute) could NOT be put as an XML attribute - instead it had to be a sub-element. In v15, they changed it so custom metadata now can be in either an attribute or sub-element.
A format I like and use regularly is the following:
 <TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"DestinationFile="$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv" />
I think it is compact, reads easy, and is easy to maintain/update.
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
We don't run any of these tests. #78 Anirudh has PR to enable them, and it should be resolved in that PR. (Either by Anirudh, or me)
In reply to: 389680637 [](ancestors = 389680637)
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
@dotnet-bot test Windows_NT Debug
eerhardt
eerhardt
approved these changes
May 22, 2018
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 22, 2018

Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 22, 2018

Copy link


Copy Markdown

ContributorAuthor
Anyone other than Eric can look on this? @glebuk
@glebuk
glebuk
commented
May 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 using (var loader = new BinaryLoader(Env, new BinaryLoader.Arguments(), confusionMatrixPath))

Missing TestCSarpAPI?

#Closed
Refers to: test/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs:1037 in 45478c2. [](commit_id = 45478c2, deletion_comment = False)
glebuk
glebuk
reviewed
May 22, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
Outdated

 public void EntryPointEvaluateRegression()
 {
 var dataPath = GetDataPath("housing.txt");
 var dataPath = GetDataPath(@"external/winequality-white.csv");
@glebukglebukMay 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@"external/winequality-white.csv [](start = 39, length = 32)
Extract dataset info into static dataset classes so that no need to repeat paths and schemas. Ideally you can even just return a new loader for each dataset. #Closed
glebuk
glebuk
approved these changes
May 23, 2018
View reviewed changes
@glebukglebuk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit d51321c
into
dotnet:masterMay 23, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@Ivanidzo4ka@eerhardt
switch housing dataset to wine (dotnet#170)
5a454ab
* replace housing uci dataset to wine quality
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@eerhardteerhardteerhardt approved these changes
@glebukglebukglebuk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ivanidzo4ka@eerhardt@glebuk@danmoseley

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
switch housing dataset to wine - #170
Merged
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
May 23, 2018
Merged
switch housing dataset to wine#170
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
Conversation
@Ivanidzo4ka
@Ivanidzo4kaIvanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

Contributor
This commit replaces housing dataset to wine dataset which we download during build from external source
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 16, 2018
 Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

ContributorAuthor
address #3
eerhardt
eerhardt
reviewed
May 16, 2018
View reviewed changes
Comment threadbuild.proj
Outdated

 </TestFile>
 </ItemGroup>

 <Target Name="DownloadExternalTestFiles" Inputs="@(TestFile)" Outputs="%(TestFile.Result)">
@eerhardteerhardtMay 16, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do me a favor and test this with 2 or 3 datasets downloaded from the internet? (I guess it can be any file, it doesn't have to be a .csv file) I just want to ensure this works with more than 1 file, and it works correctly when doing it a 2nd time that the data sets aren't downloaded on subsequent builds.
That way the next person who needs to add a dataset isn't bit by a bug here.
@Ivanidzo4kaIvanidzo4kaMay 16, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 <ItemGroup> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/image.png" Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/logo.png" Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile> </TestFile> </ItemGroup>

test it with this. tried different combinations, they all work

Is there are any way to format it properly?
@eerhardteerhardtMay 17, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! nice to hear it works for many items.
As for the formatting, if you use triple back-ticks ``` at the start of a line, markdown will show exactly what you type until the next set of triple back-ticks. This is useful for displaying code. You can even put a code hint after the triple back-ticks XML, and markdown will syntax highlight. So if I take your comment above it looks like this:
<ItemGroup>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/image.png"Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/logo.png"Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile>
</TestFile>
</ItemGroup>
See https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markdown for more info.
@eerhardt
eerhardt
commented
May 16, 2018

Copy link


Copy Markdown

Member
I see a few more references to housing.txt in the test code:
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestCSharpApi.cs(275): var dataPath = GetDataPath(@"housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(861): var dataPath = GetDataPath("housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(893): TestEntryPointRoutine("housing.txt", "Trainers.StochasticDualCoordinateAscentRegressor");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(967): TestEntryPointRoutine("housing.txt", "Trainers.PoissonRegressor");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(151): trainFilename = "housing.txt",
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(152): testFilename = "housing.txt"
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1496): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1536): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1608): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1649): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");

Can you update them all?
danmoseley
danmoseley
reviewed
May 17, 2018
View reviewed changes
Comment threadbuild.proj
Outdated



 <ItemGroup>
 <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
@danmoseleydanmoseleyMay 17, 2018•

edited by Ivanidzo4ka

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, I believe the attribute and subelement formats are equivalent, you might want to pick one or the other. #Resolved
@Ivanidzo4kaIvanidzo4kaMay 18, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't move Include to subelement, but I can move Url to it. having everything as attribute is looks too long
In reply to: 189065564 [](ancestors = 189065564)
@eerhardteerhardtMay 22, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a requesting change here, just giving some information for future reference.
The Include attribute on an MSBuild Item is "special". It has to be an XML attribute. Before MSBuild v15, all "custom" metadata (like your Url attribute) could NOT be put as an XML attribute - instead it had to be a sub-element. In v15, they changed it so custom metadata now can be in either an attribute or sub-element.
A format I like and use regularly is the following:
 <TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"DestinationFile="$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv" />
I think it is compact, reads easy, and is easy to maintain/update.
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
We don't run any of these tests. #78 Anirudh has PR to enable them, and it should be resolved in that PR. (Either by Anirudh, or me)
In reply to: 389680637 [](ancestors = 389680637)
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
@dotnet-bot test Windows_NT Debug
eerhardt
eerhardt
approved these changes
May 22, 2018
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 22, 2018

Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 22, 2018

Copy link


Copy Markdown

ContributorAuthor
Anyone other than Eric can look on this? @glebuk
@glebuk
glebuk
commented
May 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 using (var loader = new BinaryLoader(Env, new BinaryLoader.Arguments(), confusionMatrixPath))

Missing TestCSarpAPI?

#Closed
Refers to: test/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs:1037 in 45478c2. [](commit_id = 45478c2, deletion_comment = False)
glebuk
glebuk
reviewed
May 22, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
Outdated

 public void EntryPointEvaluateRegression()
 {
 var dataPath = GetDataPath("housing.txt");
 var dataPath = GetDataPath(@"external/winequality-white.csv");
@glebukglebukMay 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@"external/winequality-white.csv [](start = 39, length = 32)
Extract dataset info into static dataset classes so that no need to repeat paths and schemas. Ideally you can even just return a new loader for each dataset. #Closed
glebuk
glebuk
approved these changes
May 23, 2018
View reviewed changes
@glebukglebuk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit d51321c
into
dotnet:masterMay 23, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@Ivanidzo4ka@eerhardt
switch housing dataset to wine (dotnet#170)
5a454ab
* replace housing uci dataset to wine quality
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@eerhardteerhardteerhardt approved these changes
@glebukglebukglebuk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ivanidzo4ka@eerhardt@glebuk@danmoseley

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
switch housing dataset to wine - #170
Merged
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
May 23, 2018
Merged
switch housing dataset to wine#170
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
Conversation
@Ivanidzo4ka
@Ivanidzo4kaIvanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

Contributor
This commit replaces housing dataset to wine dataset which we download during build from external source
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 16, 2018
 Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

ContributorAuthor
address #3
eerhardt
eerhardt
reviewed
May 16, 2018
View reviewed changes
Comment threadbuild.proj
Outdated

 </TestFile>
 </ItemGroup>

 <Target Name="DownloadExternalTestFiles" Inputs="@(TestFile)" Outputs="%(TestFile.Result)">
@eerhardteerhardtMay 16, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do me a favor and test this with 2 or 3 datasets downloaded from the internet? (I guess it can be any file, it doesn't have to be a .csv file) I just want to ensure this works with more than 1 file, and it works correctly when doing it a 2nd time that the data sets aren't downloaded on subsequent builds.
That way the next person who needs to add a dataset isn't bit by a bug here.
@Ivanidzo4kaIvanidzo4kaMay 16, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 <ItemGroup> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/image.png" Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/logo.png" Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile> </TestFile> </ItemGroup>

test it with this. tried different combinations, they all work

Is there are any way to format it properly?
@eerhardteerhardtMay 17, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! nice to hear it works for many items.
As for the formatting, if you use triple back-ticks ``` at the start of a line, markdown will show exactly what you type until the next set of triple back-ticks. This is useful for displaying code. You can even put a code hint after the triple back-ticks XML, and markdown will syntax highlight. So if I take your comment above it looks like this:
<ItemGroup>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/image.png"Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/logo.png"Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile>
</TestFile>
</ItemGroup>
See https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markdown for more info.
@eerhardt
eerhardt
commented
May 16, 2018

Copy link


Copy Markdown

Member
I see a few more references to housing.txt in the test code:
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestCSharpApi.cs(275): var dataPath = GetDataPath(@"housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(861): var dataPath = GetDataPath("housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(893): TestEntryPointRoutine("housing.txt", "Trainers.StochasticDualCoordinateAscentRegressor");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(967): TestEntryPointRoutine("housing.txt", "Trainers.PoissonRegressor");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(151): trainFilename = "housing.txt",
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(152): testFilename = "housing.txt"
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1496): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1536): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1608): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1649): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");

Can you update them all?
danmoseley
danmoseley
reviewed
May 17, 2018
View reviewed changes
Comment threadbuild.proj
Outdated



 <ItemGroup>
 <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
@danmoseleydanmoseleyMay 17, 2018•

edited by Ivanidzo4ka

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, I believe the attribute and subelement formats are equivalent, you might want to pick one or the other. #Resolved
@Ivanidzo4kaIvanidzo4kaMay 18, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't move Include to subelement, but I can move Url to it. having everything as attribute is looks too long
In reply to: 189065564 [](ancestors = 189065564)
@eerhardteerhardtMay 22, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a requesting change here, just giving some information for future reference.
The Include attribute on an MSBuild Item is "special". It has to be an XML attribute. Before MSBuild v15, all "custom" metadata (like your Url attribute) could NOT be put as an XML attribute - instead it had to be a sub-element. In v15, they changed it so custom metadata now can be in either an attribute or sub-element.
A format I like and use regularly is the following:
 <TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"DestinationFile="$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv" />
I think it is compact, reads easy, and is easy to maintain/update.
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
We don't run any of these tests. #78 Anirudh has PR to enable them, and it should be resolved in that PR. (Either by Anirudh, or me)
In reply to: 389680637 [](ancestors = 389680637)
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
@dotnet-bot test Windows_NT Debug
eerhardt
eerhardt
approved these changes
May 22, 2018
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 22, 2018

Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 22, 2018

Copy link


Copy Markdown

ContributorAuthor
Anyone other than Eric can look on this? @glebuk
@glebuk
glebuk
commented
May 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 using (var loader = new BinaryLoader(Env, new BinaryLoader.Arguments(), confusionMatrixPath))

Missing TestCSarpAPI?

#Closed
Refers to: test/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs:1037 in 45478c2. [](commit_id = 45478c2, deletion_comment = False)
glebuk
glebuk
reviewed
May 22, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
Outdated

 public void EntryPointEvaluateRegression()
 {
 var dataPath = GetDataPath("housing.txt");
 var dataPath = GetDataPath(@"external/winequality-white.csv");
@glebukglebukMay 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@"external/winequality-white.csv [](start = 39, length = 32)
Extract dataset info into static dataset classes so that no need to repeat paths and schemas. Ideally you can even just return a new loader for each dataset. #Closed
glebuk
glebuk
approved these changes
May 23, 2018
View reviewed changes
@glebukglebuk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit d51321c
into
dotnet:masterMay 23, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@Ivanidzo4ka@eerhardt
switch housing dataset to wine (dotnet#170)
5a454ab
* replace housing uci dataset to wine quality
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@eerhardteerhardteerhardt approved these changes
@glebukglebukglebuk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ivanidzo4ka@eerhardt@glebuk@danmoseley

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
switch housing dataset to wine - #170
Merged
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
May 23, 2018
Merged
switch housing dataset to wine#170
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
Conversation
@Ivanidzo4ka
@Ivanidzo4kaIvanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

Contributor
This commit replaces housing dataset to wine dataset which we download during build from external source
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 16, 2018
 Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

ContributorAuthor
address #3
eerhardt
eerhardt
reviewed
May 16, 2018
View reviewed changes
Comment threadbuild.proj
Outdated

 </TestFile>
 </ItemGroup>

 <Target Name="DownloadExternalTestFiles" Inputs="@(TestFile)" Outputs="%(TestFile.Result)">
@eerhardteerhardtMay 16, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do me a favor and test this with 2 or 3 datasets downloaded from the internet? (I guess it can be any file, it doesn't have to be a .csv file) I just want to ensure this works with more than 1 file, and it works correctly when doing it a 2nd time that the data sets aren't downloaded on subsequent builds.
That way the next person who needs to add a dataset isn't bit by a bug here.
@Ivanidzo4kaIvanidzo4kaMay 16, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 <ItemGroup> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/image.png" Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/logo.png" Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile> </TestFile> </ItemGroup>

test it with this. tried different combinations, they all work

Is there are any way to format it properly?
@eerhardteerhardtMay 17, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! nice to hear it works for many items.
As for the formatting, if you use triple back-ticks ``` at the start of a line, markdown will show exactly what you type until the next set of triple back-ticks. This is useful for displaying code. You can even put a code hint after the triple back-ticks XML, and markdown will syntax highlight. So if I take your comment above it looks like this:
<ItemGroup>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/image.png"Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/logo.png"Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile>
</TestFile>
</ItemGroup>
See https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markdown for more info.
@eerhardt
eerhardt
commented
May 16, 2018

Copy link


Copy Markdown

Member
I see a few more references to housing.txt in the test code:
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestCSharpApi.cs(275): var dataPath = GetDataPath(@"housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(861): var dataPath = GetDataPath("housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(893): TestEntryPointRoutine("housing.txt", "Trainers.StochasticDualCoordinateAscentRegressor");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(967): TestEntryPointRoutine("housing.txt", "Trainers.PoissonRegressor");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(151): trainFilename = "housing.txt",
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(152): testFilename = "housing.txt"
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1496): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1536): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1608): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1649): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");

Can you update them all?
danmoseley
danmoseley
reviewed
May 17, 2018
View reviewed changes
Comment threadbuild.proj
Outdated



 <ItemGroup>
 <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
@danmoseleydanmoseleyMay 17, 2018•

edited by Ivanidzo4ka

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, I believe the attribute and subelement formats are equivalent, you might want to pick one or the other. #Resolved
@Ivanidzo4kaIvanidzo4kaMay 18, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't move Include to subelement, but I can move Url to it. having everything as attribute is looks too long
In reply to: 189065564 [](ancestors = 189065564)
@eerhardteerhardtMay 22, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a requesting change here, just giving some information for future reference.
The Include attribute on an MSBuild Item is "special". It has to be an XML attribute. Before MSBuild v15, all "custom" metadata (like your Url attribute) could NOT be put as an XML attribute - instead it had to be a sub-element. In v15, they changed it so custom metadata now can be in either an attribute or sub-element.
A format I like and use regularly is the following:
 <TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"DestinationFile="$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv" />
I think it is compact, reads easy, and is easy to maintain/update.
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
We don't run any of these tests. #78 Anirudh has PR to enable them, and it should be resolved in that PR. (Either by Anirudh, or me)
In reply to: 389680637 [](ancestors = 389680637)
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
@dotnet-bot test Windows_NT Debug
eerhardt
eerhardt
approved these changes
May 22, 2018
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 22, 2018

Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 22, 2018

Copy link


Copy Markdown

ContributorAuthor
Anyone other than Eric can look on this? @glebuk
@glebuk
glebuk
commented
May 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 using (var loader = new BinaryLoader(Env, new BinaryLoader.Arguments(), confusionMatrixPath))

Missing TestCSarpAPI?

#Closed
Refers to: test/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs:1037 in 45478c2. [](commit_id = 45478c2, deletion_comment = False)
glebuk
glebuk
reviewed
May 22, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
Outdated

 public void EntryPointEvaluateRegression()
 {
 var dataPath = GetDataPath("housing.txt");
 var dataPath = GetDataPath(@"external/winequality-white.csv");
@glebukglebukMay 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@"external/winequality-white.csv [](start = 39, length = 32)
Extract dataset info into static dataset classes so that no need to repeat paths and schemas. Ideally you can even just return a new loader for each dataset. #Closed
glebuk
glebuk
approved these changes
May 23, 2018
View reviewed changes
@glebukglebuk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit d51321c
into
dotnet:masterMay 23, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@Ivanidzo4ka@eerhardt
switch housing dataset to wine (dotnet#170)
5a454ab
* replace housing uci dataset to wine quality
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@eerhardteerhardteerhardt approved these changes
@glebukglebukglebuk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ivanidzo4ka@eerhardt@glebuk@danmoseley

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
switch housing dataset to wine - #170
Merged
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
May 23, 2018
Merged
switch housing dataset to wine#170
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
Conversation
@Ivanidzo4ka
@Ivanidzo4kaIvanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

Contributor
This commit replaces housing dataset to wine dataset which we download during build from external source
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 16, 2018
 Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

ContributorAuthor
address #3
eerhardt
eerhardt
reviewed
May 16, 2018
View reviewed changes
Comment threadbuild.proj
Outdated

 </TestFile>
 </ItemGroup>

 <Target Name="DownloadExternalTestFiles" Inputs="@(TestFile)" Outputs="%(TestFile.Result)">
@eerhardteerhardtMay 16, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do me a favor and test this with 2 or 3 datasets downloaded from the internet? (I guess it can be any file, it doesn't have to be a .csv file) I just want to ensure this works with more than 1 file, and it works correctly when doing it a 2nd time that the data sets aren't downloaded on subsequent builds.
That way the next person who needs to add a dataset isn't bit by a bug here.
@Ivanidzo4kaIvanidzo4kaMay 16, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 <ItemGroup> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/image.png" Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/logo.png" Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile> </TestFile> </ItemGroup>

test it with this. tried different combinations, they all work

Is there are any way to format it properly?
@eerhardteerhardtMay 17, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! nice to hear it works for many items.
As for the formatting, if you use triple back-ticks ``` at the start of a line, markdown will show exactly what you type until the next set of triple back-ticks. This is useful for displaying code. You can even put a code hint after the triple back-ticks XML, and markdown will syntax highlight. So if I take your comment above it looks like this:
<ItemGroup>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/image.png"Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/logo.png"Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile>
</TestFile>
</ItemGroup>
See https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markdown for more info.
@eerhardt
eerhardt
commented
May 16, 2018

Copy link


Copy Markdown

Member
I see a few more references to housing.txt in the test code:
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestCSharpApi.cs(275): var dataPath = GetDataPath(@"housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(861): var dataPath = GetDataPath("housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(893): TestEntryPointRoutine("housing.txt", "Trainers.StochasticDualCoordinateAscentRegressor");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(967): TestEntryPointRoutine("housing.txt", "Trainers.PoissonRegressor");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(151): trainFilename = "housing.txt",
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(152): testFilename = "housing.txt"
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1496): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1536): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1608): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1649): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");

Can you update them all?
danmoseley
danmoseley
reviewed
May 17, 2018
View reviewed changes
Comment threadbuild.proj
Outdated



 <ItemGroup>
 <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
@danmoseleydanmoseleyMay 17, 2018•

edited by Ivanidzo4ka

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, I believe the attribute and subelement formats are equivalent, you might want to pick one or the other. #Resolved
@Ivanidzo4kaIvanidzo4kaMay 18, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't move Include to subelement, but I can move Url to it. having everything as attribute is looks too long
In reply to: 189065564 [](ancestors = 189065564)
@eerhardteerhardtMay 22, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a requesting change here, just giving some information for future reference.
The Include attribute on an MSBuild Item is "special". It has to be an XML attribute. Before MSBuild v15, all "custom" metadata (like your Url attribute) could NOT be put as an XML attribute - instead it had to be a sub-element. In v15, they changed it so custom metadata now can be in either an attribute or sub-element.
A format I like and use regularly is the following:
 <TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"DestinationFile="$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv" />
I think it is compact, reads easy, and is easy to maintain/update.
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
We don't run any of these tests. #78 Anirudh has PR to enable them, and it should be resolved in that PR. (Either by Anirudh, or me)
In reply to: 389680637 [](ancestors = 389680637)
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
@dotnet-bot test Windows_NT Debug
eerhardt
eerhardt
approved these changes
May 22, 2018
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 22, 2018

Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 22, 2018

Copy link


Copy Markdown

ContributorAuthor
Anyone other than Eric can look on this? @glebuk
@glebuk
glebuk
commented
May 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 using (var loader = new BinaryLoader(Env, new BinaryLoader.Arguments(), confusionMatrixPath))

Missing TestCSarpAPI?

#Closed
Refers to: test/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs:1037 in 45478c2. [](commit_id = 45478c2, deletion_comment = False)
glebuk
glebuk
reviewed
May 22, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
Outdated

 public void EntryPointEvaluateRegression()
 {
 var dataPath = GetDataPath("housing.txt");
 var dataPath = GetDataPath(@"external/winequality-white.csv");
@glebukglebukMay 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@"external/winequality-white.csv [](start = 39, length = 32)
Extract dataset info into static dataset classes so that no need to repeat paths and schemas. Ideally you can even just return a new loader for each dataset. #Closed
glebuk
glebuk
approved these changes
May 23, 2018
View reviewed changes
@glebukglebuk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit d51321c
into
dotnet:masterMay 23, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@Ivanidzo4ka@eerhardt
switch housing dataset to wine (dotnet#170)
5a454ab
* replace housing uci dataset to wine quality
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@eerhardteerhardteerhardt approved these changes
@glebukglebukglebuk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ivanidzo4ka@eerhardt@glebuk@danmoseley

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
switch housing dataset to wine - #170
Merged
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
May 23, 2018
Merged
switch housing dataset to wine#170
Ivanidzo4ka merged 14 commits into
dotnet:masterfrom 
Ivanidzo4ka:ivanidze/switch_housing_dataset_to_wine
Conversation
@Ivanidzo4ka
@Ivanidzo4kaIvanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

Contributor
This commit replaces housing dataset to wine dataset which we download during build from external source
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 16, 2018
 Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 16, 2018

Copy link


Copy Markdown

ContributorAuthor
address #3
eerhardt
eerhardt
reviewed
May 16, 2018
View reviewed changes
Comment threadbuild.proj
Outdated

 </TestFile>
 </ItemGroup>

 <Target Name="DownloadExternalTestFiles" Inputs="@(TestFile)" Outputs="%(TestFile.Result)">
@eerhardteerhardtMay 16, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do me a favor and test this with 2 or 3 datasets downloaded from the internet? (I guess it can be any file, it doesn't have to be a .csv file) I just want to ensure this works with more than 1 file, and it works correctly when doing it a 2nd time that the data sets aren't downloaded on subsequent builds.
That way the next person who needs to add a dataset isn't bit by a bug here.
@Ivanidzo4kaIvanidzo4kaMay 16, 2018•

edited

Loading

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

 <ItemGroup> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/image.png" Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile> </TestFile> <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/logo.png" Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile> </TestFile> </ItemGroup>

test it with this. tried different combinations, they all work

Is there are any way to format it properly?
@eerhardteerhardtMay 17, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! nice to hear it works for many items.
As for the formatting, if you use triple back-ticks ``` at the start of a line, markdown will show exactly what you type until the next set of triple back-ticks. This is useful for displaying code. You can even put a code hint after the triple back-ticks XML, and markdown will syntax highlight. So if I take your comment above it looks like this:
<ItemGroup>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/image.png"Url="https://www.google.com/logos/doodles/2018/tamara-de-lempickas-120th-birthday-4614326680813568-l.png">
<DestinationFile>$(MSBuildThisFileDirectory)test/data/external/image.png</DestinationFile>
</TestFile>
<TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/logo.png"Url="https://www.baidu.com/img/bd_logo1.png"> <DestinationFile>$(MSBuildThisFileDirectory)test/data/external/logo.png</DestinationFile>
</TestFile>
</ItemGroup>
See https://guides.github.com/features/mastering-markdown/#GitHub-flavored-markdown for more info.
@eerhardt
eerhardt
commented
May 16, 2018

Copy link


Copy Markdown

Member
I see a few more references to housing.txt in the test code:
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestCSharpApi.cs(275): var dataPath = GetDataPath(@"housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(861): var dataPath = GetDataPath("housing.txt");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(893): TestEntryPointRoutine("housing.txt", "Trainers.StochasticDualCoordinateAscentRegressor");
F:\git\machinelearning\test\Microsoft.ML.Core.Tests\UnitTests\TestEntryPoints.cs(967): TestEntryPointRoutine("housing.txt", "Trainers.PoissonRegressor");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(151): trainFilename = "housing.txt",
F:\git\machinelearning\test\Microsoft.ML.TestFramework\Datasets.cs(152): testFilename = "housing.txt"
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1496): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1536): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1608): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");
F:\git\machinelearning\test\Microsoft.ML.TestFramework\TestCommandBase.cs(1649): string pathData = GetDataPath(@"..\Housing (regression)", "housing.txt");

Can you update them all?
danmoseley
danmoseley
reviewed
May 17, 2018
View reviewed changes
Comment threadbuild.proj
Outdated



 <ItemGroup>
 <TestFile Include="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv" Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv">
@danmoseleydanmoseleyMay 17, 2018•

edited by Ivanidzo4ka

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, I believe the attribute and subelement formats are equivalent, you might want to pick one or the other. #Resolved
@Ivanidzo4kaIvanidzo4kaMay 18, 2018

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't move Include to subelement, but I can move Url to it. having everything as attribute is looks too long
In reply to: 189065564 [](ancestors = 189065564)
@eerhardteerhardtMay 22, 2018

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a requesting change here, just giving some information for future reference.
The Include attribute on an MSBuild Item is "special". It has to be an XML attribute. Before MSBuild v15, all "custom" metadata (like your Url attribute) could NOT be put as an XML attribute - instead it had to be a sub-element. In v15, they changed it so custom metadata now can be in either an attribute or sub-element.
A format I like and use regularly is the following:
 <TestFileInclude="$(MSBuildThisFileDirectory)/test/data/external/winequality-white.csv"Url="https://archive.ics.uci.edu/ml/machine-learning-databases/wine-quality/winequality-white.csv"DestinationFile="$(MSBuildThisFileDirectory)test/data/external/winequality-white.csv" />
I think it is compact, reads easy, and is easy to maintain/update.
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
We don't run any of these tests. #78 Anirudh has PR to enable them, and it should be resolved in that PR. (Either by Anirudh, or me)
In reply to: 389680637 [](ancestors = 389680637)
@Ivanidzo4ka
Ivanidzo4ka
commented
May 18, 2018

Copy link


Copy Markdown

ContributorAuthor
@dotnet-bot test Windows_NT Debug
eerhardt
eerhardt
approved these changes
May 22, 2018
View reviewed changes
@eerhardteerhardt
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4kaIvanidzo4ka
mentioned this pull request
May 22, 2018

Closed

@Ivanidzo4ka
Ivanidzo4ka
commented
May 22, 2018

Copy link


Copy Markdown

ContributorAuthor
Anyone other than Eric can look on this? @glebuk
@glebuk
glebuk
commented
May 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
 using (var loader = new BinaryLoader(Env, new BinaryLoader.Arguments(), confusionMatrixPath))

Missing TestCSarpAPI?

#Closed
Refers to: test/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs:1037 in 45478c2. [](commit_id = 45478c2, deletion_comment = False)
glebuk
glebuk
reviewed
May 22, 2018
View reviewed changes
Comment threadtest/Microsoft.ML.Core.Tests/UnitTests/TestEntryPoints.cs
Outdated

 public void EntryPointEvaluateRegression()
 {
 var dataPath = GetDataPath("housing.txt");
 var dataPath = GetDataPath(@"external/winequality-white.csv");
@glebukglebukMay 22, 2018•

edited

Loading

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@"external/winequality-white.csv [](start = 39, length = 32)
Extract dataset info into static dataset classes so that no need to repeat paths and schemas. Ideally you can even just return a new loader for each dataset. #Closed
glebuk
glebuk
approved these changes
May 23, 2018
View reviewed changes
@glebukglebuk
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:
@Ivanidzo4ka
Ivanidzo4ka
merged commit d51321c
into
dotnet:masterMay 23, 2018
eerhardt pushed a commit
to eerhardt/machinelearning
that referenced
this pull request
Jul 27, 2018
@Ivanidzo4ka@eerhardt
switch housing dataset to wine (dotnet#170)
5a454ab
* replace housing uci dataset to wine quality
@ghostghost
locked as resolved and limited conversation to collaborators
Mar 30, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.


Reviewers


3 more reviewers

@danmoseleydanmoseleydanmoseley left review comments
@eerhardteerhardteerhardt approved these changes
@glebukglebukglebuk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@Ivanidzo4ka@eerhardt@glebuk@danmoseley